Re: Adding error messages to a few slash commands

2025-05-12 Thread Robin Haberkorn
in simple patches like this one -- would be to apply it to HEAD. And shouldn't that be better done as late as possible? [1] https://wiki.postgresql.org/wiki/Reviewing_a_Patch -- Robin Haberkorn Senior Software Engineer B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / https://w

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-05-07 Thread Robin Haberkorn
tches in question as a series and would suggest to just update the Commitfest entry. On the other hand, you might well accept the first patch, but reject the second one. Yours sincerely, Robin Haberkorn On Mon Apr 28, 2025 at 14:12:22 GMT +03, Robin Haberkorn wrote: > On Tue Apr 22, 2025 at 17:4

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-28 Thread Robin Haberkorn
On Tue Apr 22, 2025 at 17:47:20 GMT +03, Robin Haberkorn wrote: > Perhaps you can tell me what else is preventing adoption into core. I believe > that xslt_process() should also accept the `xml` type as an alternative to > strings. Strings should be kept for backwards compatibility, tho

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-24 Thread Robin Haberkorn
d already. What's the oldest distribution/OS you want to support PG on? Even Ubuntu 14.04 from 2014 already had libxml 2.9.1. If you like, I will prepare another patch to remove HAVE_XMLSTRUCTUREDERRORCONTEXT in a separate thread. PS: I added the libxslt error handling patch to the next commitf

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-23 Thread Robin Haberkorn
On Wed Apr 23, 2025 at 00:42:06 GMT +03, Robin Haberkorn wrote: > /* > * Legacy error handling mode. err_occurred is never set, we just add the > * message to err_buf. This mode exists because the xml2 contrib module > * uses our error-handling infrastructure, but we don't w

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-22 Thread Robin Haberkorn
d clean out the use > of PG_XML_STRICTNESS_LEGACY in xml2/xpath.c as well? I think this is a separate construction site. We don't necessarily have to touch xpath.c and I didn't plan to do so in the near future. We should first determine whether the XPath support is actually worth keep

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-22 Thread Robin Haberkorn
I forgot the patch of course... -- Robin Haberkorn Senior Software Engineer B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / https://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537 From cc5be302aa4305403b8131f6c22c39e4dfb75bd1 Mon Sep 17 00:00:00

[PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-22 Thread Robin Haberkorn
nstead accept hstores. If you agree, I will work on these two tasks next. Yours sincerely, Robin Haberkorn [1]: https://www.postgresql.org/message-id/4C5ECEF9.3030806%40mlfowler.com [2]: https://www.postgresql.org/message-id/flat/4A6A276A.6090405%40dunslane.net -- Robin Haberkorn Senior Software

Re: [PATCH] Automatic client certificate selection support for libpq v1

2025-04-05 Thread Robin Haberkorn
anybody think, that a server-name-based certificate file selection feature should still be implemented? If yes, I would be happy to take care of it. If not, I would suggest to remove this item from the agenda/wiki. Best regards, Robin Haberkorn [1]: http://archives.postgresql.org/pgsql-hackers/2