> On Sep 29, 2021, at 9:01 AM, Christoph Berg wrote:
>
> Re: Richard Yen
>> Ah, thanks for the tip. That's right -- I can't assume the user's input is
>> a valid file. Updated patch here.
>
> Hi Richard,
>
> sorry for the very late respo
On Thu, Apr 29, 2021 at 12:05 PM Justin Pryzby wrote:
> I think you should be able to avoid crashing if passed a non-relmapper
> file.
> Make sure not to loop over more mappings than exist in the relmapper file
> of
> the given size.
>
> I guess you should warn if the number of mappings is too la
Thanks for the feedback, Justin. I've gone ahead and switched to use
memcmp. I also refactored it to:
1. Don't assume that any file with first 4 bytes matching the
relmapper magic number is a pg_relnode.map file
2. Don't assume the pg_relnode.map file is uncorrupted and intact; perform
a check o
Hello Hackers,
I recently had to work on a case where some catalog files were
corrupt and/or missing. One of the things we sought to inspect was
pg_filenode.map, but there was no tooling available to do so.
With the help of Álvaro H.. I've put together a patch to allow pg_filedump
to do some rud
Hello hackers,
I noticed that in some situations involving the use of REVOKE ON SCHEMA,
pg_dump
can produce a dump that cannot be restored. This prevents successful
pg_restore (and by corollary, pg_upgrade).
An example shell script to recreate this problem is attached. The error
output appears
