Hi,
Apologies, but I had already created a commit here:
https://commitfest.postgresql.org/23/2080/ .
Any preference on which to keep?
Thanks,
Raymond Martin
rama...@microsoft.com
torEnd) depend on the query ID
generated from pgss_post_parse_analyze. Fortunately, both of these
functions already check for query ID before doing work.
I really appreciate you putting this change into practice.
Great to see your results align with mine.
Thanks Pascal!!!
--
Raymond Martin
rama...@microsoft.com
Azure Database for PostgreSQL
Hi Christoph,
> you sent the patch as UTF-16, could you re-send it as plain ascii?
Apologies. I re-attached the plain ascii version.
--
Raymond Martin
rama...@microsoft.com
Azure Database for PostgreSQL
check_pgss_enabled.patch
Description: check_pgss_enabled.patch
e hope of
getting it approved during the next commit fest.
I will continue trying to find a simple performance test to exemplify the
performance degradation that I have seen with more complex workloads.
--
Raymond Martin
rama...@microsoft.com
Azure Database for PostgreSQL
check_pgss_enab
at, do you still think it would make sense to submit a patch like this?
--
Raymond Martin
rama...@microsoft.com
Azure Database for PostgreSQL
This also follows the paradigm set
by the rest of the pg_stat_statements codebase.
In the future, if we want only the query ID to be calculated maybe we can add
another option for that?
--
Raymond Martin
rama...@microsoft.com
Azure Database for PostgreSQL
mple queries in milliseconds:
PGSS loaded (ms)PGSS loaded + this patch (ms)
track = top 0.53 0.55
track = none 0.41 0.20
PGSS not loaded: 0.18ms
--
Raymond Martin
rama...@microsoft.com
Azure Database for PostgreSQL
