't happen too often, it's really satisfying when
it detects these issues automatically.
--
Raúl Marín Rodríguez
carto.com
> Marking the patch as either Ready for Committer or Waiting on Author
will help move things along.
Thanks for the heads-up, I've retested it again and it applies cleanly on
top of master and addresses the issue.
I've moved it to `Ready for Committer`.
--
Raúl Marín Rodríguez
carto.com
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Tested `pgbench-tap-glob-fix-1.patch` with a "+" in the path and the tap
Hi,
Any way I can help to get this commited? Should we add this to the commitfest?
Regards,
--
Raúl Marín Rodríguez
carto.com
Hi,
> - works around pgbench command splitting on spaces,
>if postgres sources are in a strangely named directory…
>I tested within a directory named "pg .* dir".
I've also tested it with the initial case (including a +) and it works.
--
Raúl Marín Rodríguez
carto.com
> Pushed with that correction.
Thanks a lot!
--
Raúl Marín Rodríguez
carto.com
(\.\d+)?$/, "@quoted_prefix.20745");
my @found3 = grep(/^@quoted_prefix\.\d+(\.\d+)?$/, "@prefix.20745");
my @found4 = grep(/^@quoted_prefix\.\d+(\.\d+)?$/, "@quoted_prefix.20745");
print "1: @found1\n";
print "2: @found2\n";
print "3: @found3\n&q
/jkorpela.fi/perl/regexp.html
2 -
https://launchpadlibrarian.net/406634533/buildlog_ubuntu-xenial-amd64.postgresql-11_11.1.1+carto-2_BUILDING.txt.gz
3 - https://perldoc.perl.org/functions/quotemeta.html
Regards,
--
Raúl Marín Rodríguez
carto.com
diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/
Hi,
I understand it, as I said it's not an issue; just annoying when using
sanitizers. Thanks for the information.
--
Raúl Marín Rodríguez
carto.com
t anyway.
I'm attaching a the patch with the changes.
Greetings,
Greetings,
--
Raúl Marín Rodríguez
carto.com
From 0d35d7a21b87554df7ef27b70dcf7e4ea512699f Mon Sep 17 00:00:00 2001
From: Raul Marin
Date: Wed, 14 Nov 2018 09:08:50 +0100
Subject: [PATCH] pg_config: Avoid leaking conf
n a
race condition, so I'll drop those checks.
Thanks a lot for the information.
Regards,
--
*Raúl Marín Rodríguez *carto.com
made seem to confirm this is true, but I was wondering
if
there is any guarantee.
Regards
--
*Raúl Marín Rodríguez *carto.com
st to match
pow() speed.
I'm attaching both patches in case someone wants to have a look but I would
go with the simpler solution (pgbench_pow_v10.patch).
Regards,
--
*Raúl Marín Rodríguez *carto.com
From 28bc71f657fa967bafc03c015e5e2405c427a711 Mon Sep 17 00:00:00 2001
From: Raul Marin
Da
k to int won't bring it back.
>
> In the doc, I'm not sure that "Numeric" brings anything. "Exponentiation"
> would be enough.
>
> Also, in pg I just noticed that POW is a shorthand for POWER. Maybe both
> should be supported? Or not.
>
> --
compatible with Robert's
> constraints.
>
> --
> Fabien.
>
--
*Raúl Marín Rodríguez *carto.com
From 0b43116dc68cbe46d5f5caa9ba10f36cda188949 Mon Sep 17 00:00:00 2001
From: Raul Marin
Date: Thu, 21 Dec 2017 20:28:02 +0100
Subject: [PATCH] Add pow() support to pgbench
---
doc/s
Hi all,
I've been giving a thought about this and I think we could reach the
compromise
of having a single function with 2 overloads:
* pow(double, double) -> double: Uses C pow().
* pow(int, int) -> double: Uses ipow() for positive exponents, and pow()
for negative exponents.
In both cases we'd
r if we switch to "dpow" (which is pow with some error handling) and
always
return a double. What do you think?
On Fri, Dec 1, 2017 at 8:02 PM, Robert Haas wrote:
> On Fri, Dec 1, 2017 at 4:57 AM, Raúl Marín Rodríguez
> wrote:
> > I've rebased the patch so it c
n xml-ization.
>>
>
> Regenerated v15 that applies cleanly on head. No changes.
>
> --
> Fabien.
--
*Raúl Marín Rodríguez *carto.com
h
(pgbench-more-ops-funcs-14.patch) but it also stopped applying cleanly so I
decided to go for master to avoid having too many issues. Let me know if
you rework that patch and I'll be happy to rebase mine on top.
--
*Raúl Marín Rodríguez *carto.com
t; > day.
>
> Which is not the case yet, so moved to CF 2018-01. Please note that
> the patch proposed does not apply anymore, so its status is changed to
> "waiting on author" for a rebase.
> --
> Michael
>
--
*Raúl Marín Rodríguez *carto.com
From b12a7a37b1af1e
20 matches
Mail list logo
