Re: very long record lines in expanded psql output

2021-10-03 Thread Platon Pronko
Hi, + pg_log_error("\\pset: allowed xheader_width values are full (default), column, page, or an number specifying exact width."); an number specifying -> a number specifying Cheers Fixed, attaching the updated patch. Thank you! Best regards, Platon Pronkodiff --git a/doc/sr

Re: very long record lines in expanded psql output

2021-10-03 Thread Platon Pronko
On 2021-09-24 14:42, Andrew Dunstan wrote: On 9/24/21 12:49 AM, Platon Pronko wrote: On 2021-09-23 22:28, Andrew Dunstan wrote: 2. It would possibly be better to pass the relevant parts of the options to print_aligned_vertical_line() rather than the whole options structure. It feels odd to

Re: very long record lines in expanded psql output

2021-09-23 Thread Platon Pronko
- passing only whole options structure? That way we will roll 4 parameters (opt_border, printTextFormat, and two xheader ones) into only one argument. This increases code coupling a bit, but I'm not sure if that's relevant here. Best regards, Platon Pronko

Re: very long record lines in expanded psql output

2021-08-23 Thread Platon Pronko
Hi! Done, here's the link: https://commitfest.postgresql.org/34/3295/ Best regards, Platon Pronko On 2021-08-23 21:14, Andrew Dunstan wrote: On 8/23/21 2:00 PM, Platon Pronko wrote: Hi! Apparently I did forget something, and that's the patch itself :) Thanks for Justin Pryzby fo

Re: very long record lines in expanded psql output

2021-08-23 Thread Platon Pronko
Hi! Apparently I did forget something, and that's the patch itself :) Thanks for Justin Pryzby for pointing this out. Attaching the patch now. Best regards, Platon Pronko On 2021-08-23 20:51, Platon Pronko wrote: Hi! Please find attached the patch implementing the proposed changes. I h

Re: very long record lines in expanded psql output

2021-08-23 Thread Platon Pronko
Hi! Please find attached the patch implementing the proposed changes. I hope I didn't forget anything (docs, tab completion, comments, etc), if I did forget something please tell me and I'll fix it. Best regards, Platon Pronko On 2021-08-08 01:18, Andrew Dunstan wrote: On 8/7/2

Re: very long record lines in expanded psql output

2021-08-07 Thread Platon Pronko
ny other modes, and placing that in the option name makes intent a bit clearer. 2. What was "column" option in your original suggestion supposed to do? ("\pset xheader_width column|page|nnn") 3. Should we bother with using this option when in "\pset border 2" mode? I can do it for consistency, but it will still look bad. Best regards, Platon Pronko

Re: very long record lines in expanded psql output

2021-08-05 Thread Platon Pronko
n f0 478 1 {postgres=arwdDxt/postgres} \N \N You can still copy the necessary parts (using mouse selection) - seems that it achieves the the same goal. Best regards, Platon Pronko

Re: very long record lines in expanded psql output

2021-08-05 Thread Platon Pronko
xtended mode too often. To clarify: I'm not suggesting my patch anymore - it definitely breaks pspg and this is completely unacceptable. We're just discussing the possible alternate solutions, I think. Best regards, Platon Pronko

Re: very long record lines in expanded psql output

2021-08-05 Thread Platon Pronko
copy (...) to stdout" already works nicely, no need to create a special mode just for that. I think the question was more about being able to copy in an ad-hoc way, in the middle of scrolling trough "normal" output. Best regards, Platon Pronko

Re: very long record lines in expanded psql output

2021-08-05 Thread Platon Pronko
I agree, and I think this can be implemented, but I'm a bit afraid of introducing an additional psql option (there's already quite a lot of them). I suspect primary PostgreSQL maintainers won't be happy with such an approach. Best regards, Platon Pronko

Re: very long record lines in expanded psql output

2021-08-05 Thread Platon Pronko
Hi! I also find this annoying and would be happy to be rid of it. Have you tried "\pset format wrapped"? Pavel suggested it, and it solved most of the problem for me, for example. Best regards, Platon Pronko

very long record lines in expanded psql output

2021-08-05 Thread Platon Pronko
─ n│ 210 long_column_name │ x xxxxxxxx x Best regards, Pl