Allow Index AM scan API to access information about LIMIT clause

2023-08-17 Thread Peifeng Qiu
s approach should be compatible with existing extensions if we place the newly added pointer at the end of IndexScanDesc. Another approach is adding a new API to IndexAmRoutine and give the extension a way to access plan information. But this doesn't seems to provide more benefits compare to the above approach. Thoughts? Best regards, Peifeng Qiu

psql: stop at error immediately during \copy

2022-12-28 Thread Peifeng Qiu
code(psql) can detect the error via PQerrorMessage(). Probably still lots of details need to be considered but should be good enough to start this discussion. Any thoughts on this issue? Best regards Peifeng Qiu From a155adf6c1e6a6c31cf4146ce53827180247f384 Mon Sep 17 00:00:00 2001 From: Peifeng Qiu

Re: Optimize common expressions in projection evaluation

2022-12-05 Thread Peifeng Qiu
nd see if we can avoid the duplicate evaluation issue. Peifeng Qiu

Re: Optimize common expressions in projection evaluation

2022-12-04 Thread Peifeng Qiu
at can emit json data in different formats. We need different convert_func to extract the actual fields out. The client know which function to use, but as the each json may have hundreds of columns, the performance is very poor. Best regards, Peifeng Qiu

Optimize common expressions in projection evaluation

2022-12-01 Thread Peifeng Qiu
erence to assist grouping? - This can only handle FuncExpr as the root node of FieldSelect arg. What about a more general expression? - How to determine whether a common expression is safe to be optimized this way? Any unexpcted side-effects? Any thoughts on this approach? Best

Re: Kerberos delegation support in libpq and postgres_fdw

2021-07-22 Thread Peifeng Qiu
Hi all. I've slightly modified the patch to support "gssencmode" and added TAP tests. Best regards, Peifeng Qiu ____ From: Peifeng Qiu Sent: Tuesday, July 20, 2021 11:05 AM To: pgsql-hackers@lists.postgresql.org ; Magnus Hagander ; Stephen Frost ; Tom

Kerberos delegation support in libpq and postgres_fdw

2021-07-19 Thread Peifeng Qiu
figuration currently. I will go on to work with TAP tests for this. How do you feel about this patch? Any feature/security concerns about this? Best regards, Peifeng Qiu diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c index 8cc23ef7fb..235c9b32f5 100644 --- a/src/backend/libpq/auth.c

Re: Support kerberos authentication for postgres_fdw

2021-07-14 Thread Peifeng Qiu
Hi all. I've come up with a proof-of-concept patch using the delegation/proxy approach. Let's say we have two DB, one for FDW and one for the real server. When client connects to FDW server using kerberos authentication, we can obtain a "proxy" credential and store it in the global variable "MyPr

Re: Support kerberos authentication for postgres_fdw

2021-07-12 Thread Peifeng Qiu
>But in this case, what dose Kerberos give over just using a password >based solution? It adds complexity, but what's teh actual gain? That's due to policy of some customers. They require all login to be kerberos based and password-less. I suppose this way they don't need to maintain passwords in

Re: Support kerberos authentication for postgres_fdw

2021-07-12 Thread Peifeng Qiu
>As you note, this'd have to be restricted to superusers, which makes it >seem like a pretty bad idea. We really don't want to be in a situation >of pushing people to run day-to-day stuff as superuser. Yeah, having >access to kerberos auth sounds good on the surface, but it seems like >it would b

Re: Support kerberos authentication for postgres_fdw

2021-07-12 Thread Peifeng Qiu
Sorry I have sent a duplicate email. I will first continue discussion in the other thread and then submit it after we have a conclusion. Thanks. Peifeng

Support kerberos authentication for postgres_fdw

2021-07-09 Thread Peifeng Qiu
Hi hackers, I'd like to add kerberos authentication support for postgres_fdw by adding two options to user mapping: krb_client_keyfile and gssencmode. In the backend we have krb_server_keyfile option to specify a keytab file to be used by postgres server, krb_client_keyfile is doing mostly the sa

Support kerberos authentication for postgres_fdw

2021-07-09 Thread Peifeng Qiu
Hi hackers, I'd like to add kerberos authentication support for postgres_fdw by adding two options to user mapping: krb_client_keyfile and gssencmode. In the backend we have krb_server_keyfile option to specify a keytab file to be used by postgres server, krb_client_keyfile is doing mostly the sa

Re: Compile from source using latest Microsoft Windows SDK

2019-07-22 Thread Peifeng Qiu
use the same SDK version. Best regards, Peifeng Qiu

Re: Compile from source using latest Microsoft Windows SDK

2019-07-19 Thread Peifeng Qiu
erver 2016 and VS2017, on both azure and google cloud. So better to patch the build system anyway. Peifeng Qiu Best regards, On Thu, Jul 18, 2019 at 4:09 PM Michael Paquier wrote: > Hi Peifeng, > > On Fri, Mar 29, 2019 at 12:01:26AM +0900, Peifeng Qiu wrote: > > The current Wind

Compile with 64-bit kerberos on Windows

2019-04-16 Thread Peifeng Qiu
ackage. The correct include directory is '\include'. The library paths also need to be fixed with 64-bit version. Here's a patch to fixed these paths, with this patch we can build 64-bit binaries with kerberos support successfully. Best regards, Peifeng Qiu compile-with-64-bit-kerberos-on-windows-v1.patch Description: Binary data

Re: Speed up build on Windows by generating symbol definition in batch

2019-04-09 Thread Peifeng Qiu
Thanks for reviewing! I've updated the patch according to your comments. Best regards, Peifeng Qiu On Sun, Apr 7, 2019 at 2:31 PM Noah Misch wrote: > On Sat, Mar 30, 2019 at 03:42:39PM +0900, Peifeng Qiu wrote: > > When I watched the whole build process with a task manager

Speed up build on Windows by generating symbol definition in batch

2019-03-29 Thread Peifeng Qiu
y. I've tested on my 4-core 8-thread Intel i7 CPU. I've set MSBFLAGS=/m to ensure it can utilize all CPU cores. Building without this patch takes about 370 seconds. Building with this patch takes about 200 seconds. That's almost 2x speed up. Best regards, Peifeng Qiu generate-symbols-in-batch-on-windows-v1.patch Description: Binary data

Compile from source using latest Microsoft Windows SDK

2019-03-28 Thread Peifeng Qiu
.17763.0 So if we add WindowsTargetPlatformVersion to every project the whole pgsql solution will compile. The SDK version number can be obtained from "WindowsSDKVersion" environment variable. This is setup when you start with the Visual Studio Command Prompt. Attached a patch to fix the build system.