this patch? If not,
I would request we move to commit phase.
Thank you!
Regards,
Nishant Sharma (EDB).
>
On Tue, Dec 17, 2024 at 10:12 PM Robert Haas wrote:
> On Wed, Oct 9, 2024 at 7:12 AM Nishant Sharma
> wrote:
> > I have included them in v3. v3 does not allow empty schema_name &
> > table_name options along with column_name.
>
> I was looking at these patches to
On Fri, Dec 13, 2024 at 1:57 PM jian he wrote:
> On Wed, Dec 11, 2024 at 7:41 PM Nishant Sharma
> wrote:
> >
> > Thanks for the v3 patch!
> >
> > Please find review comments on v3:-
> >
> > 1) I think no need to change the below if condition, we can
; that would be more work.
> so i stick to if there is a table can use to
> error saving then use it, otherwise error out.
>
YES. but that would lead to a better design with an error table.
Also, I think Krill mentions the same. That is to auto create, if it
does not exist.
Regards,
Nishant
urn true;
+ }
cstate->num_errors++;
I was not able to test the v2 due to conflicts in v2, I did attempt to
resolve but I saw many failures in make world.
Regards,
Nishant.
On Tue, Aug 20, 2024 at 5:31 AM jian he wrote:
> On Mon, Jul 15, 2024 at 1:42 PM Nishant Sharma
> wrote:
>
On Mon, Oct 7, 2024 at 10:16 AM Michael Paquier wrote:
> On Thu, Aug 22, 2024 at 04:00:13PM +0530, Nishant Sharma wrote:
> > I may be wrong, but just wanted to share my thoughts on the differences.
> > So, it
> > can be considered a different issue/mistake and can be ha
e and can be handled separately in
another email thread.
I ran "make check world" and do not see any failure related to patches.
But, I do see
an existing failure "t/001_pgbench_with_server.pl".
Regards,
Nishant Sharma
EnterpriseDB, Pune.
On Mon, Aug 19, 2024 at 4:27 P
Oops...
I forgot to attach the patch. Thanks to Amul Sul for pointing that out. :)
On Fri, Aug 16, 2024 at 2:37 PM Nishant Sharma <
nishant.sha...@enterprisedb.com> wrote:
Hi,
--
Actual column names used while creation of foreign table are not allowed to
be an
empty string, but when we use column_name as an empty string in OPTIONS
during
CREATE or ALTER of fo
declarations Tab Spacing issue at multiple places.
11) Comments in the patch are not matched to PG comment style.
Kindly note I have not tested the patch properly yet. Only checked it with
a positive test
case. As I will wait for a conclusion on my opinion of the proposed patch.
Regards,
Nishant
Hi,
Any taker or rejector for above? -- It's a very small 'good to have' change
patch for cleanup.
Thanks,
Nishant (EDB).
On Tue, Sep 26, 2023 at 6:31 PM Nishant Sharma <
nishant.sha...@enterprisedb.com> wrote:
> Hi,
>
>
> PFA small code cleanup in twophase
Hi,
PFA small code cleanup in twophase.sql. Which contains a drop table
statement for 'test_prepared_savepoint'. Which, to me, appears to be
missing in the cleanup section of that file.
To support it I have below points:-
1) Grepping this table 'test_prepared_savepoint' shows occurrences
only i
On Tue, Sep 5, 2023 at 4:40 PM Jelte Fennema wrote:
> I modified the PgBouncer PR to always set the sign bit to 0. But I
> still I think it makes sense to also address this in pg_basebackup.
Sounds good to me. Thank you!
On Tue, Sep 5, 2023 at 5:36 PM Daniel Gustafsson wrote:
> Since the va
Hi Jelte,
Please find my reviews below:-
*1)* With what I have understood from above, the pgbouncer fills up
be_pid (int, 32 bits) with random bits as it does not have an
associated server connection yet.
With this, I was thinking, isn't this a problem of pgbouncer filling
be_pid with random bits
Looks good to me. Tested on master and it works.
New patch used a bool flag to avoid calls for both FDW and custom hook's
call. And a slight change in comment of "has_pseudoconstant_clauses"
function.
Regards,
Nishant.
On Wed, Jun 14, 2023 at 12:19 PM Etsuro Fujita
wrote:
> On Mon, Jun 5, 2023
Hi,
Etsuro's patch is also showing the correct output for "set
enable_nestloop=off". Looks good to me for back branches due to backport
issues.
But below are a few observations for the same:-
1) I looked into the query plan for both "set enable_nestloop" on & off
case and observe that they are t
I also agree that Richard's patch is better. As it fixes the issue at the
backend and does not treat pseudoconstant as local condition.
I have tested Richard's patch and observe that it is resolving the problem.
Patch looks good to me as well.
*I only had a minor comment on below change:-*
*
Hi Etsuro Fujita,
Any updates? -- did you get a chance to look into this?
Regards,
Nishant.
On Mon, Apr 17, 2023 at 11:00 AM Nishant Sharma <
nishant.sha...@enterprisedb.com> wrote:
> Thanks Etsuro for your response!
>
> One small typo correction in my answer to "What is
e:
> Hi Nishant,
>
> On Fri, Apr 14, 2023 at 8:39 PM Nishant Sharma
> wrote:
> > I debugged this issue and was able to find a fix for the same. Kindly
> please refer to the attached fix. With the fix I am able to resolve the
> issue.
>
> Thanks for the report and patch!
public.pg_tbl_foreign tbl1
(cost=100.00..159.06 rows=853 width=8) (never executed)
Output: tbl1.id1, tbl1.id2
Remote SQL: SELECT id1, id2 FROM public.pg_tbl WHERE
((id1 < 5))
Planning Time: 0.134 ms
Execution Time: 0.347 ms
(15 rows)
|***
sometimes
we have observed change in sequence in output.
Please find the patch attached
Regards,
Nishant Sharma
EDB: http://www.enterprisedb.com
Proposal_OrderBy_insert.sql.out.patch
Description: Binary data
21 matches
Mail list logo
