Hi Ashutosh,
Thank you for continuing to review the patch. Attached is v9,
incorporating the feedback. Please see my responses inline below.
On Fri, Sep 12, 2025 at 5:34 AM Ashutosh Bapat
wrote:
> + Returns statistics about current multixact usage:
> + num_mxids is the total number of multixact
Hi Ashutosh,
Thank you for continuing to review the patch. Attached is v8,
incorporating the feedback. Please see my responses inline below.
On Fri, Sep 5, 2025 at 6:27 AM Ashutosh Bapat
wrote:
>
> This one is remaining.
> + up to approximately 2^32 entries before reaching wraparound.
>
> ... 2^
Hi Atsushi and Ashutosh,
Thank you for reviewing the patch. Attached is v7, incorporating the
feedback. Please see my responses in-line below.
On Fri, Aug 22, 2025 at 6:45 AM Ashutosh Bapat
wrote:
>
> On Fri, Aug 22, 2025 at 7:37 AM torikoshia wrote:
> >
> > | Now that pg_get_multixact_stats()
On Tue, Aug 19, 2025 at 1:32 AM Michael Paquier wrote:
> FWIW, I think that you should be a bit more careful before sending
> updated patch sets. You have missed an extra point I have raised
> upthread about the refactoring pieces: the switch from
> ReadMultiXactCounts() to GetMultiXactInfo() can
Hi Michael, Ashutosh,
Thanks a lot for taking the time to review this patch and share your thoughts.
Here’s a short summary of what has changed in v5:
- Added the new pg_get_multixact_stats() function in multixactfuncs.c.
- Fixed the misleading “atomic read” comment in the accessor.
- Clarified d
Hi Michael, Ashutosh,
Thanks a lot for the detailed reviews and feedback. Please find
attached v4 of the patchset.
Summary of changes in v4:
- Split into two patches as suggested:
1. Expose and rename ReadMultiXactCounts() -> GetMultiXactInfo() in
multixact.h with clearer comments.
2. Add pg_
On Mon, Aug 4, 2025 at 1:16 AM Naga Appani wrote:
>
> Hi Ashutosh, Michael,
>
> Thanks for the detailed reviews. I have incorporated the feedback;
> please find attached v2 and my responses inline below.
>
> On Fri, Jul 25, 2025 at 5:57 AM Ashutosh Bapat
> wrote:
>
56
[1]
https://www.postgresql.org/message-id/flat/CACbFw60UOk6fCC02KsyT3OfU9Dnuq5roYxdw2aFisiN_p1L0bg%40mail.gmail.com
Best regards,
Naga Appani
v2-0001-Add-pg_get_multixact_stats-SQL-function-for-monit.patch
Description: Binary data
On Tue, Jun 10, 2025 at 11:40 AM Andrew Johnson wrote:
>
> Hi Naga,
>
> Thank you for the thoughtful feedback and for driving attention to
> this issue. I appreciate you taking the time to review my patch.
>
> You raise some good points about the trade-offs between a lightweight
> function and the
to estimate multixact membership usage
> through scanning the filesystem, but there are several drawbacks to
> that method that Naga Appani outlined in a previous thread [2].
>
> This complements Peter Geoghegan's recent thread about vacuum failsafe
> improvements [3], where S
On Tue, Mar 11, 2025 at 4:48 AM Kirill Reshke wrote:
>
> On Tue, 11 Mar 2025 at 14:37, Naga Appani wrote:
> >
> >
> >
> > On Mon, Mar 10, 2025 at 10:43 AM Naga Appani wrote:
> >>
> >> Hi,
> >>
>
> Hi
>
> > =
On Mon, Mar 10, 2025 at 10:43 AM Naga Appani wrote:
> Hi,
>
> I would like to propose exposing an internal PostgreSQL function called
> ReadMultiXactCounts() to allow for efficient monitoring of MultiXact
> member usage. This function provides an accurate, real-time view of
>
feedback or
discussion on this proposal.
Please let me know if this approach is acceptable, so I’ll go ahead and
submit a patch.
Thank you!
Best regards,
Naga Appani
Postgres Database Engineer
Amazon Web Services
13 matches
Mail list logo
