Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Looks good to me The new status of this patch is: Ready for Comm

Re: pg_dump handling of ALTER DEFAULT PRIVILEGES IN SCHEMA

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested The patch looks fine and successfully fixes the issue of missing

Re: [PATCH] Feature improvement for TRUNCATE tab completion.

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Other than "Hunk #1 succeeded at 3832 (offset 33 lines)." message whi

Re: A new function to wait for the backend exit after termination

On Wed, Dec 2, 2020 at 1:30 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Mon, Nov 30, 2020 at 8:10 PM Muhammad Usama wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: te

Re: A new function to wait for the backend exit after termination

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I have tested the patch against current master branch (commit:67

Re: pgbench - add pseudo-random permutation function

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested There are few "Stripping trailing CRs from the patch" and one "Hu

Re: Transactions involving multiple postgres foreign servers, take 2

0x00010d1597b9 main + 761 > > 12 libdyld.dylib 0x7fff7161e3d5 start + 1 > > 13 ??? 0x0003 0x0 + 3 > > > > Thank you for reporting the issue! > > I've attached the latest version pat

Re: Transactions involving multiple postgres foreign servers, take 2

On Fri, May 15, 2020 at 7:52 PM Masahiko Sawada < masahiko.saw...@2ndquadrant.com> wrote: > On Fri, 15 May 2020 at 19:06, Muhammad Usama wrote: > > > > > > > > On Fri, May 15, 2020 at 9:59 AM Masahiko Sawada < > masahiko.saw...@2ndquadrant.com> wro

Re: Transactions involving multiple postgres foreign servers, take 2

On Fri, May 15, 2020 at 9:59 AM Masahiko Sawada < masahiko.saw...@2ndquadrant.com> wrote: > On Fri, 15 May 2020 at 13:26, Muhammad Usama wrote: > > > > > > > > On Fri, May 15, 2020 at 7:20 AM Masahiko Sawada < > masahiko.saw...@2ndquadrant.com> wro

Re: Transactions involving multiple postgres foreign servers, take 2

On Fri, May 15, 2020 at 7:20 AM Masahiko Sawada < masahiko.saw...@2ndquadrant.com> wrote: > On Fri, 15 May 2020 at 03:08, Muhammad Usama wrote: > > > > > > Hi Sawada, > > > > I have just done some review and testing of the patches and have > > a co

Re: Transactions involving multiple postgres foreign servers, take 2

On Tue, May 12, 2020 at 11:45 AM Masahiko Sawada < masahiko.saw...@2ndquadrant.com> wrote: > On Thu, 30 Apr 2020 at 20:43, Masahiko Sawada > wrote: > > > > On Tue, 28 Apr 2020 at 19:37, Muhammad Usama wrote: > > > > > > > > > &g

Re: Transactions involving multiple postgres foreign servers, take 2

On Wed, Apr 8, 2020 at 11:16 AM Masahiko Sawada < masahiko.saw...@2ndquadrant.com> wrote: > On Fri, 27 Mar 2020 at 22:06, Muhammad Usama wrote: > > > > Hi Sawada San, > > > > I have been further reviewing and testing the transaction involving > multiple ser

Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2

equire to do atomic commit are capable enough of doing so. If I am not missing something obvious here, then IMHO the XACT_FLAGS_FDWNOPREPARE flag should only be set when the transaction management/two-phase functionality is not available and "modified" argument is true in register_fdwx

Proposal for syntax to support creation of partition tables when creating parent table

ot interfere with these ongoing proposals. Here is a link to one such discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1907150711080.22273%40lancre Please feel free to share your thoughts. Best Regards ... Muhammad Usama Highgo Software Canada URL : http://www.highgo.ca ADDR: 10318 WHALLEY BLVD, Surrey, BC new_partition_syntax_poc.diff Description: Binary data