Re: Fix for edge case in date_bin() function

2024-02-28 Thread Moaaz Assali
n doesn't output invalid timestamps that cannot be represented by Timestamp(tz) type anyways. Since all INT64 values can be mapped 1-to-1 in UINT64, I don't see where the problem is. Best regards, Moaaz Assali

Re: Fix for edge case in date_bin() function

2024-02-28 Thread Moaaz Assali
nking this email thread, so it can be added to the 2024-03 commitfest? Best regards, Moaaz Assali On Tue, Feb 27, 2024 at 11:13 PM Tom Lane wrote: > I wrote: > > Hmm, yeah. The "stride_usecs > 1" test seems like it's a partial > > attempt to account for this tha

Re: Fix for edge case in date_bin() function

2024-02-27 Thread Moaaz Assali
in my previous reply. This is just a copy of it. Best regards, Moaaz Assali On Tue, Feb 27, 2024 at 12:48 PM Daniel Gustafsson wrote: > > On 27 Feb 2024, at 09:42, Moaaz Assali wrote: > > > To account for this edge, we simply add another condition in the if > statement to not per

Fix for edge case in date_bin() function

2024-02-27 Thread Moaaz Assali
e, we simply add another condition in the if statement to not perform the subtraction by one stride interval if the time difference is divisible by the stride. Best regards, Moaaz Assali v1-0001-Fix-for-edge-case-in-date_bin-function.patch Description: Binary data