Re: Proposal to CREATE FOREIGN TABLE LIKE

2025-02-02 Thread Mingli Zhang
Zhang Mingli www.hashdata.xyz On Feb 2, 2025 at 21:24 +0800, Álvaro Herrera , wrote: Eh yeah, I guess for this use case it makes sense to allow a LIKE clause on CREATE FOREIGN TABLE. Were you going to submit a patch? Hi, Yes, I would like to provide a patch. Glad to see we have come to an agre

Re: useless list_tail()?

2025-01-15 Thread Mingli Zhang
Aleksander Alekseev 于2025年1月15日 周三21:47写道: > list_tail() is declared in a .h file. Removing it may break 3rd party > code. Make sense, other extensions may already be using it. >

Re: COPY TO (FREEZE)?

2023-10-29 Thread Mingli Zhang
Bruce Momjian 于2023年10月30日 周一03:35写道: > On Sun, Oct 29, 2023 at 02:50:37PM +0800, Mingli Zhang wrote: > > I guess you want to write “cannot be used with COPY TO” > > You are 100% correct. Updated patch attached. > > -- > Bruce Momjian ht

Re: COPY TO (FREEZE)?

2023-10-28 Thread Mingli Zhang
Mingli Zhang 于2023年10月29日 周日14:35写道: > > > Bruce Momjian 于2023年10月29日 周日10:04写道: > >> On Sat, Oct 28, 2023 at 09:54:05PM -0400, Tom Lane wrote: >> > Bruce Momjian writes: >> > > On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: >> > &g

Re: COPY TO (FREEZE)?

2023-10-28 Thread Mingli Zhang
Bruce Momjian 于2023年10月29日 周日10:04写道: > On Sat, Oct 28, 2023 at 09:54:05PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: > > >> Not thrilled by the wording here. > > > > > I think it is modeled after: > > > > > errmsg("COPY fo

Re: Buildfarm failures on chipmunk

2023-07-20 Thread Mingli Zhang
HI, > On Jul 21, 2023, at 11:40, vignesh C wrote: > > Hi, > > Recently chipmunk has failed with the following errors at [1]: > > make -C '../../..' > DESTDIR='/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install install >> '/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install/log/install.log

Re: Giving more detail in pg_upgrade errormessage

2023-07-18 Thread Mingli Zhang
Hi, > Is there a reason not to be verbose here as users might copy/paste this output > when asking for help? Seems better than nothing. > [0] CACoPQdbQTysF=ekckyfngtdpodxxmesf_2acno+bcnqqcb5...@mail.gmail.com Full link for convenience. [0]https://www.postgresql.org/message-id/CACoPQdbQTysF=ek

Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

2022-11-01 Thread Mingli Zhang
Hi, > > The point about cleaning up the attribute handling of FORCE_NOT_NULL > and FORCE_NULL in the COPY TO path is a good catch, though, so let's > remove all that. I'll go apply this part of the patch in a bit, or > tomorrow. > -- > Michael Thanks for review!