Re: disfavoring unparameterized nested loops

2021-08-02 Thread Mike Klaas
-jsonb-in-a-postgresql-schema (The proximate cause in this case was Postgresql not collecting statistics for fields in a JSONB column, estimating rowcount of 1, and thus creating a pathological slowdown.) –Mike On Tue, Jun 22, 2021 at 7:37 PM, Peter Geoghegan wrote: > On Tue, Jun 22, 2021 at 2

Re: Emit namespace in post-copy output

2021-06-25 Thread Mike
Awesome, thanks! Are there any other steps I should take? On Wed, Jun 23, 2021 at 5:46 PM Corey Huinker wrote: > On Tue, Jun 22, 2021 at 6:08 PM Mike wrote: > >> When running a VACUUM or CLUSTER command, the namespace name is not part >> of the emitted message. >> >

Fwd: Emit namespace in post-copy output

2021-06-22 Thread Mike
which `open` relation was completed. Attached is a patch using existing functions to include the namespace in the output string. Looking forward to feedback! -Mike Fiedler From c66506ad7440a1b501cca858b5120cc568f7a00b Mon Sep 17 00:00:00 2001 From: Mike Fiedler Date: Tue, 22 Jun 2021 12:05:48 -0400

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

2021-06-04 Thread Oh, Mike
This patch should address the same problem for pglogical as well. Thanks, Mike On 6/4/21, 3:55 PM, "ahsan hadi" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the conte

Re: Process initialization labyrinth

2021-04-02 Thread Mike Palmiotto
On Fri, Apr 2, 2021 at 1:02 PM Andres Freund wrote: > > Hi, > > On 2021-04-02 10:18:20 -0400, Mike Palmiotto wrote: > > I can't really speak to the initial points directly relating to > > pgstat/shmem, but for the overall maze-like nature of the startup > > co

Re: Process initialization labyrinth

2021-04-02 Thread Mike Palmiotto
...@mail.gmail.com I know you are at least vaguely aware of the efforts there, as you reviewed the patchset. Figured I should at least bring it up in case it seemed helpful, or an effort you'd like to re-invigorate. Thanks, -- Mike Palmiotto https://crunchydata.com

Re: Auxiliary Processes and MyAuxProc

2020-07-09 Thread Mike Palmiotto
On Thu, Jul 2, 2020 at 11:11 AM Alvaro Herrera wrote: > > On 2020-Mar-26, Mike Palmiotto wrote: > > Regarding 0001: > > > diff --git a/src/backend/postmaster/subprocess.c > > b/src/backend/postmaster/subprocess.c > > new file mode 100644 > > index 0

Re: some AppVeyor files

2020-03-27 Thread Mike Palmiotto
s useful in general for getting more post-build/post-failure information, in case you weren't configured for it already. [1] https://www.appveyor.com/docs/how-to/rdp-to-build-worker/ Thanks, -- Mike Palmiotto https://crunchydata.com

Re: Auxiliary Processes and MyAuxProc

2020-03-19 Thread Mike Palmiotto
seems fairly straightforward to me which subprocesses are in fact Auxiliary Processes. Thanks, -- Mike Palmiotto https://crunchydata.com

Re: Auxiliary Processes and MyAuxProc

2020-03-18 Thread Mike Palmiotto
On Wed, Mar 18, 2020 at 12:54 PM Alvaro Herrera wrote: > > On 2020-Mar-18, Mike Palmiotto wrote: > > > On Wed, Mar 18, 2020 at 11:26 AM Mike Palmiotto > > wrote: > > > > > > On Wed, Mar 18, 2020 at 10:17 AM Justin Pryzby > > > wrote: > >

Re: Auxiliary Processes and MyAuxProc

2020-03-18 Thread Mike Palmiotto
On Wed, Mar 18, 2020 at 10:17 AM Justin Pryzby wrote: > > On Wed, Mar 18, 2020 at 09:22:58AM -0400, Mike Palmiotto wrote: > > On Tue, Mar 17, 2020 at 9:04 PM Alvaro Herrera > > wrote: > > > > > > On 2020-Mar-17, Justin Pryzby wrote: > > &g

Re: Auxiliary Processes and MyAuxProc

2020-03-18 Thread Mike Palmiotto
> + }, > > + { > > + .desc = "bootstrap", > > + .entrypoint = BootstrapModeMain > > + }, > > Maybe this stuff can be resolved using a technique like rmgrlist.h or > cmdtaglist.h. That way it's not in two separate f

Re: backend type in log_line_prefix?

2020-03-17 Thread Mike Palmiotto
pgstat_get_backend_desc code) while also centralizing/standardizing process startup. A few useful features (outside of code reduction) include the ability to identify backends prior to their Main functions, cleaner control of SubPostmasterMain logic (including implicit handling of shmem timing c

Re: Auxiliary Processes and MyAuxProc

2020-03-02 Thread Mike Palmiotto
On Sat, Feb 29, 2020 at 9:51 PM Mike Palmiotto wrote: > > On Sat, Nov 30, 2019 at 9:15 PM Michael Paquier wrote: > > > > On Thu, Oct 03, 2019 at 11:39:37AM -0700, Andres Freund wrote: > > > Color me unconvinced. > > > > The latest comments of the thre

Re: Auxiliary Processes and MyAuxProc

2020-02-29 Thread Mike Palmiotto
the open CommitFest before it closes. I'll go ahead and re-add it and will be pushing updates as I have them. I intend to give this patchset the time it deserves, so will be much more responsive this go-around. Thanks, -- Mike Palmiotto https://crunchydata.com From 34feb7399fe218eab0da851032

Re: Parallel copy

2020-02-18 Thread Mike Blackwell
on the actual use case. If we > expect to be parallel loading humungous CSVs then that won't fly. Loading large CSV files is pretty common here. I hope this can be supported. MIKE BLACKWELL * * >

[Patch]: Documentation of ALTER TABLE re column type changes on binary-coercible fields

2020-01-28 Thread Mike Lissner
Hi all, I didn't get any replies to this. Is this the right way to send in a patch to the docs? Thanks, Mike On Thu, Jan 23, 2020 at 11:01 PM Mike Lissner < mliss...@michaeljaylissner.com> wrote: > Hi, first patch here and first post to pgsql-hackers. Here goes. > > En

Patching documentation of ALTER TABLE re column type changes on binary-coercible fields

2020-01-23 Thread Mike Lissner
but I suspect this is small enough somebody will just pick it up. Mike Index: doc/src/sgml/ref/alter_table.sgml IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8

Re: Auxiliary Processes and MyAuxProc

2019-10-03 Thread Mike Palmiotto
On Thu, Oct 3, 2019 at 1:31 PM Andres Freund wrote: > > Hi, > > On 2019-09-30 15:13:18 -0400, Mike Palmiotto wrote: > > Attached is the reworked and rebased patch set. I put the hook on top > > and a separate commit for each process type. Note that avworker and > >

Re: Hooks for session start and end, take two

2019-10-03 Thread Mike Palmiotto
It would be possible to build such a mechanism into that existing architecture rather easily. Has anyone had a chance to review that work? Thanks, -- Mike Palmiotto https://crunchydata.com

Re: Auxiliary Processes and MyAuxProc

2019-09-30 Thread Mike Palmiotto
On Thu, Sep 26, 2019 at 6:03 PM Mike Palmiotto wrote: > > On Thu, Sep 26, 2019 at 10:56 AM Alvaro Herrera > wrote: > > > > > Well, I think it would be easier to manage as split patches, yeah. > > I think it'd be infrastructure that needs to be carefully rev

Re: Hooks for session start and end, take two

2019-09-27 Thread Mike Palmiotto
fork_process hook. The substance of the patchset will remain mostly the same if you want to take a look. I look forward to hearing your thoughts on the matter. Thanks, -- Mike Palmiotto https://crunchydata.com

Re: Auxiliary Processes and MyAuxProc

2019-09-26 Thread Mike Palmiotto
On Thu, Sep 26, 2019 at 10:56 AM Alvaro Herrera wrote: > > On 2019-Sep-26, Mike Palmiotto wrote: > > > On Thu, Sep 26, 2019 at 9:49 AM Alvaro Herrera > > wrote: > > > > > > 0002 seems way too large (and it doesn't currently apply). Is there > >

Re: Auxiliary Processes and MyAuxProc

2019-09-26 Thread Mike Palmiotto
0001 in second place rather than > first, since your other patch doesn't use it AFAICS and it adds > functionality that has not yet received approval [or even been > discussed], while the other is necessary refactoring. Sounds good. -- Mike Palmiotto https://crunchydata.com

Re: sepgsql seems rather thoroughly broken on Fedora 30

2019-07-19 Thread Mike Palmiotto
On Fri, Jul 19, 2019 at 4:29 PM Tom Lane wrote: > > Mike Palmiotto writes: > > We probably need to polish this a bit more, but what do you think > > about something similar to the attached patches? They should hopefully > > reduce some of the complexity of running these

Re: sepgsql seems rather thoroughly broken on Fedora 30

2019-07-19 Thread Mike Palmiotto
of running these regression tests. -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com From 7f22a9d40ab5ad5334351932bd9010f538ba222a Mon Sep 17 00:00:00 2001 From: Mike Palmiotto Date: Fri, 19 Jul 2019 14:15:23 -0400 Subject: [PATCH 1/2] Make sepgsql-regte

Re: sepgsql seems rather thoroughly broken on Fedora 30

2019-07-19 Thread Mike Palmiotto
On Thu, Jul 18, 2019 at 11:06 PM Tom Lane wrote: > > Mike Palmiotto writes: > > On Wed, Jul 17, 2019 at 12:32 PM Tom Lane wrote: > >> $ runcon -t sepgsql_regtest_user_t psql --help > >> psql: fatal: could not look up effective user ID 1000: user does not exist You

Re: sepgsql seems rather thoroughly broken on Fedora 30

2019-07-18 Thread Mike Palmiotto
unning `restorecon -RF /` to fix it. In any case, it looks like this entire test script and policy could use another layer of varnish, so I'll work on fixing up the messages/functionality and post a patch which makes this a bit more robust (hopefully a bit later tonight). Sorry for the delayed response. Hopefully the band-aid fixes I provided get you going for now. -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-07-12 Thread Mike Palmiotto
o research and affirm my previous assumptions, but will address all of these points as soon as I can. -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-07-11 Thread Mike Palmiotto
rtition_pruning && childOID) > +{ > > Normally we write OidIsValid(childOID) rather than comparing with 0. > I wonder if you should call the variable relId? Single line if > branches don't usually get curly braces. Fixed. > > + return (*partitionChil

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-07-08 Thread Mike Palmiotto
On Mon, Jul 8, 2019 at 10:59 AM Mike Palmiotto wrote: > > On Sun, Jul 7, 2019 at 9:46 PM Thomas Munro wrote: >> >> On Sat, Apr 6, 2019 at 3:06 PM Andres Freund wrote: >> > I've moved this to the next CF, and marked it as targeting v13. >> >> Hi Mike,

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-07-08 Thread Mike Palmiotto
On Sun, Jul 7, 2019 at 9:46 PM Thomas Munro wrote: > On Sat, Apr 6, 2019 at 3:06 PM Andres Freund wrote: > > I've moved this to the next CF, and marked it as targeting v13. > > Hi Mike, > > Commifest 1 for PostgreSQL 13 is here. I was just going through the > au

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-02-28 Thread Mike Palmiotto
r existing hook. This hook in particular would be used by security extensions that have some understanding of the underlying security model being implemented by RLS. Thanks, -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-02-27 Thread Mike Palmiotto
On Tue, Feb 26, 2019 at 1:06 PM Mike Palmiotto wrote: > > On Tue, Feb 26, 2019 at 1:55 AM Tsunakawa, Takayuki > wrote: > > > > From: Mike Palmiotto [mailto:mike.palmio...@crunchydata.com] > > > Attached is a patch which attempts to solve a few problems: Updated pa

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-02-26 Thread Mike Palmiotto
On Tue, Feb 26, 2019 at 1:55 AM Tsunakawa, Takayuki wrote: > > From: Mike Palmiotto [mailto:mike.palmio...@crunchydata.com] > > Attached is a patch which attempts to solve a few problems: > > > > 1) Filtering out partitions flexibly based on the results of an external >

Re: Auxiliary Processes and MyAuxProc

2019-02-25 Thread Mike Palmiotto
On Mon, Feb 25, 2019 at 1:41 PM Mike Palmiotto wrote: > > > > > > If memory serves, StartChildProcess already was an attempt to unify > > the treatment of postmaster children. It's possible that another > > round of unification would be productive, but I t

[RFC] [PATCH] Flexible "partition pruning" hook

2019-02-25 Thread Mike Palmiotto
your time. -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com diff --git a/src/backend/catalog/pg_inherits.c b/src/backend/catalog/pg_inherits.c index 00f7957b3d..c4711490f1 100644 --- a/src/backend/catalog/pg_inherits.c +++ b/src/backend/catalog/pg_inherits.c @@ -

Re: Auxiliary Processes and MyAuxProc

2019-02-25 Thread Mike Palmiotto
On Mon, Feb 25, 2019 at 1:29 PM Tom Lane wrote: > > Mike Palmiotto writes: > > > > For some context, I'm trying to come up with a patch to set the > > process identifier (MyAuxProc/am_autovacuumworker/launcher, > > am_archiver, etc.) immediately after fo

Auxiliary Processes and MyAuxProc

2019-02-25 Thread Mike Palmiotto
ffect. Is there any particular reason we couldn't fold all of the startup processes into the StartChildProcess code and assign MyAuxProc for processes that don't currently have one, or is this a non-starter? Thank you for your time. -- Mike Palmiotto Software Engineer Crunchy Data Solution

Re: Early WIP/PoC for inlining CTEs

2019-01-11 Thread Mike Rylander
w about, but the planner does not) via CTE is the only way to give the planner a fighting chance of finding a good plan. Otherwise you get stuck in the GEQO ghetto, or planning time is some non-trivial multiple of execution time. Thanks, -- Mike Rylander | Executive Director | Equinox Open Library Initiative | phone: 1-877-OPEN-ILS (673-6457) | email: mi...@equinoxinitiative.org | web: http://equinoxinitiative.org

Re: contrib/sepgsql fails on Fedora 28

2018-05-24 Thread Mike Palmiotto
make sure the regtest is passing, but this should solve the problem for now. Let me know if anything else catches fire. Thanks, -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com >From 778df9fa9421f420cfb53b7831338f9220713b09 Mon Sep 17 00:00:00 2001 From: Mike Pa

Re: [PATCH] Clear up perlcritic 'missing return' warning

2018-05-22 Thread Mike Blackwell
o abuse the API of a method intended to be "void", if the value returned falling off the end happens to seem useful, leading to breakage if the method's code changes in the future. > This is most likely going to be forgotten. > That's what perlcritic is for. :) Mike

[PATCH] Clear up perlcritic 'missing return' warning

2018-05-21 Thread Mike Blackwell
ng my environment set up. Mike Blackwell From d3ec3cbeb496ea9d2b285aaa32359cae528a983b Mon Sep 17 00:00:00 2001 From: Mike Blackwell Date: Tue, 15 May 2018 16:38:59 -0500 Subject: [PATCH] add returns to Perl files where missing diff --git a/contrib/bloom/t/001_wal.pl b/contrib/bloom/t/001_wal.pl

perlcritic: Missing "return"

2018-05-11 Thread Mike Blackwell
ld the project prefer the same? The other option would be disable the warning, based on a policy of always explicitly using 'return' when returning a value. Thoughts? Mike B * *

Re: perlcritic (was Re: pgsql: Fix precedence problem in new Perl code.)

2018-05-04 Thread Mike Blackwell
Alvaro, I didn't mean to imply otherwise. Our settings here are probably different. Good point on the git log --grep. I'll try to remember that in the future. Mike __ *Mike Blackwell | Technic

Re: Proper way to reload config files in backend SIGHUP handler

2018-05-04 Thread Mike Palmiotto
On 05/04/2018 09:35 AM, Michael Paquier wrote: > On Fri, May 04, 2018 at 12:47:09AM -0400, Mike Palmiotto wrote: >> I don't seem to have any problem catching the SIGHUP in my extension >> without > BackgroundWorkerUnblockSignals a la: >> >> pqsignal_sighup(SIGHUP

Re: Proper way to reload config files in backend SIGHUP handler

2018-05-03 Thread Mike Palmiotto
On 05/03/2018 08:43 PM, Euler Taveira wrote: > 2018-05-03 19:25 GMT-03:00 Mike Palmiotto : >> I am writing a PostgreSQL extension and need to reload certain >> extension-managed files whenever the postmaster is reloaded/receives SIGHUP, >> but cannot find anything that looks l

Proper way to reload config files in backend SIGHUP handler

2018-05-03 Thread Mike Palmiotto
, -- Mike Palmiotto Software Engineer Crunchy Data Solutions https://crunchydata.com