Re: [PATCH v2] Introduce spgist quadtree @<(point,circle) operator

2019-05-21 Thread Matwey V. Kornilov
вт, 21 мая 2019 г. в 08:43, Michael Paquier : > > On Mon, May 20, 2019 at 02:32:39PM +0300, Matwey V. Kornilov wrote: > > This patch series is to add support for spgist quadtree @<(point,circle) > > operator. The first two patches are to refactor existing code before >

[PATCH v2] Introduce spgist quadtree @<(point,circle) operator

2019-05-20 Thread Matwey V. Kornilov
ing style - add comment to spg_quad_inner_consistent_circle_helper() - rework spg_quad_inner_consistent_circle_helper() using HYPOT() to make the search consistent with filter scan Matwey V. Kornilov (3): Introduce helper variable in spgquadtreeproc.c Introd

Re: [PATCH 0/3] Introduce spgist quadtree @<(point,circle) operator

2019-03-05 Thread Matwey V. Kornilov
сб, 2 мар. 2019 г. в 12:14, Alexander Korotkov : > > Hi! Thanks for reply. Comments and questions are below. > > On Fri, Feb 1, 2019 at 7:08 PM Matwey V. Kornilov > wrote: > > This patch series is to add support for spgist quadtree @<(point,circle) > > operator

[PATCH 0/3] Introduce spgist quadtree @<(point,circle) operator

2019-02-01 Thread Matwey V. Kornilov
Hi, This patch series is to add support for spgist quadtree @<(point,circle) operator. The first two patches are to refactor existing code before implemention the new feature. The third commit is the actual implementation provided with a set of simple unit tests. Matwey V. Kornilov

[PATCH 2/3] Introduce spg_quad_inner_consistent_box_helper() in spgquadtreeproc.c

2019-02-01 Thread Matwey V. Kornilov
This helper function makes spg_quad_inner_consistent() more readable when changes from the next commit is introduced. Signed-off-by: Matwey V. Kornilov --- src/backend/access/spgist/spgquadtreeproc.c | 63 ++--- 1 file changed, 31 insertions(+), 32 deletions(-) diff

[PATCH 3/3] Add initial support for spgist quadtree @<(point,circle) operator

2019-02-01 Thread Matwey V. Kornilov
Signed-off-by: Matwey V. Kornilov --- src/backend/access/spgist/spgquadtreeproc.c | 65 --- src/include/catalog/pg_amop.dat | 3 + src/test/regress/expected/create_index.out | 96 + src/test/regress/sql/create_index.sql | 32

[PATCH 1/3] Introduce helper variable in spgquadtreeproc.c

2019-02-01 Thread Matwey V. Kornilov
Use shorter variable name instead of repeating in->scankeys[i] in spg_quad_leaf_consistent() and spg_quad_inner_consistent(). Signed-off-by: Matwey V. Kornilov --- src/backend/access/spgist/spgquadtreeproc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --gi