Re: [PATCH] Logical decoding of TRUNCATE

2018-01-25 Thread Marco Nenciarini
Il 25/01/18 13:18, Petr Jelinek ha scritto: > On 25/01/18 08:26, Thomas Munro wrote: >> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini >> wrote: >>> Version 16 attached. >> >> Hi Marco, >> >> FYI this version doesn't compile: >> >&g

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-23 Thread Marco Nenciarini
Il 23/01/18 18:25, Petr Jelinek ha scritto: > On 23/01/18 18:19, Marco Nenciarini wrote: >> Il 23/01/18 18:13, Petr Jelinek ha scritto: >>> Hi, >>> >>> On 23/01/18 15:38, Marco Nenciarini wrote: >>>> Il 22/01/18 23:18, Petr Jelinek ha scri

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-23 Thread Marco Nenciarini
Il 23/01/18 18:13, Petr Jelinek ha scritto: > Hi, > > On 23/01/18 15:38, Marco Nenciarini wrote: >> Il 22/01/18 23:18, Petr Jelinek ha scritto: >>> On 22/01/18 19:45, Petr Jelinek wrote: >>> >>> Actually on second look, I don't like the new boolean

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-23 Thread Marco Nenciarini
uncateGuts(). > > It may mean more list(s) but the current interface is still not clean. > Now ExecuteTruncateGuts unconditionally closes the relations that it opens. The caller has now always the responsibility to close the relations passed with the explicit_rels list. Version 15 attached

Re: [PATCH] session_replication_role = replica with TRUNCATE

2018-01-23 Thread Marco Nenciarini
Il 22/01/18 19:41, Petr Jelinek ha scritto: > On 19/01/18 12:41, Marco Nenciarini wrote: >> Hi Peter, >> >> Il 18/01/18 17:30, Peter Eisentraut ha scritto: >>> On 1/17/18 11:33, Petr Jelinek wrote: >>>>> P.S: I'm strugglin

pg_upgrade tests failing on current master

2018-01-23 Thread Marco Nenciarini
uot;rtest_emplog" ("ename", "who", "action", "newsal", "oldsal") VALUES ("old"."ename", CURRENT_USER, 'fired'::"bpchar", '$0.00'::"money", "old"."salary"); I&

Re: [PATCH] session_replication_role = replica with TRUNCATE

2018-01-19 Thread Marco Nenciarini
e between replicated and not replicated changes. > > I have committed some documentation updates and tests to cover this a > bit better. > Thanks, the documentation is a lot clearer now. This superseded the documentation change that was in the patch, so I've removed it from the v3 ve

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-19 Thread Marco Nenciarini
only close those and the rest should be >> closed by caller? That should also remove the other ugly part which is >> that the ExecuteTruncateGuts modifies the input list. What if caller >> wanted to use those relations it sent as parameter later? > > Agreed > Attache

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-15 Thread Marco Nenciarini
l.org/16/1447/, but I've posted it also here to ease the review of the 0002. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-06 Thread Marco Nenciarini
Attached here there is the complete list of patches required to pass all the tests. The 0001 patch is discussed in a separate thread, but I've posted it also here to ease the review of the 0002. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Su

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-06 Thread Marco Nenciarini
Patch rebased on the current master. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git a/contrib/test_decoding/expected/ddl.out b/contrib/test_decoding/expected/ddl.out index

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-05 Thread Marco Nenciarini
Hi, I've found some SGML errors in the version v10 of the patch. I've fixed it in version v11 that is attached. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git

Re: [PATCH] Logical decoding of TRUNCATE

2018-01-02 Thread Marco Nenciarini
Hi, Il 29/12/17 20:55, Andres Freund ha scritto: > Hi, > > On 2017-12-29 14:15:22 +0100, Marco Nenciarini wrote: >> This patch implements support for TRUNCATE statements >> in logical replication. The work has mainly done by Simon Riggs then >> finished by

Re: [PATCH] session_replication_role = replica with TRUNCATE

2018-01-02 Thread Marco Nenciarini
Hi, Il 30/12/17 08:42, Craig Ringer ha scritto: > On 30 December 2017 at 03:32, Petr Jelinek <mailto:petr.jeli...@2ndquadrant.com>> wrote: > > On 29/12/17 16:53, Marco Nenciarini wrote: > > Il 29/12/17 15:14, Petr Jelinek ha scritto: > >> >

Re: [PATCH] session_replication_role = replica with TRUNCATE

2017-12-29 Thread Marco Nenciarini
about foreign keys or referential integrity, but only about triggers and rules. I don't think that it's worth to add a special case for truncate, unless we want to expand/rewrite the documentation to specify all the effects in the details. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Ita

[PATCH] Logical decoding of TRUNCATE

2017-12-29 Thread Marco Nenciarini
when session_replication_role = replica"[1] patch is required from this patch to work correctly with tables referenced by foreign keys. [1] https://commitfest.postgresql.org/16/1447/ Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support mar

[PATCH] session_replication_role = replica with TRUNCATE

2017-12-29 Thread Marco Nenciarini
. I'm attaching a simple patch to make TRUNCATE match behavior of DELETE for session_replication_role = replica. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git a/src/backend/com

Re: pspg - psql pager

2017-11-17 Thread Marco Nenciarini
EW queue for manual review from Debian's FTP Master. https://ftp-master.debian.org/new/pspg_0.5-1.html Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it signature.asc Description: OpenPGP digital signature