Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-07-28 Thread Magnus Hagander
ent filesystems for them is a good reason to use tablespaces in the first place, and then being able to pick different options... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Potential issue in listExtensions()

2025-06-05 Thread Magnus Hagander
ension'::pg_catalog.regclass\n", > > ``` > > > > We may need to handle this by moving the AND condition to the left join > for pg_catalog.pg_description, so that we retrieve only pg_extension > entries from pg_description. > > Attaching the patch for the same.

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-30 Thread Magnus Hagander
On Sat, Mar 29, 2025 at 7:09 PM Andres Freund wrote: > Hi, > > On 2025-03-29 13:17:44 -0400, Andres Freund wrote: > > On 2025-03-28 13:47:16 -0400, Andres Freund wrote: > > > Attached is a fix for the issue. > > > > I plan to push this fix soon, unless somebody protests... > > And done. > Hi! S

Re: Adding extension default version to \dx

2025-03-24 Thread Magnus Hagander
On Sat, Mar 22, 2025 at 11:40 AM Jelte Fennema-Nio wrote: > On Tue, 25 Feb 2025 at 17:11, Nathan Bossart > wrote: > > > > On Tue, Feb 25, 2025 at 04:42:37PM +0100, Magnus Hagander wrote: > > > Thanks goes to both you and the previous responders - I did manage to &g

Re: doc: expand note about pg_upgrade's --jobs option

2025-03-07 Thread Magnus Hagander
On Wed, Mar 5, 2025 at 5:28 PM Nathan Bossart wrote: > On Wed, Mar 05, 2025 at 09:35:27AM -0600, Nathan Bossart wrote: > > On Wed, Mar 05, 2025 at 01:52:40PM +0100, Magnus Hagander wrote: > >> Another option that I think would also work is to just cut down the > details >

Re: doc: expand note about pg_upgrade's --jobs option

2025-03-05 Thread Magnus Hagander
Am I supposed to set it to max(cpucores, ntablespaces) or to max(cpucores+ntablespaces)? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Vacuum timing in pg_stat_all_tables

2025-03-04 Thread Magnus Hagander
something along the line of "(including cost based delaying)"? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Statistics Import and Export

2025-03-02 Thread Magnus Hagander
since surely we'd want pg_dump to dump objects by default. Any tool that parses the pg_dump output directly will always have to carefully analyze each new version. And probably shouldn't be using the plaintext format in the first place - and if using pg_restore it comes out as it's own type of object, making it easy to exclude at that level. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Adding extension default version to \dx

2025-02-25 Thread Magnus Hagander
econd patch. > > Fixed now. > > Thanks, Jelte. I can take care of committing this if Magnus can't get to > it soon. > Hi! Thanks goes to both you and the previous responders - I did manage to mute this thread away and missed the early replies, but got Jeltes the other

Re: new commitfest transition guidance

2025-02-19 Thread Magnus Hagander
ime for *this* round... One thing that should work is to send it from an account with the actual postgresql.org domain on it. If we have a bike-shedded text ready I can look at sending it out tomorrow. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Include patch id in commitfest page

2025-01-11 Thread Magnus Hagander
ad > of ID. > > Or just turn the sorting off. > > I'll revert this one pending further discussions, and then we can figure out what we want to put back. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Adding extension default version to \dx

2025-01-10 Thread Magnus Hagander
w the installed version in the schema, but no indications that a newer one might be installed on the system. PFA a patch to do this. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/> dif

Re: Statistics Import and Export

2024-11-27 Thread Magnus Hagander
On Wed, Nov 27, 2024, 17:44 Tom Lane wrote: > Alvaro Herrera writes: > > On 2024-Nov-27, Bruce Momjian wrote: > >> Would there be a default? > > > There would be no default. Running with no option given would raise an > > error. The point is: you want to break scripts currently running > > --a

Re: Statistics Import and Export

2024-11-27 Thread Magnus Hagander
ing the unexpected where you might not notice the problem until much later". That might trade some of that surprise and confusion for annoyance instead, but going forward that might be a clearer path? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Jargon and acronyms on this mailing list

2024-09-10 Thread Magnus Hagander
al. But also if we are going to end up making technical changes to handle it, then if we're ever going to make the change master -> main (or whatever), it would save work and pain to do the two at the same time. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: gitmaster server problem?

2024-08-19 Thread Magnus Hagander
On Mon, Aug 19, 2024 at 4:28 PM Dave Page wrote: > > > On Mon, 19 Aug 2024 at 14:56, Bruce Momjian wrote: > >> On Sat, Aug 17, 2024 at 02:15:49PM -0400, Tom Lane wrote: >> > Matthias van de Meent writes: >> > > Additional infra that doesn't seem to work right now: mailing list >> > > archives [

Re: gitmaster server problem?

2024-08-19 Thread Magnus Hagander
can rapidly turn valid attempts into DOSes if they parallellize too much... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Changing default -march landscape

2024-06-13 Thread Magnus Hagander
asonable to push this on packagers and just say "this is your problem now". If we do that, we can assume the only people to get any benefit from these optimizations are those that use a fully managed cloud service like azure or RDS. They can do it, but we need to tell them how and whe

Re: Non-text mode for pg_dumpall

2024-06-10 Thread Magnus Hagander
On Mon, Jun 10, 2024 at 6:21 PM Tom Lane wrote: > Magnus Hagander writes: > > On Mon, Jun 10, 2024 at 5:03 PM Nathan Bossart > > > wrote: > >> Is there a particular advantage to that approach as opposed to just > using > >> "directory" mode for

Re: Non-text mode for pg_dumpall

2024-06-10 Thread Magnus Hagander
On Mon, Jun 10, 2024 at 5:03 PM Nathan Bossart wrote: > On Mon, Jun 10, 2024 at 04:52:06PM +0200, Magnus Hagander wrote: > > On Mon, Jun 10, 2024 at 4:14 PM Nathan Bossart > > > wrote: > >> I'm curious why we couldn't also support the "custom" form

Re: Non-text mode for pg_dumpall

2024-06-10 Thread Magnus Hagander
stom" format. > Or maybe even a combo - a directory of custom format files? Plus that one special file being globals? I'd say that's what most use cases I've seen would prefer. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: libpq compression (part 3)

2024-05-20 Thread Magnus Hagander
ressing "header style" fields as http, so we are probably better off just not compressing those parts. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Magnus Hagander
tead of polluting the > commitfest app with them. I don't know if others are in this > situation. Anyway, I'm definitely currently guilty of parking. > One thing I think we've talked about before (but not done) is to basically have a CF called "parking

Re: Security lessons from liblzma - libsystemd

2024-04-12 Thread Magnus Hagander
On Thu, Apr 4, 2024 at 1:10 AM Peter Eisentraut wrote: > On 03.04.24 23:19, Magnus Hagander wrote: > > When the code is this simple, we should definitely consider carrying it > > ourselves. At least if we don't expect to need *other* functionality > > from the same libr

Re: Add notes to pg_combinebackup docs

2024-04-12 Thread Magnus Hagander
On Fri, Apr 12, 2024 at 3:01 PM Tomas Vondra wrote: > > > On 4/12/24 11:12, Magnus Hagander wrote: > > On Tue, Apr 9, 2024 at 11:46 AM Tomas Vondra < > tomas.von...@enterprisedb.com> > > wrote: > > > >> > >> > >> On 4/9/24 09:59,

Re: Add notes to pg_combinebackup docs

2024-04-12 Thread Magnus Hagander
ve a way to enable checksums online. > That'd not have this problem IIRC, because it writes proper WAL. Maybe > it's time to revive that idea ... I recall there were some concerns > about tracking progress to allow resuming stuff, but maybe not having > anything because in some (rar

Re: Add notes to pg_combinebackup docs

2024-04-12 Thread Magnus Hagander
etting a lot more common than they actually are, because they simplify a lot. But they're in my experience still very far from being a majority. But if the argument is that all this can/will be fixed in the future, I > guess the smart thing for users to do is wait a few releases for > incremental backups to become a practical feature. > There's always going to be another set of goalposts further ahead. I think it can still be practical for quite a few people. I'm more worried about the issue you raised in the other thread about missing files, for example... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Security lessons from liblzma - libsystemd

2024-04-03 Thread Magnus Hagander
On Wed, Apr 3, 2024 at 7:57 PM Andres Freund wrote: > Hi, > > As most will know by now, the way xz debacle was able to make sshd > vulnerable > was through a dependency from sshd to libsystemd and then from libsystemd > to > liblzma. One lesson from this is that unnecessary dependencies can still

Re: Reports on obsolete Postgres versions

2024-04-02 Thread Magnus Hagander
> I do like the term "current" better. It conveys (at least a bit) that we really consider all the older ones to be, well, obsolete. The difference "current vs obsolete" is stronger than "latest vs not quite latest". -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Reports on obsolete Postgres versions

2024-04-02 Thread Magnus Hagander
t, one of the reasons to go to two-part version numbers instead of 3. Because people did not realize that the full 9.6 digit was the major version, and thus what was maintained and such. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Statistics Import and Export

2024-03-30 Thread Magnus Hagander
f this. The information needs to go somewhere where such tools can easily consume it, and an informational message during runtime (which is also likely to be translated in many environments) is the exact opposite of that. Surely we can come up with something better. Otherwise, I think all those

Re: Possibility to disable `ALTER SYSTEM`

2024-03-25 Thread Magnus Hagander
hose two things to it the superuser could just rename or > remove it and then write postgresql.auto.conf of his choosing. > Just to add to that -- if you use chattr +i on it, the superuser in postgres won't be able to rename it -- only the actual root user. Just chowning it won&#

Re: Possibility to disable `ALTER SYSTEM`

2024-03-20 Thread Magnus Hagander
On Wed, Mar 20, 2024 at 8:52 PM Robert Haas wrote: > On Wed, Mar 20, 2024 at 3:17 PM Magnus Hagander > wrote: > > Right, what I meant is that making it a packaging decision is the better > place. Wherever it goes, allowing the administrator to choose what fits > them shoul

Re: Possibility to disable `ALTER SYSTEM`

2024-03-20 Thread Magnus Hagander
On Wed, Mar 20, 2024 at 8:14 PM Robert Haas wrote: > On Wed, Mar 20, 2024 at 3:11 PM Magnus Hagander > wrote: > > I would argue that having the default permissions not allow postgres to > edit it's own config files *except* for postgresql.auto.conf would be a > better de

Re: Possibility to disable `ALTER SYSTEM`

2024-03-20 Thread Magnus Hagander
cussed on this thread. (And FWIW also already solved on debian-based platforms for example, which but the main config files in /etc with postgres only having read permissions on them - and having the *packagers* adapt such things for their platforms in general seems like a better place). -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Possibility to disable `ALTER SYSTEM`

2024-03-19 Thread Magnus Hagander
On Tue, Mar 19, 2024 at 3:52 PM Tom Lane wrote: > > Heikki Linnakangas writes: > > Perhaps we could make that even better with a GUC though. I propose a > > GUC called 'configuration_managed_externally = true / false". If you set > > it to true, we prevent ALTER SYSTEM and make the error message

Re: Possibility to disable `ALTER SYSTEM`

2024-03-18 Thread Magnus Hagander
On Mon, Mar 18, 2024 at 4:44 PM Daniel Gustafsson wrote: > > > On 18 Mar 2024, at 16:34, Magnus Hagander wrote: > > > > On Mon, Mar 18, 2024 at 2:09 PM Daniel Gustafsson wrote: > >> > >>> On 18 Mar 2024, at 13:57, Robert Haas wrote: > >>

Re: Possibility to disable `ALTER SYSTEM`

2024-03-18 Thread Magnus Hagander
so ought to > > talk about anything else. But I feel like we're way overdue to do > > something about this. > > Seconded, both that it needs to be addressed and that it should be done on a > separate thread from this one. +1. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: pg_dump include/exclude fails to error

2024-03-10 Thread Magnus Hagander
On Sun, Mar 10, 2024 at 4:51 PM Pavel Stehule wrote: > > Hi > > ne 10. 3. 2024 v 15:23 odesílatel Magnus Hagander > napsal: >> >> When including tables with the new pg_dump functionality, it fails to >> error out if a table is missing, but only if more than one

pg_dump include/exclude fails to error

2024-03-10 Thread Magnus Hagander
When including tables with the new pg_dump functionality, it fails to error out if a table is missing, but only if more than one table is specified. E.g., if table foo exist, but not bar: pg_dump --table bar pg_dump: error: no matching tables were found with file "myfilter" containing just "tabl

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-03-09 Thread Magnus Hagander
On Fri, Dec 22, 2023 at 11:04 PM Alexander Korotkov wrote: > > Hi, Anton! > > On Mon, Dec 4, 2023 at 3:50 AM Anton A. Melnikov > wrote: >> >> Thanks for remarks! >> >> On 28.11.2023 21:34, Alexander Korotkov wrote: >> > After examining the second patch >> > ("v2-0001-Add-restartpoint-stats.patch

Replication conflicts not processed in ClientWrite

2024-03-04 Thread Magnus Hagander
tRead, for example, it's picked up immediately, but there's something in ClientWrite that prevents it. My first thought would be OpenSSL, but this is reproducible both on tls-over-tcp and on unix sockets. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: System username in pg_stat_activity

2024-02-20 Thread Magnus Hagander
On Fri, Feb 16, 2024 at 9:45 PM Andres Freund wrote: > > Hi, > > On 2024-02-16 15:22:16 -0500, Tom Lane wrote: > > Magnus Hagander writes: > > > I mean, we could split it into more than one view. But adding a new > > > view for every new thing we wan

Re: System username in pg_stat_activity

2024-02-20 Thread Magnus Hagander
On Fri, Feb 16, 2024 at 9:31 PM Magnus Hagander wrote: > > On Fri, Feb 16, 2024 at 9:20 PM Andres Freund wrote: > > > > Hi, > > > > On 2024-02-16 20:57:59 +0100, Magnus Hagander wrote: > > > On Fri, Feb 16, 2024 at 8:41 PM Andres Freund wrote: >

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Feb 16, 2024 at 9:51 PM Andres Freund wrote: > > Hi, > > On 2024-02-16 21:41:41 +0100, Magnus Hagander wrote: > > > Maybe I am missing something, but why aren't we just getting the value > > > from > > > the leader's entry, instead o

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Feb 16, 2024 at 8:55 PM Andres Freund wrote: > > Hi, > > On 2024-01-12 17:16:53 +0100, Magnus Hagander wrote: > > On Thu, Jan 11, 2024 at 5:55 PM Bertrand Drouvot > > wrote: > > > On Thu, Jan 11, 2024 at 02:24:58PM +0100, Magnus Hagander wrote: > &

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Feb 16, 2024 at 9:20 PM Andres Freund wrote: > > Hi, > > On 2024-02-16 20:57:59 +0100, Magnus Hagander wrote: > > On Fri, Feb 16, 2024 at 8:41 PM Andres Freund wrote: > > > On 2024-01-10 12:46:34 +0100, Magnus Hagander wrote: > > > > The att

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Feb 16, 2024 at 8:41 PM Andres Freund wrote: > > Hi, > > On 2024-01-10 12:46:34 +0100, Magnus Hagander wrote: > > The attached patch adds a column "authuser" to pg_stat_activity which > > contains the username of the externally authenticated use

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Jan 19, 2024 at 1:43 PM Julien Rouhaud wrote: > > Hi, > > On Thu, Jan 18, 2024 at 11:01 PM Magnus Hagander wrote: > > > > I did. Here it is, and also including that suggested docs fix as well > > as a rebase on current master. > > +

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Jan 19, 2024 at 12:33 PM Aleksander Alekseev wrote: > > Hi, > > > > Did you forget to share the new revision (aka v4)? I can only see the > > > "reorder_parallel_worker_bestart.patch" attached. > > > > I did. Here it is, and also including that suggested docs fix as well > > as a rebase on

Re: System username in pg_stat_activity

2024-02-16 Thread Magnus Hagander
On Fri, Jan 19, 2024 at 7:20 AM Bertrand Drouvot wrote: > > Hi, > > On Thu, Jan 18, 2024 at 04:01:33PM +0100, Magnus Hagander wrote: > > On Mon, Jan 15, 2024 at 11:17 AM Bertrand Drouvot > > > Did you forget to share the new revision (

Re: Possibility to disable `ALTER SYSTEM`

2024-01-30 Thread Magnus Hagander
tgres security mechanism. Wouldn't a simple "chattr +i postgresql.auto.conf" work? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: System username in pg_stat_activity

2024-01-18 Thread Magnus Hagander
On Mon, Jan 15, 2024 at 11:17 AM Bertrand Drouvot wrote: > > Hi, > > On Fri, Jan 12, 2024 at 05:16:53PM +0100, Magnus Hagander wrote: > > On Thu, Jan 11, 2024 at 5:55 PM Bertrand Drouvot > > wrote: > > > > > > I'm wondering if it would make sense

Re: System username in pg_stat_activity

2024-01-12 Thread Magnus Hagander
On Thu, Jan 11, 2024 at 5:55 PM Bertrand Drouvot wrote: > > Hi, > > On Thu, Jan 11, 2024 at 02:24:58PM +0100, Magnus Hagander wrote: > > On Wed, Jan 10, 2024 at 3:12 PM Bertrand Drouvot > > wrote: > > > > > > If we go the 2 fields way, then what about

Re: Compile warnings in dbcommands.c building with meson

2024-01-11 Thread Magnus Hagander
nce change, if there is any. Certainly looks that way, but I'm curious as to why nobody else has seen this.. That said, it appears to be gone in current master. Even though nothing changed in that file. Must've been some transient effect, that somehow didn't get blown away by doing a clean -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Slightly improved meson error for docs tools

2024-01-11 Thread Magnus Hagander
ch is OK. Thanks. I've pushed this one for now, we can always adjust further later if needed. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Postgres Partitions Limitations (5.11.2.3)

2024-01-11 Thread Magnus Hagander
On Thu, Jan 11, 2024 at 11:24 AM Ashutosh Bapat wrote: > > On Wed, Jan 10, 2024 at 10:38 PM Laurenz Albe > wrote: > > > > On Wed, 2024-01-10 at 13:41 +0100, Magnus Hagander wrote: > > > It still reads a bit weird to me. How about the attached wording instead? &

Re: System username in pg_stat_activity

2024-01-11 Thread Magnus Hagander
On Wed, Jan 10, 2024 at 3:12 PM Bertrand Drouvot wrote: > > Hi, > > On Wed, Jan 10, 2024 at 02:59:42PM +0100, Magnus Hagander wrote: > > On Wed, Jan 10, 2024 at 2:56 PM Bertrand Drouvot > > I definitely think it should be the same. If it's not exactly the > > sa

Re: System username in pg_stat_activity

2024-01-10 Thread Magnus Hagander
On Wed, Jan 10, 2024 at 2:56 PM Bertrand Drouvot wrote: > > Hi, > > On Wed, Jan 10, 2024 at 02:08:03PM +0100, Magnus Hagander wrote: > > On Wed, Jan 10, 2024 at 1:44 PM Aleksander Alekseev > > wrote: > > > > > > Hi, > > > > > > T

Re: System username in pg_stat_activity

2024-01-10 Thread Magnus Hagander
On Wed, Jan 10, 2024 at 2:27 PM Dagfinn Ilmari Mannsåker wrote: > > Magnus Hagander writes: > > > On Wed, Jan 10, 2024 at 1:44 PM Aleksander Alekseev > > wrote: > >> > >> It hurts my sense of beauty that usename and authname are of different > >&

Re: System username in pg_stat_activity

2024-01-10 Thread Magnus Hagander
st_authuser[NAMEDATALEN]; > ``` > > Well, here it's called "authuser" and it looks like the intention was > to use `name` datatype... I suggest using "authname" everywhere for > consistency. Yeah, I flipped back and forth a few times and cle

Re: Postgres Partitions Limitations (5.11.2.3)

2024-01-10 Thread Magnus Hagander
; > > are no partitions. ...". > > > > I agree that the parenthesis is too long. I shortened it in the attached > > patch. Is that acceptable? > > It's still longer than the actual sentence :). I am fine with it if > somebody else finds it acceptable. It still

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

2024-01-10 Thread Magnus Hagander
better off actually using the original version, so I'm going to go ahead and push that one (and also to avoid endless bikeshedding)- -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

System username in pg_stat_activity

2024-01-10 Thread Magnus Hagander
s a column name in pg_stat_activity I figured that could be confusing since it actually means something completely different. But happy to change that back if people think that's better. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/ diff --git

Slightly improved meson error for docs tools

2024-01-10 Thread Magnus Hagander
go, or if we should somehow list the individual tools that are failing here? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/ diff --git a/meson.build b/meson.build index 57f9735feb..c317144b6b 100644 --- a/meson.build +++ b/meson.build @@ -587,7 +587,7 @@ if n

Compile warnings in dbcommands.c building with meson

2024-01-10 Thread Magnus Hagander
=disabled in both cases the compiler is: gcc (Debian 10.2.1-6) 10.2.1 20210110 -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Commitfest manager January 2024

2024-01-02 Thread Magnus Hagander
On Tue, Jan 2, 2024 at 3:45 AM vignesh C wrote: > > On Mon, 1 Jan 2024 at 21:01, Magnus Hagander wrote: > > > > On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote: > > > > > > On Sun, 24 Dec 2023 at 18:40, vignesh C wrote: > > > > >

Re: Commitfest manager January 2024

2024-01-01 Thread Magnus Hagander
On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote: > > On Sun, 24 Dec 2023 at 18:40, vignesh C wrote: > > > > On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote: > > > > > > On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote: > > > > I didn't see anyone volunteering for the January Commitfe

Re: Password leakage avoidance

2023-12-31 Thread Magnus Hagander
inology. E.g. it would be up to the "Postgres support driver" in django/rails/whatnot to reduce it down to one step, not to a low level driver like libpq (or other low level drivers). None of those frameworks are likely to want to require direct driver access anyway, they *want* to take control of that process in my experience. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: proposal: change behavior on collation version mismatch

2023-11-27 Thread Magnus Hagander
On Mon, Nov 27, 2023 at 9:30 PM Jeff Davis wrote: > > On Mon, 2023-11-27 at 11:06 -0800, Jeremy Schneider wrote: > > If we want to have a GUC that > > allows warning behavior, I think that's OK but I think it should be > > superuser-only and documented as a "developer" setting similar to > > zero_

Re: [HACKERS] pg_upgrade vs vacuum_cost_delay

2023-11-24 Thread Magnus Hagander
On Fri, Nov 24, 2023 at 5:34 PM Bruce Momjian wrote: > > On Fri, Nov 24, 2023 at 01:10:01PM +0100, Michael Banck wrote: > > Hi, > > > > On Fri, Nov 24, 2023 at 12:17:56PM +0100, Magnus Hagander wrote: > > > On Fri, Nov 24, 2023 at 11:21 AM Michael Banck wrote: &

Re: [HACKERS] pg_upgrade vs vacuum_cost_delay

2023-11-24 Thread Magnus Hagander
d have an option to explicitly > force vacuum_cost_delay to 0 (I don't think it has?)? That's exactly what I proposed, isn't it? :) -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: [HACKERS] pg_upgrade vs vacuum_cost_delay

2023-11-23 Thread Magnus Hagander
On Thu, Nov 23, 2023 at 5:23 AM Bruce Momjian wrote: > > On Thu, Jun 16, 2016 at 04:45:14PM +0200, Magnus Hagander wrote: > > On Thu, Jun 16, 2016 at 4:35 PM, Euler Taveira wrote: > > > > On 16-06-2016 09:05, Magnus Hagander wrote: > > > Shouldn't

Re: run pgindent on a regular basis / scripted manner

2023-10-18 Thread Magnus Hagander
On Tue, Oct 17, 2023 at 11:07 PM Tom Lane wrote: > > Magnus Hagander writes: > > If it doesn't know how to rebuild it, aren't we going to be stuck in a > > catch-22 if we need to change it in certain ways? Since an old version > > of pg_bsd_indent would r

Re: run pgindent on a regular basis / scripted manner

2023-10-17 Thread Magnus Hagander
that's not too hard of a problem to solve, *if* this is what we want. (And of course needs to be integrated with the existing script since AFAIK you can't chain git hooks unless you do it manually - but that's mostliy mechanical) -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Possibility to disable `ALTER SYSTEM`

2023-09-11 Thread Magnus Hagander
er* parameters, if they want to. That's just a very quick idea and there may definitely be holes in it, but I'm not sure those holes are any worse than what's suggested here, and I do thin kit's cleaner. > I find the opposition to this lacking good reasons, while I find the > imple

Re: Possibility to disable `ALTER SYSTEM`

2023-09-11 Thread Magnus Hagander
On Sat, Sep 9, 2023 at 5:14 PM Alvaro Herrera wrote: > > On 2023-Sep-08, Magnus Hagander wrote: > > > Now, it might be that you don't care at all about the *security* side > > of the feature, and only care about the convenience side. But in that > > case, the origi

Re: Possibility to disable `ALTER SYSTEM`

2023-09-08 Thread Magnus Hagander
d a computer is capable of doing, except for this one specific thing". Blocklisting individual permissions of a superuser will never be secure. Now, it might be that you don't care at all about the *security* side of the feature, and only care about the convenience side. But in that case,

Release notes wording about logical replication as table owner

2023-09-06 Thread Magnus Hagander
We have: "This improves security and now requires subscription owners to be either superusers or to have SET ROLE permissions on all tables in the replication set. The previous behavior of performing all operations as the subscription owner can be enabled with the subscription run_as_owner option.

Re: Commitfest manager for September

2023-08-30 Thread Magnus Hagander
web interface. Could someone make that > happen? Done! -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: list of acknowledgments for PG16

2023-08-25 Thread Magnus Hagander
f the docs -- even other changes to the REL16 docs should be excluded until the next release is (this time, RC1). Bottom line is, definite -1 for doing a one-off change that violates the principle we're on. Now, if we want a *separate* location where we continuously load branch tip docs that's a different thing and certainly something we could consider. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Should we remove db_user_namespace?

2023-07-16 Thread Magnus Hagander
g > about. I'd lean towards "no". A hard break, when it's a major release, is better than a "it stopped having effect but didn't tell you anything" break. Especially when it comes to things like startup scripts etc. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Should we remove db_user_namespace?

2023-06-30 Thread Magnus Hagander
ong +1 from here for removing it, assuming you don't find a bunch of users on -general who are using it. Having never come across one myself, I think it's unlikely, but I agree it's good to ask. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Add wait event for log emission?

2023-06-13 Thread Magnus Hagander
pg_stat_activity. But other processes > reporting the wait event for writing to the logger process would be a pretty > good hint. +1. Would it make sense to at the same time create a separate one for syslog, or just use the same? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: win32ver data in meson-built postgres.exe

2023-06-08 Thread Magnus Hagander
eels better than showing the generic-exe icon. I think this decision goes back all the way to the ancient times, and the argument was then "user should not use the postgres.exe file when clicking around" sort of. Back then, task manager didn't show the icon at all, regardless. It does now, so I'm +1 to add the icon (in all the build systems). -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Upgrade of git.postgresql.org

2023-05-15 Thread Magnus Hagander
On Mon, May 15, 2023 at 9:37 PM Magnus Hagander wrote: > > The pginfra team is about to begin an upgrade of git.postgresql.org to > a new version of debian. During the operation there may be some > intermittent outages -- we will let you know once the upgrade is > complete. This

Upgrade of git.postgresql.org

2023-05-15 Thread Magnus Hagander
The pginfra team is about to begin an upgrade of git.postgresql.org to a new version of debian. During the operation there may be some intermittent outages -- we will let you know once the upgrade is complete. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill

Re: run pgindent on a regular basis / scripted manner

2023-04-23 Thread Magnus Hagander
On Sat, Apr 22, 2023 at 9:59 PM Noah Misch wrote: > > (Given that another commentator is "absolutely against" a hook, this message > is mostly for readers considering this for other projects.) > > On Sat, Apr 22, 2023 at 03:23:59PM +0200, Magnus Hagander wrote: > >

Re: run pgindent on a regular basis / scripted manner

2023-04-23 Thread Magnus Hagander
On Sat, Apr 22, 2023 at 4:12 PM Andrew Dunstan wrote: > > > On 2023-04-22 Sa 08:47, Magnus Hagander wrote: > > On Sat, Apr 22, 2023 at 1:42 PM Andrew Dunstan wrote: > > On 2023-04-22 Sa 04:50, Michael Paquier wrote: > > On Fri, Apr 21, 2023 at 09:58:17AM +0200, Jelte F

Re: run pgindent on a regular basis / scripted manner

2023-04-22 Thread Magnus Hagander
environment and spawn in there, and just that takes time. And it would have to also know to rebuild pg_bsd_indent on demand, which would require a full ./configure run (or meson equivalent). etc. So while it might not be tens of seconds, it most definitely won't be fast. -- Magnus Hagander

Re: run pgindent on a regular basis / scripted manner

2023-04-22 Thread Magnus Hagander
On Sat, Apr 22, 2023 at 1:42 PM Andrew Dunstan wrote: > > > On 2023-04-22 Sa 04:50, Michael Paquier wrote: > > On Fri, Apr 21, 2023 at 09:58:17AM +0200, Jelte Fennema wrote: > > For 2 the upstream thread listed two approaches: > a. Install a pre-receive git hook on the git server that rejects > pu

Re: User functions for building SCRAM secrets

2023-04-11 Thread Magnus Hagander
olicy or anything else that requires the server to see the cleartext or cleartext-equivalent of the password can then revoke this role from public, and force password changes to go through a security definer funciton, like SELECT pg_change_password_with_policy('joe', 'mysupers

Re: When to drop src/tools/msvc support

2023-04-11 Thread Magnus Hagander
ll automation stuff, but appears to have the parts about building the postgres dependency. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: When to drop src/tools/msvc support

2023-04-10 Thread Magnus Hagander
and dropping it immediately as v17 opens, giving them a year of advantage. And probably updating the docs (if anybody were to read them.. but at least then we tried) stating that it's deprecated and will be removed in v17. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Re: Should we remove vacuum_defer_cleanup_age?

2023-03-17 Thread Magnus Hagander
don't think I have the cycles to push this through in the next weeks, > but if > we agree removing vacuum_defer_cleanup_age is a good idea, it seems like a > good idea to mark it as deprecated in 16? > +1. I haven't seen any (correct) use of this in many many yea

Re: use __builtin_clz to compute most significant bit set

2023-02-25 Thread Magnus Hagander
ng zeros for > the mask and then we can find the index by 32 - __builtin_clz(mask). > Hi! This file has already been removed, as of 4f1f5a7f85. Which already uses __builtin_clz if it' available. Were you perhaps looking at an old version instead of the master branch? --

Re: run pgindent on a regular basis / scripted manner

2023-02-07 Thread Magnus Hagander
a async ci job that runs after each commit and sends an emali to the committer if the commit doesn't match up, instead of rejecting it hard but still getting some relatively fast feedback. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Remove source code display from \df+?

2023-01-12 Thread Magnus Hagander
On Thu, Jan 12, 2023 at 6:23 AM Pavel Stehule wrote: > > > st 11. 1. 2023 v 22:11 odesílatel Tom Lane napsal: > >> Pavel Stehule writes: >> > st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander >> > napsal: >> >> This is only about Internal and

Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert

2023-01-11 Thread Magnus Hagander
On Wed, Jan 11, 2023 at 8:06 PM Jacob Champion wrote: > On Wed, Jan 11, 2023 at 10:23 AM Magnus Hagander > wrote: > > Sorry to jump in (very) late in this game. So first, I like this general > approach :) > > Thanks! > > > It feels icky to have to add configure

Re: Remove source code display from \df+?

2023-01-11 Thread Magnus Hagander
IN > … > END; > $$; > > Even if somebody uses a different style, the first line is probably just > "BEGIN" or something equally formulaic. > This is only about Internal and C, isn't it? Isn't the oid of these static, and identified by INTERN

  1   2   3   4   5   6   7   8   9   10   >