Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-06-05 Thread Long Song
-06-04 14:44:09, "Kyotaro Horiguchi" wrote: >At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" >wrote in >> >> Hi, >> Actually, I still wonder why only the error message >> of the last failure to close the file was recorded. >> For t

Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-06-04 Thread Long Song
Hi Kyotaro, Thank you for the response. At 2024-06-04 14:44:09, "Kyotaro Horiguchi" wrote: >At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" >wrote in >> >> Hi, >> Actually, I still wonder why only the error message >> of the last f

Re:Avoid an odd undefined behavior with memcmp (src/bin/pg_rewind/pg_rewind.c)

2024-05-29 Thread Long Song
Hi Ranier, > IMO, I think that pg_rewind can have a security issue, > if two files are exactly the same, they are considered different. > Because use of structs with padding values is unspecified. Logically you are right. But I don't understand what scenario would require memcmp to compare Cont

Re:[PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-05-28 Thread Long Song
Hi, Actually, I still wonder why only the error message of the last failure to close the file was recorded. For this unusual situation, it is acceptable to record all failure information without causing too much logging. Was it designed that way on purpose? At 2024-05-25 17:29:00, "Long

[PATCH]A minor improvement to the error-report in SimpleLruWriteAll()

2024-05-25 Thread Long Song
Hi hackers, When I read the code, I noticed that in SimpleLruWriteAll(), only the last error is recorded when the file fails to close. Like the following, ```void SimpleLruWriteAll(SlruCtl ctl, bool allow_redirtied) { SlruShared shared = ctl->shared; SlruWriteAllData fdata;

Re:about cross-compiling issue

2024-05-23 Thread Long Song
Hi Chen Yajie, Your provided information is fuzzy, so I can only give some simple suggestions: 1. Use `file dict_snowball.so` to see the detail info of dict_snowball.so, maybe you can get some useful hint. 2. Use gdb to debug the initdb processing, then you can get more detail error info. That