Dear Adrien,
I understood the cost of randomizing is very low. Maybe it's OK..
I'll change the status to "Ready For Committer."
Finally, I apologize for having delayed review.
Thank you for your good opportunities.
Best Regards,
Hayato Kuroda
Fujitsu LIMITED
Dear David,
I have a will and already read the patch, but I thought it's not my turn.
Sorry.
Adrien,
> I did not find any test for log_min_duration that could help me. LCOV
> indicate
> there is no tests on this part (look check_log_duration()):
> https://coverage.postgresql.org/src/backend/t
Dear Matsumura-san, Horiguchi-san,
We should check the specfication of Pro*c before coding
because this follows its feature.
I'll test some cases and send you a simple report.
Best Regards,
Hayato Kuroda
Fujitsu LIMITED
Dear Matsumura-san,
> I think that the 2nd argument of following ecpg_init() must be
> real_connection_name.
> Is it right?
Yes, I think it should be real_connection_name for raising correct error
message.
This is also an leak of my code and I attached a patch.
Best Regards,
Hayato Kuroda
Fu
Dear Rushabh, Michael,
I attached a simple bug-fixing patch.
Could you review it?
An added logic is:
1. Send a close statement to a backend process regardless of the existence
of a cursor.
2. If ecpg_do function returns false, raise “cursor is invalid” error.
3. Remove cursor from
Dear Rushabh, Michael,
Thank you for reporting.
I understood bugs had be embed in ecpg by me.
I start checking codes and investigating solutions and other errors.
Best Regards,
Hayato Kuroda
Fujitsu LIMITED
Dear Michael, Chris and Tom,
> Adding special cases to extensions strikes me as adding more
> funny corners to the behavior of the db in this regard.
I understand your arguments and its utility.
> For most of extensions, this can randomly finish with strange error
> messages, say that:
> =# crea
Dear Michael,
I seem this patch is enough, but could you explain the reason
you drop initial proposal more detail?
I'm not sure why extensions contained by temporary schemas are acceptable.
> Anything depending on a temporary object will be dropped per
> dependency links once the session is over
Dear Adrien,
>> * xact_is_sampled is left at the end of a transaction.
>> Should the parameter be set to false at the lowest layer of the transaction
>> system?
>> I understand it is unnecessary for the functionality, but it have more
>> symmetry.
>
> Yes, it is not necessary. I wonder what is m
Dear Adrien,
> Hum, I am not an english native speaker, I choosed "rate" because it is
> already used for auto_explain.sample_rate and for log_statement_sample_rate
If the community agree those name, renaming parameters are not needed.
Consistency is the most important in a DBMS. :-)
I read you
Dear Adrien,
> Your messages looks normal to me, you will have same messages if you put
> log_min_duration to 0.
That was my lack of understanding. Sorry.
By the way, I think the name of this parameter should be changed.
In the Cambridge dictionary, the word "rate" means as follows:
the speed
Dear Adrien,
I applied your file and faced a bug-candidate.
(I have not read your source yet. Sorry.)
When I tried to use tab-complition, some dirty messages were appeared.
Messages I faced are attached in this mail.
Best Regards,
Hayato Kuroda
Fujitsu LIMITED
postgres=# SET client_min_message
12 matches
Mail list logo
