Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Hi, Patch applies and compiles, all included tests passed and after the latest fixes for non-nulls array, performance is near to lead/lag without support of "ignore nulls". I have been using the last version for more than one month in a production environment with real data and didn't find any bugs

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Hi, I was able to reproduce exactly the problem, with clean compile and --enable-cassert: test=# SELECT x,y,lead(y) IGNORE NULLS OVER (ORDER BY x) FROM (VALUES(1,NULL),(2,2),(3,NULL)) AS v(x,y); x | y | lead ---+---+-- 1 | |2 2 | 2 |2 3 | |2 (3 rows) test=# Also, make check

Re: Implement for window functions

ready for the committer in the commitfest app. На сб, 9.01.2021 г. в 13:30 ч. Krasiyan Andreev написа: > Hi, the building warning below is fixed now, no other changes. Also, I can > confirm that the corner case with offset=0 in lead and lag works correctly. > > gcc -Wall -Wmissing-prot

Re: Implement for window functions

Hi, the building warning below is fixed now, no other changes. Also, I can confirm that the corner case with offset=0 in lead and lag works correctly. gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallt

Re: Implement for window functions

Hi, it looks like cfbot.cputube.org didn't recognize and can't apply a patch, so I resend it now with a different format, no other changes. На ср, 30.12.2020 г. в 22:16 ч. Krasiyan Andreev написа: > It works - now it compiles clean and all checks are passed, thank you. I > wi

Re: Implement for window functions

It works - now it compiles clean and all checks are passed, thank you. I will continue with more complex tests. На ср, 30.12.2020 г. в 21:50 ч. David Fetter написа: > On Wed, Dec 30, 2020 at 09:32:26PM +0200, Krasiyan Andreev wrote: > > Hi, after latest committed patches about m

Re: Implement for window functions

ke[1]: *** [Makefile:42: all-backend-recurse] Error 2 make[1]: Leaving directory '/home/krasiyan/pgsql/build/src' make: *** [GNUmakefile:11: all-src-recurse] Error 2 [krasiyan@localhost build]$ На вт, 8.12.2020 г. в 16:27 ч. Vik Fearing написа: > On 11/21/20 10:07 AM, Krasiyan Andree

Re: Implement for window functions

Fixed patch attached, after new introduced conflicts. Vik, can you add it to the next commitfest, to be able to test it. Also, all tests from Oliver Ford's old patch also passed successfully. На пт, 13.11.2020 г. в 0:44 ч. Vik Fearing написа: > On 11/12/20 11:35 PM, Krasiyan Andre

Re: Implement for window functions

Hi, it looks like Vik Fearing's patch does not apply anymore, because there are many conflicts with recent changes, fixed patch attached. I am interested in reviewing and testing it for the next commitfest, if it's design and implementation is found to be acceptable. Additionally, if it is also acc

Re: [PATCH] distinct aggregates within a window function WIP

, it can be easy ported to Vik's patch. I am thinking also to concentrate on Vik's patch, if it has a clear design point of view, clear design, I can withdraw mine patch. На ср, 16.09.2020 г. в 11:19 Surafel Temesgen написа: > > On Thu, Mar 5, 2020 at 4:17 AM Krasiyan Andreev >

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Thank you very much for feedback and yes, that is very useful SQL syntax. Maybe you miss my previous answer, but you are right, that patch is currently dead, because some important design questions must be discussed here, before patch rewriting. I have dropped support of from first/last for nth_va

Re: [PATCH] distinct aggregates within a window function WIP

served keywords, I will reimplement it, if needed. На пн, 13.01.2020 г. в 18:19 Vik Fearing написа: > On 13/01/2020 15:19, Tom Lane wrote: > > Krasiyan Andreev writes: > >> I want to propose to you an old patch for Postgres 11, off-site > developed > >> by Oliv

[PATCH] respect/ignore nulls for lag,lead,first_value,last_value and nth_value and from first/last for nth_value

Hi hackers, I want to continue development of Oliver Ford's respect/ignore nulls for lag,lead,first_value,last_value and nth_value and from first/last for nth_value patch, but I am not sure how to proceed with it and any feedback will be very useful. I have dropped support of from first/last for

Re: [PATCH] distinct aggregates within a window function WIP

xclude ties" nor "exclude groups" or "exclude current row", can specify it, because they can't be nested or used at the same time. На пн, 13.01.2020 г. в 16:19 Tom Lane написа: > Krasiyan Andreev writes: > > I want to propose to you an old patch for Postg

[PATCH] distinct aggregates within a window function WIP

Hi hackers, I want to propose to you an old patch for Postgres 11, off-site developed by Oliver Ford, but I have permission from him to publish it and to continue it's development, that allow distinct aggregates, like select sum(distinct nums) within a window function. I have rebased it for curre

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Hi, Patch applies and compiles, all included tests and building of the docs pass. I am using last version from more than two months ago in production environment with real data and I didn't find any bugs, so I'm marking this patch as ready for committer in the commitfest app. На сб, 28.07.2018 г.