Re: Fast COPY FROM based on batch insert

On 09/07/2022 00:09, Andrey Lepikhov wrote: On 8/7/2022 05:12, Ian Barwick wrote: ERROR:  bind message supplies 0 parameters, but prepared statement "pgsql_fdw_prep_178" requires 6 CONTEXT:  remote SQL command: INSERT INTO public.foo_part_1(t, v1, v2, v3, v4, v5) VALUES (

Re: Fast COPY FROM based on batch insert

On 07/07/2022 22:51, Andrey Lepikhov wrote: > On 7/7/2022 06:14, Ian Barwick wrote: >> 2022年3月24日(木) 15:44 Andrey V. Lepikhov : >> > >> > On 3/22/22 06:54, Etsuro Fujita wrote: >> > > On Fri, Jun 4, 2021 at 5:26 PM Andrey Lepikhov >> >

Re: Fast COPY FROM based on batch insert

sent += size; } } while (sent < nused); There might a case for arguing that the respective FDW should check that it has actually received some tuples to insert, but IMHO it's much preferable to catch this as early as possible and avoid a superfluous call. FWIW, with the above fix in place, with a simple local test the patch produces a consistent speed-up of about 8 times compared to the existing functionality. Regards Ian Barwick -- EnterpriseDB - https://www.enterprisedb.com

Re: Corner-case bug in pg_rewind

d on the other timeline are invisible, but succeeded at last. Aha, many thanks. I wasn't entirely sure what I was looking for there and recently haven't had the time or energy to dig any further. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ Pos

Re: Improving connection scalability: GetSnapshotData()

ses, have been distracted by Various Other Things. The tests I run which originally triggered the issue now run just fine. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Corner-case bug in pg_rewind

ith a situation where this can be reproduced with only two nodes). The test sets "wal_keep_size" so would need modification for Pg12 and earlier. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development,

Re: Improving connection scalability: GetSnapshotData()

On 2020/09/08 13:23, Ian Barwick wrote: On 2020/09/08 13:11, Andres Freund wrote: Hi, On 2020-09-08 13:03:01 +0900, Ian Barwick wrote: (...) I wonder if it's possible to increment "xactCompletionCount" during replay along these lines: *** a/src/backend/access/transam/xa

Re: Improving connection scalability: GetSnapshotData()

session 1) insert a row on the primary using dblink, return the LSN, wait for the LSN to have replicated and finally in session 2) check for row visibility. The attached seems to do the trick. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Devel

Re: file_fdw vs relative paths

re.. It's missing the leading single quote from the filename parameter: diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml (...) -OPTIONS ( filename '/home/josh/data/log/pglog.csv', format 'csv' ); +OPTIONS ( filename log/pglog.csv&#

Re: Improving connection scalability: GetSnapshotData()

On 2020/09/08 13:11, Andres Freund wrote: Hi, On 2020-09-08 13:03:01 +0900, Ian Barwick wrote: (...) I wonder if it's possible to increment "xactCompletionCount" during replay along these lines: *** a/src/backend/access/transam/xact.c --- b/src/backend/access

Re: Improving connection scalability: GetSnapshotData()

; + + LWLockAcquire(ProcArrayLock, LW_EXCLUSIVE); + ShmemVariableCache->xactCompletionCount++; + LWLockRelease(ProcArrayLock); } which seems to work (though quite possibly I've overlooked something I don't know that I don't know about and it will al

[doc] minor wording improvement in a couple of places

e this file for additional details." Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/fdwhandler.sgml b/doc/src/sgml/fdwhandler.sgml new file mode 100644 index 72fa127..14

Re: Manager for commit fest 2020-09

is that correct? Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: pg13 docs: minor fix for "System views" list

On 2020/05/25 16:03, Fujii Masao wrote: On 2020/05/25 15:24, Michael Paquier wrote: On Mon, May 25, 2020 at 03:12:57PM +0900, Fujii Masao wrote: Thanks! LGTM. Will commit this. Oops :) No problem :) Thanks for the commit! Thanks both! Regards Ian Barwick -- Ian Barwick

pg13 docs: minor fix for "System views" list

Hi In this list: https://www.postgresql.org/docs/devel/views-overview.html "pg_shmem_allocations" is not quite in alphabetical order and needs to be swapped with the preceding entry, per attached patch. Regards Ian Barwick -- Ian Barwick https://www.2ndQu

Re: Remove non-fast promotion Re: Should we remove a fallback promotion? take 2

't be a problem. Correct, repmgr uses "pg_ctl promote" or pg_promote() (if available), and won't be affected by this change. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: Standby got fatal after the crash recovery

On 2020/03/17 12:53, Thunder wrote: Sorry. We are using pg11, and cloned from tag REL_11_BETA2. In that case you should upgrade to the current version in the PostgreSQL 11 series (at the time of writing 11.7). Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com

Re: Add %x to PROMPT1 and PROMPT2

control over the .psqlrc setup - while I can of course set the prompt manually it's an extra step, and it would be really nice to see the transaction status by default when working on critical systems in a time-critical situation. (Obviously it'll take a few years for this change to fi

Re: Prevent pg_basebackup running as root

On 2020/02/01 18:34, Michael Paquier wrote: On Thu, Jan 30, 2020 at 04:00:40PM +0900, Michael Paquier wrote: Anyway, your patch looks like a good idea to me, so let's see if others have opinions or objections about it. Seeing nothing, committed v2. Thanks! Regards Ian Barwick -

Re: Prevent pg_basebackup running as root

2020年1月30日(木) 14:57 Michael Paquier : > > On Thu, Jan 30, 2020 at 02:29:06PM +0900, Ian Barwick wrote: > > I can't think of any practical reason why pg_basebackup would ever need to > > be run as root; we disallow that for initdb, pg_ctl and pg_upgrade, so it > > se

Prevent pg_basebackup running as root

t mention it in the pg_ctl and pg_upgrade pages either and it doesn't seem particularly important to mention it explicitly. I'll add this to the March CF. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: doc: update PL/pgSQL sample loop function

On 2019/09/11 14:44, Amit Kapila wrote: On Sun, Sep 1, 2019 at 9:09 AM Amit Kapila wrote: The current example shows the usage of looping in plpgsql, so as such there is no correctness issue, but OTOH there is no harm in updating the example as proposed by Ian Barwick. Does anyone else see

Re: [PATCH] psql: add tab completion for \df slash command suffixes

On 2019/09/04 15:14, Kuntal Ghosh wrote: Hello Ian, On Fri, Aug 30, 2019 at 10:31 AM Ian Barwick wrote: I just noticed "\df[TAB]" fails to offer any tab-completion for the possible suffixes ("\dfa", "\dfn", "\dfp", "\dft" and "\dfw&quo

[PATCH] psql: add tab completion for \df slash command suffixes

Hi I just noticed "\df[TAB]" fails to offer any tab-completion for the possible suffixes ("\dfa", "\dfn", "\dfp", "\dft" and "\dfw"). Trivial patch attached, which applies back to Pg96, and separate patches for Pg95 and Pg94. I'l

doc: update PL/pgSQL sample loop function

ck search of plpgsql.sgml shows this is the only place they occur). Will submit to the next commitfest. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services commit d9e99b90fd0e572b4fd2461d7188a0197dee1

Re: [PATCH] Make configuration file "include" directive handling more robust

On 8/25/19 4:39 AM, Tom Lane wrote: Ian Barwick writes: On 7/17/19 5:34 PM, Kyotaro Horiguchi wrote:> Hello. I don't think this is new to 12. No, though I'm not sure how much this would be seen as a bugfix and how far back it would be sensible to patch. I think this is wort

Re: doc: clarify "pg_signal_backend" default role

On 8/28/19 7:04 AM, Tom Lane wrote: Ian Barwick writes: Currently the documentation for the default role "pg_signal_backend" states, somewhat ambiguously, "Send signals to other backends (eg: cancel query, terminate)", giving the impression other signals (e.g. SIGHUP) ca

Re: [PATCH] Tab completion for CREATE OR REPLACE

--- Could you add this to the next commitfest? https://commitfest.postgresql.org/24/ Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

sue closed. Thanks! Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

On 8/6/19 11:16 AM, Stephen Frost wrote: > Greetings, > > * Ian Barwick (ian.barw...@2ndquadrant.com) wrote: >> On 8/6/19 9:52 AM, Stephen Frost wrote:> Greetings, >>> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>>> >>>> + >

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

ment lines present. > >> >>The system view >>pg_file_settings >> - can be helpful for pre-testing changes to the configuration file, or for >> + can be helpful for pre-testing changes to the configuration files, or for >>

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

> widespread need in the first place; if I did buy it, that file > itself is not where to keep the history; and in any case, it'd be > a new feature and it's way too late for v12. Yeah, that's way outside of the scope of this issue. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

On 8/4/19 4:13 AM, Tom Lane wrote: Ian Barwick writes: On 8/3/19 7:27 AM, Tom Lane wrote: Tomas Vondra writes: The main issue however is that no code was written yet. Seems like it ought to be relatively simple ... but I didn't look. The patch I originally sent does exactly this.

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

On 8/3/19 8:24 AM, Andres Freund wrote: Hi, On 2019-08-03 08:22:29 +0900, Ian Barwick wrote: What I came up with shoehorned a stripped-down version of the backend config parser into fe_utils and provides a function to modify pg.auto.conf in much the same way ALTER SYSTEM does, but with only

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

tch, which'd start up far enough to perform GUC checks and execute AlterSystem(), and then shut down again. We already have -C, I think such an option could reasonably be implemented alongside it. Obviously this is widely out of scope for v12. Regards Ian Barwick -- Ian Barwick

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

019-08-03 08:14:21 JST]FATAL: 0A000: standby mode is not supported by single-user servers (I may be missing something obvious of course) Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

hread then drifted off into a discussion about providing ways for applications to properly write to pg.auto.conf while PostgreSQL is not running; I have a patch for that which I can submit later (though it is a thing of considerable ugliness). Regards Ian Barwick -- Ian Barwick h

Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )

en if that a one-liner, there is a comment so I think that this makes the code more readable. Yeah, I had removed those on purpose, but that was probably inconsistent with my own reviews of others' patches. I pushed it with them. Thanks Regards Ian Barwick -- Ian Barwick

Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )

hed, which as Alvaro suggests removes the escaping and adds a comment explaining why the raw value can be passed as-is. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/bin/pg_basebackup/p

Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )

actually fail with an error if an impossible slot name is provided, so the escaping is superfluous anyway. I'll take another look at it later as it's not exactly critical, just stuck out when I was passing through the code. Regards Ian Barwick -- Ian Barwick h

[PATCH] minor bugfix for pg_basebackup (9.6 ~ )

Hi In pg_basebackup's GenerateRecoveryConf() function, the value for "primary_slot_name" is escaped, but the original, non-escaped value is written. See attached patch. This has been present since the code was added in 9.6 (commit 0dc848b0314). Regards Ian Barwick --

Re: Documentation fix for adding a column with a default value

uldn't we add that to the current commit fest? The current commitfest is closed for new additions, but please add it to the next one (2019-09) and it will be picked up then. To me it looks like a minor documentation correction to fix an omission from a patch already in PostgreSQL. Regards

Re: [PATCH] Make configuration file "include" directive handling more robust

On 7/17/19 5:34 PM, Kyotaro Horiguchi wrote:> Hello. > > At Wed, 17 Jul 2019 12:29:43 +0900, Ian Barwick wrote in <8c8bcbca-3bd9-dc6e-8986-04a5abdef...@2ndquadrant.com> >> Hi >> >> While poking about with [1], I noticed a few potential issues with the >&g

Re: Fw: Documentation fix for adding a column with a default value

ot;Tip" to more of a brief "Note", which IMHO is a bit terse for that section of the documentation (which has more of a tutorial character), and the contents of the original tip basically still apply for volatile default values anyway. I've attached another suggestion for rew

[PATCH] Make configuration file "include" directive handling more robust

by manually editing it, I feel it's reasonable for the user to be made aware that they're not valid and have to manually remove them. Patches === Code: {1} disallow-empty-include-directives.v1.patch {2} track-included-files.v1.patch {3} prevent-disallowed-includes.v1.patch TAP tests: {

Re: doc: mention pg_reload_conf() in pg_hba.conf documentation

On 7/16/19 10:09 AM, Bruce Momjian wrote: On Mon, Jul 15, 2019 at 12:47:18PM +0900, Ian Barwick wrote: Hi I noticed the documentation for pg_hba.conf: https://www.postgresql.org/docs/current/auth-pg-hba-conf.html says: you will need to signal the postmaster (using pg_ctl reload or

doc: mention pg_reload_conf() in pg_hba.conf documentation

option here, as done elsewhere in the docs. Patch with suggested change attached. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.

Re: [PATCH] Implement uuid_version()

ml#id-1.11.7.34.9 Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/pgcrypto.sgml b/doc/src/sgml/pgcrypto.sgml new file mode 100644 index 0acd11e..f636703 *** a/doc/src/sgml/pgcr

Re: doc: minor update for description of "pg_roles" view

On 7/11/19 3:24 AM, Bruce Momjian wrote: On Wed, Jul 10, 2019 at 02:35:56PM +0900, Ian Barwick wrote: Hi Here: https://www.postgresql.org/docs/12/view-pg-roles.html we state: "This view explicitly exposes the OID column of the underlying table, since that is needed to do joi

doc: minor update for description of "pg_roles" view

attached patch (for REL_12_STABLE and HEAD) simply removes this sentence. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml n

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

potential footgun which needs fixing. (Though we'll still need to define/provide a way of writing configuration while the server is not running, which will be guaranteed to be read in last when it starts up). Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

icky because there's no guarantee the configuration will be written last, or even included at all, which is a regression against earlier versions as there you could clone a standby and (assuming there are no issues with any cloned configuration files) have the standby start up reliably. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: doc: update "relam" description in pg_class catalog reference

On 6/20/19 1:07 PM, Michael Paquier wrote: On Thu, Jun 20, 2019 at 11:20:46AM +0900, Ian Barwick wrote: Whoops, correct version attached. Sorry about the noise. v2 looks fine to me, committed. Thanks! Thanks! Regards Ian Barwick -- Ian Barwick https://www

Re: doc: update "relam" description in pg_class catalog reference

On 6/20/19 11:17 AM, Ian Barwick wrote: Hi Here:   https://www.postgresql.org/docs/devel/catalog-pg-class.html the description for "relam" has not been updated to take into account table access methods; patch attached. Whoops, correct version attached. Sorry about the noise.

doc: update "relam" description in pg_class catalog reference

Hi Here: https://www.postgresql.org/docs/devel/catalog-pg-class.html the description for "relam" has not been updated to take into account table access methods; patch attached. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL D

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

n 6/18/19 12:41 AM, Stephen Frost wrote: > Greetings, > > * Ian Barwick (ian.barw...@2ndquadrant.com) wrote (...) >> I suggest explicitly documenting postgresql.auto.conf behaviour (and the circumstances >> where it's acceptable to modify it outside of ALTER SYSTEM ca

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

On 6/19/19 12:46 PM, Amit Kapila wrote: On Mon, Jun 17, 2019 at 8:20 PM Ian Barwick wrote: On 6/15/19 1:08 AM, Stephen Frost wrote: > * Amit Kapila (amit.kapil...@gmail.com) wrote: >> Right. I think if possible, it should use existing infrastructure to >> write to postg

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

ry_conninfo" entries) which would not have occured in Pg11 and earlier (and which will no doubt cause consternation along the lines "how did my postgresql.auto.conf get modified in an unexpected way? OMG? Bug? Was I hacked?"). Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

Hi On 6/15/19 1:08 AM, Stephen Frost wrote: > Greetings, > > * Ian Barwick (ian.barw...@2ndquadrant.com) wrote: >> Consider the following cascading standby setup with PostgreSQL 12: >> >> - there exists a running primary "A" >> - standby "B&

[PATCH] Stop ALTER SYSTEM from making bad assumptions

ies first, before making any changes to the last entry. Arguably it might be sufficient (and simpler) to just scan the list for the last entry, but removing preceding duplicates seems cleaner, as it's pointless (and a potential source of confusion) keeping entries around which will never b

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

On 6/11/19 2:33 AM, Alexander Korotkov wrote: On Sat, Jun 8, 2019 at 8:17 PM Alexander Korotkov wrote: On Fri, Jun 7, 2019 at 6:02 PM Ian Barwick wrote: On 6/7/19 9:00 PM, Michael Paquier wrote: On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote: > Or is that not wo

doc: clarify "pg_signal_backend" default role

ched patch clarifies this, adds a descriptive paragraph (similar to what the other default roles have) and a link to the "Server Signaling Functions" section. Patch applies cleanly to HEAD and REL_11_STABLE. Regards Ian Barwick -- Ian Barwick https://www.2ndQuadran

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

UC description because I was poking about looking for examples of custom GUC handling...) Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/pgtrgm.sgml b/doc/src/sgml/

doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

Hi Commit be8a7a68662 added custom GUC "pg_trgm.strict_word_similarity_threshold", but omitted to document this in the section "GUC Parameters"; proposed patch attached. I suggest backpatching to Pg11, where it was introduced. Regards Ian Barwick -- Ian Barwick

Re: PG 12 draft release notes

On 5/22/19 4:26 PM, Michael Paquier wrote: On Wed, May 22, 2019 at 09:19:53AM +0900, Ian Barwick wrote: the last two items are performance improvements not related to authentication; presumably the VACUUM item would be better off in the "Utility Commands" section and the TRUNCA

Re: PG 12 draft release notes

the TRUNCATE item in "General Performance"? In section "Source code": https://www.postgresql.org/docs/devel/release-12.html#id-1.11.6.5.5.12 the item "Add CREATE ACCESS METHOD command" doesn't seem related to the source code itself, though I'm not sure w

Re: PG12, PGXS and linking pgfeutils

On 5/15/19 3:38 AM, Tom Lane wrote: I wrote: I think moving fe_utils/logging.[hc] to common/ is definitely the way to get out of this problem. I've pushed that, so Ian's problem should be gone as of HEAD. Thanks, that resolves the issue! Regards Ian Barwick -- I

PG12, PGXS and linking pgfeutils

g tree entirely of course). [*] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=cc8d41511721d25d557fc02a46c053c0a602fed Regards Ian Barwick -- Ian Barwick https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Servic

Re: Minor comment fix for pg_config_manual.h

On 12/29/18 8:27 AM, Michael Paquier wrote: On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote: Looks good to me. Thanks for the lookup. I have committed and back-patched to v11 for consistency. Thanks! Regards Ian Barwick -- Ian Barwick http://www

Small doc tweak for array/string functions

to find no reference on that page). Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index 3786099..1684189 ***

Minor comment fix for pg_config_manual.h

Hi Attached is mainly to fix a comment in $subject which has a typo in the referenced initdb option ("--walsegsize", should be "--wal-segsize"), and while I'm there also adds a couple of "the" for readability. Regards Ian Barwick -- Ian Barwick

Re: Function to promote standby servers

feels more natural to you? Sorry for the time it took. After pondering on it, I have committed the improvements from your version. Thanks, looks good (and apologies for the delay in responding from my side). Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/

Re: Function to promote standby servers

rg/docs/devel/static/functions-admin.html#FUNCTIONS-RECOVERY-CONTROL Attached patch contains a suggested rewording to clarify this. Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services commit 208247998484ee70

Re: Function to promote standby servers

rg/docs/devel/static/functions-admin.html#FUNCTIONS-RECOVERY-CONTROL Attached patch contains a suggested rewording to clarify this. Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services commit 208247998484ee70

Re: Add %r substitution for psql prompts to show recovery status

On 01/23/2018 03:19 AM, Peter Eisentraut wrote: On 1/9/18 15:36, Peter Eisentraut wrote: On 12/7/17 19:54, Tatsuo Ishii wrote: On Wed, Dec 6, 2017 at 9:19 PM, Ian Barwick wrote: Note this substitution sends a "pg_is_in_recovery()" query to the server each time it's enco

Add %r substitution for psql prompts to show recovery status

nt recovery status. A possible alternative would be only to check the status each time a new database connection is made, but that wouldn't catch the case where the server has been promoted. Will submit to next commitfest. Regards Ian Barwick -- Ian Barwick http://www