Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

2020-03-16 Thread Hugh McMaster
On Sat, 14 Mar 2020 at 03:06, Tom Lane wrote: > Looking again at the generated configure code, I realize I shouldn't have > left off the ACTION-IF-NOT-FOUND argument --- the default is to > throw an error, but we'd rather fall through and try to use xml2-config. > The eventual AC_CHECK_LIB(xml2, ..

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

2020-03-13 Thread Hugh McMaster
On Fri, 13 Mar 2020 at 03:39, Tom Lane wrote: > I poked at this issue a bit more and realized that Hugh's patch > flat-out breaks building --with-libxml in environments without > pkg-config, because PKG_CHECK_MODULES just gives up and dies > if there's no pkg-config (as we'd already found out in co

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

2020-03-11 Thread Hugh McMaster
On Thu, 12 Mar 2020 at 03:39, Tom Lane wrote: > Daniel Gustafsson writes: > > For me, the duplication aspect is the most troubling, since we'd still > need the > > xml2-config fallback and thus won't be able to simplify the code. > > Yeah, but at least it's concentrated in a few lines in configure

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

2020-03-11 Thread Hugh McMaster
On Wed, 11 Mar 2020 at 07:49, Daniel Gustafsson wrote: > > On 10 Mar 2020, at 18:38, Peter Eisentraut wrote: > > Btw., here is an older thread for the same issue > > . > > Might be worth reflecting on the is

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

2020-03-11 Thread Hugh McMaster
On Tue, 10 Mar 2020 at 22:41, Daniel Gustafsson wrote: > > > On 10 Mar 2020, at 11:53, Hugh McMaster wrote: > > This patch uses pkg-config's PKG_CHECK_MODULES macro to detect libxml2 > > or, if pkg-config is not available, falls back to xml2-confg. > >

[PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

2020-03-10 Thread Hugh McMaster
Dear developers, Debian (and Ubuntu) are beginning to remove foo-config legacy scripts. Already, xml2-config has been flagged for removal, with packages being asked to switch to pkg-config. This patch uses pkg-config's PKG_CHECK_MODULES macro to detect libxml2 or, if pkg-config is not available,