```
list_free_deep(sequences_to_copy);
```
IIUC, this function free's each elements and list itself, but they do no-op for
attributes of elements. Can we pfree() for seqname and nspname?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
codingIfNecessary() acquires lock before checking the
recovery status, but it could not work well. Not sure but
WaitForProcSignalBarrier()
stucked if the process acquired LogicalDecodingControlLock lock
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Ajin,
Thanks for updates. I confirmed that reported issues could be fixed by your
patch.
I have no comments anymore.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
ou modify like others do?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
)
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
> > How do you feel the .diff file can be applied atop PG17 patch? It is mainly
> > same as v4 patch but has some assertion.
Sorry for my interrupted message. I noticed only I attached old version patch.
PSA the correct version.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
> How do you feel the .diff file can be applied atop PG17 patch? It is mainly
> same as v4 patch but has some assertion.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
op PG17 patch? It is mainly
same as v4 patch but has some assertion.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
kuroda.diffs
Description: kuroda.diffs
ve the flag from
the argument but they are retained till now.
Based on that, I suggest adding new argument (or add new Ex function for bank
branches)
and do the assertion check when the assertion is enabled in this build. Thought?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
atesubscriber needs
a streaming standby and wal_level = minimal cannot be set with this node
placement.
Thought?
4.
We should update PG_CONTROL_VERSION and pg_controldata as well.
5.
I'm wondering how pg_resetwal handles. Since all the replication slot cannot be
used after the command, logicalDecodingEnabled can be set to false, right?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
SYNC:
+ /* Should never happen. */
+ Assert(0);
```
Should we call elog(ERROR) instead of Assert(0) like another case?
19.
```
/* Find the leader apply worker and signal it. */
logicalrep_worker_wakeup(MyLogicalRepWorker->subid, InvalidOid);
```
Do we have to signal to the leader even when the sequence worker exits?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
at current API has too complex.
Per document:
```
+ -f table
+ --table=table
```
I feel using "-f" is not suitable. Let's remove the shorten option now.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
xfunc-c.html#XFUNC-API-ABI-STABILITY-GUIDANCE
Best regards,
Hayato Kuroda
FUJITSU LIMITED
or xid=400 may come after another commit for
xid=402. Thus we cannot predict whether we should finish the recovery after
applying one transaction, when recovery_target_inclusive = false and
recovery_target_xid is set.
[1]:
https://www.postgresql.org/message-id/CANhcyEVqFCNhrbkCJwOpT1Su5-D3s%2BkSsOoc-4edKc7rzbRfeA%40mail.gmail.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
for it is not to output WITH cause for default setting. Thought?
[1]:
https://www.crunchydata.com/blog/postgresql-unlogged-sequences#unlogged-sequences-in-postgres-have-no-performance-gain
Best regards,
Hayato Kuroda
FUJITSU LIMITED
5 [1], but I found 021_alter_sub_pub could fail on
PG14.
Regarding the PG13, it may not be affected because the replication origin seemed
not to be used for the table sync. It was introduced for ce0fdbfe97.
[1]:
https://www.postgresql.org/message-id/bab95e12-6cc5-4ebb-80a8-3e41956aa297%40gmail.com
Best rega
access exclusive
3 pg_replication_origin excluive
IIUC we must preserve the ordering, not the target of locks.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
or a millisecond when accessing it)...
I also feel like that. But if so, how should we fix tests? We must remove all
stuff which assumes the time is monotonic?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
s for it?
[1]:
https://www.postgresql.org/message-id/flat/18897-d3db67535860dddb%40postgresql.org
Best regards,
Hayato Kuroda
FUJITSU LIMITED
recovery_stop_after.diffs
Description: recovery_stop_after.diffs
eason to
study)
> With all that said, I'll move on with this stuff once the embargo for
> v18 beta2 is lifted and the tag is pushed. That should happen in 24h
> or so, I guess.
The provided patches looks good to me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
try_ref()
returns
NULL right?
[1]:
https://learn.microsoft.com/en-us/windows/win32/api/minwinbase/ns-minwinbase-filetime
[2]:
https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getsystemtimepreciseasfiletime
[3]:
https://learn.microsoft.com/en-us/windows/win32/sysinfo/acquiring-high-resolution-time-stamps
[4]:
http://www.windowstimestamp.com/description#:~:text=2.1.4.2.%C2%A0%C2%A0Desktop%20Applications%3A%20GetSystemTimePreciseAsFileTime()
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear hackers,
> -- Also, worker and logical replication related parameters were increased
>as needed (see attached scripts for details).
Sorry, I forgot to attach scripts.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
row_filter_measure.sh
Description: row_filter_meas
11264.78483 11422.47011
3 11146.6676 11518.8403
median 11264.78483 11471.8107
Best regards,
Hayato Kuroda
FUJITSU LIMITED
B14966.jpnprd01.prod.outlook.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
shold under
> CLOBBER_CACHE_ALWAYS, if my memory serves me well. There are some
> machines with a valgrind setup, additionally, that can take some time,
> but I am not sure about their timings when it comes to a bootstrap
> setup.
Hmm. So I felt that we should not add tests for transaction_timeout for such a
slow
environment. Thought?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
],
+ 'successful creation with ignored settings');
+
```
But both Andy's patch and mine assume that post-bootstrap transactions can be
finished within the specified time. Extremely long value is set above but I
cannot say all machine won't spend 200s here...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
-API-COMPATIBILITY
[2]:
https://github.com/postgres/postgres/commit/f4af4515bb5f3591d49bc16b6cb8ddbf66f98374
Best regards,
Hayato Kuroda
FUJITSU LIMITED
her and 19568.4 on the subscriber. Here the conflict slot could
survive
during the benchmark because concurrency on the publisher was reduced.
Performance could be improved on the subscriber side because dead tuples can be
reduced here.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
stgresql.org/message-id/CABdArM4OEwmh_31dQ8_F__VmHwk2ag_M%3DYDD4H%2ByYQBG%2BbHGzg%40mail.gmail.com
[4]:
https://www.postgresql.org/message-id/OSCPR01MB14966F39BE1732B9E433023BFF5E72%40OSCPR01MB14966.jpnprd01.prod.outlook.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
r of retries after serialization or deadlock errors
(zero unless --max-tries is not equal to one)
```
To confirm; --continue-on-error won't be counted here because it is not "retry",
in other words, it does not reach CSTATE_RETRY, right?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
more GUCs were found which cannot be set during the bootstrap mode, how about
introducing a new flag like GUC_DEFAULT_WHILE_BOOTSTRAPPING for GUC variables?
If the flag is set all setting can be ignored when
IsBootstrapProcessingMode() = true.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
o clarify,
The current patch looks good to me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
tion. This does very fundamental validation
for the string and may be able to do in both dry run/normal mode.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
node->safe_psql('postgres',
q{select injection_points_wakeup('checkpoint-before-old-wal-removal')});
+# Generate a long WAL record
+$node->safe_psql('postgres',
+ q{select pg_logical_emit_message(false, '', repeat('123456789',
1000))});
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
in all
> failure cases as to why the physical slot's restart_lsn goes backward,
> and then add a comment somewhere to ensure that we don't repeat a
> similar mistake in the future.
I've wrote a draft for that. How do you think?
Best regards,
Hayato Kuroda
FUJITSU LIMI
hat clients could throw away the failed transaction and start
new one again in the case. I hope we are on the same page...
[1]:
https://www.postgresql.org/message-id/20250614002453.5c72f2ec80864d840150a642%40sraoss.co.jp
Best regards,
Hayato Kuroda
FUJITSU LIMITED
s patch "as is".
To clarify: I have no objections. Thanks for giving the knowledge.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
s the result at once. A corner case is when the segment is changed, but
this is not the same situation we observed the failure.
So... I have no idea to create deterministic reproducers, it is OK for me to use
046 test for the purpose.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Ishii-san,
Actually Saito-san has already been registered [1]. And cfbot said OK.
[1]: https://commitfest.postgresql.org/patch/5775/
Best regards,
Hayato Kuroda
FUJITSU LIMITED
ransaction is very useful
in this case.
Anyway, we must confirm the opinion from the proposer.
[1]: https://github.com/ryogrid/tpcc_like_with_pgbench
Best regards,
Hayato Kuroda
FUJITSU LIMITED
last_saved_restart_lsn_updated = true;
I feel no need to set to true if last_saved_restart_lsn_updated is already true.
Other than that it's OK for me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
w that we have a
> contrecord, but I'm not really excited about this prospect in
> xlogreader.c which can be also used in the frontend.
Per my understanding an injection point must be added while flushing a WAL
record,
to emulate the incomplete WAL record issue. To confirm, how can it be used in
ReadPageInternal()?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Dilip,
Another idea is to call ReplicationSlotsComputeRequiredLSN() when at least one
of the restart_lsn is updated, like attached. I feel this could reduce the
computation
bit more.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
tmp.diffs
Description: tmp.diffs
rrect anymore, 1462aad2 allows to alter two_phase option.
I was an original author, but I did oversight.
I feel it can be fixed by referring the commit message, attached patch fixed
like
that. How do you feel?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
0001-Fix-missing-comment-update-in-146
ailover replication slots if they exist on subscriber */
drop_failover_replication_slots(dbinfos.dbinfo);
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
ating failure caused at 040_standby_failover_slots_sync.
[1]:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=scorpion&dt=2025-06-17%2000%3A40%3A46&stg=pg_basebackup-check
Best regards,
Hayato Kuroda
FUJITSU LIMITED
ceiver, so is there a case that LogstreamResult.Flush
can go backward?
Not sure we can accept the situation.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
glish, native speaker is needed
> > 06. usage()
> > Added line is too long. According to program_help_ok(), the output by help
> should
> > be less than 80.
>
> +1
FYI - I posted a patch which adds the test. You can apply and confirm how the
function says.
[1]:
https://www.postgresql.org/message-id/OSCPR01MB1496610451F5896375B2562E6F56BA%40OSCPR01MB14966.jpnprd01.prod.outlook.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
description. Now the
documentation says:
```
-t
--two-phase
Enables decoding of prepared transactions. This option may only be specified
with --create-slot.
```
If we clarify the option is aimed for the slot, should we follow the
description in the protocol.sgml? I.e.,
```
-t
--two-phase
the slot supports decoding of two-phase commit. This option may only be
specified with --create-slot.
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
oing actual INSERT
command because no one refers the replicated result. Same thing can be said in
046/047.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
ared_preload_libraries in 046/047. ISTM it must be set when we
enable the statistics.
02.
We should also check whether the injection_points can be installed or not.
You can check check_extension() and callers.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
with back-patching if others see value
> in it.
Initially I thought this was helpful even for back branches, but it is not
100% needed.
No objections even if it is only applied to master - it can check new features
in
future.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
www.slideshare.net/slideshow/postgresql-community-development-deim2024-nttdata/26663#24
Best regards,
Hayato Kuroda
FUJITSU LIMITED
rltidy, I got some diffs.
[1]: https://cirrus-ci.com/task/5210061275922432
Best regards,
Hayato Kuroda
FUJITSU LIMITED
tail.
[1]: https://git-scm.com/book/en/v2/Appendix-C:-Git-Commands-Email
Best regards,
Hayato Kuroda
FUJITSU LIMITED
e focus on it...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v3-PG13-HEAD-0001-pgbench-Run-program_XXX-tests-instead-of-its.patch
Description: v3-PG13-HEAD-0001-pgbench-Run-program_XXX-tests-instead-of-its.patch
ained
> program. So I think it is ok if these two are intentionally different.
You meant that 0002-0004 are not needed, right?
So let's put on out-of-scope...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
If possible, I want to fork another thread to discuss 0002-0004 and want to
concentrate 0001 here.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v2-0001-pgbench-Run-program_XXX-tests-instead-of-its-own-.patch
Description: v2-0001-pgbench-Run-program_XXX-tests-instead-of-its-own-.patch
v2
program_help_ok() checks whether lines are too long or not.
For now, the rule seems to be kept but not sure in future.
I feel that we can replace tests with common function, like attached. How do you
think?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
0001-pgbench-Run-program_XXX-tests-instead-of-its-own
both are specified?
Is it allowed?
3.
Can you consider a test case for the new parameter?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
ht one.
[1]: https://git-scm.com/docs/git-format-patch
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Michael,
> Thanks, I've applied some slight tweaks, and applied the result down
> to v17, leaving the heap_update point alone.
Thanks, I confirmed your commit on HEAD and LGTM.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
/local/lib:/usr/lib64/
```
I modified the first one to refer lib64 dir, but the result is not changed.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
t matches with this code path,
> as this lacks a reference regarding the end of a transaction. Perhaps
> something like "end-transaction-process-inval" would be better?
Thanks for suggesting them. ISTM, you are correct. PSA updated version.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
..
LD_LIBRARY_PATH=/home/hayato/builddir/tmp_install//usr/local/pgsql/lib64:/usr/local/pgsql/lib:/usr/local/lib:/usr/lib64/...
Attached is a file which extract some lines from testlog.txt.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
...
1/4
he
performance.
How do you feel to cap the value with rel::rd_rel::relpages in
heap_parallel_vacuum_compute_workers()?
This value is not always up-to-date but seems good candidate.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
942 UTC [980:5] LOG: database system is shut down
```
Now the report has been reported for both physical and logical replication,
but I suspected that this can happen for all the application.
[1]:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=drongo&dt=2025-04-12%2003%3A59%3A38&a
ck
Best regards,
Hayato Kuroda
FUJITSU LIMITED
;)
== 0)
```
IIUC, we can assume that the vesion of new_cluster is same as pg_upgrade, so no
need to check the major version here.
03.
Can we add a test for upgrading subscriber node with retain_conflict_info in
004_subscription?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
lated with my part:
Should cur_pos be uint32 instead of int? Either of them can work because
cur_pos can be [0, 128], but it may be clearer.
Apart from above, LGTM.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
lease see [1].
[1]:
https://www.postgresql.org/message-id/OSCPR01MB14966E14C1378DEE51FB7B7C5F5B32%40OSCPR01MB14966.jpnprd01.prod.outlook.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
not good. The point seems to locate in
the end-of-transaction callback and it accepts invalidation messages. Based on
the
fact, how about "inval-process-invalidation-messages"?
0002 did simple replacements of these words.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v2-0002-Follow-nam
ce for the description. I added at the end of
first
paragraph, because it describes how we add and use it. Suggestions are very
welcomed.
[1]:
https://www.postgresql.org/message-id/OSCPR01MB14966B78F3AF15C252EB9E02FF5B32%40OSCPR01MB14966.jpnprd01.prod.outlook.com
Best regards,
Hayato Kuroda
FUJIT
but I feel there are no concrete naming
rules
(I confused while creating patches). Can we clarify that? E.g., first term
should
be a module or process, or something like that.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
oints()
ORDER BY name COLLATE "C";
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
connection to server was lost
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
diff --git a/src/backe
resql:regress / regress/regress ERROR 3.66s exit
status 2
...
Ok: 3
Expected Fail: 0
Fail: 1
Unexpected Pass:0
Skipped:0
Timeout: 0
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
pass on my env. PSA patches for PG16.
Patch for PG17 is not changed, just renamed.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v6-PG17-0001-Stabilize-035_standby_logical_decoding.pl.patch
Description: v6-PG17-0001-Stabilize-035_standby_logical_decoding.pl.patch
v6-PG16
napshotConflictHorizon is the xid which first PRUNE records exist.
Based on the fact, I considered that catalog_xmin can be advanced till the
between
(non-)transactional PRUNE records. RequestCheckpoint() is added to generate the
RUNNING_XACTS in-between them.
Very thanks Amit for supporting me off-lis
#x27;m considering.
LGTM, thanks.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Fujii-san,
> I've updated the commit messages for both patches and also revised
> the code comments in the 0002 patch. The updated patches are attached.
>
> Unless there are any objections, I'm thinking to commit them.
Thanks for updating the patch. LGTM.
Best
s been missed 8 years ago, let's fix now.
BTW, the issue exists for all supported branches. How do you feel
to backpatch them? PSA all patch set.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v2-PG13-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
Description: v2-PG13-0001-Fix-i
Dear Fujii-san,
> Unless there are any objections, I plan to push your patch with
> the following commit message and back-patch it to all supported versions.
...
Thanks for updating the commit message. LGTM.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Dear Fujii-san,
> I've pushed the patches. Thanks!
This is a closing post. I confirmed at least one BF animal for each version
have been run and said OK. IIUC there are no threads to be forked.
Thanks for pushing!
Best regards,
Hayato Kuroda
FUJITSU LIMITED
iption for --failover option
> after -E/--endpos.
Right. I put because it had short-term '-o' in old version, but it was removed.
Fixed.
PSA new version.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v3-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch
Description: v3-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch
17-2 uses new proposed one.
Bertrand, which one do you like?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v5-PG17-1-0001-Stabilize-035_standby_logical_decoding.pl.patch
Description: v5-PG17-1-0001-Stabilize-035_standby_logical_decoding.pl.patch
v5-PG17-2-0001-Stab
Dear Michael,
> Maybe we don't need a short option at all for this, at least initially?
Indeed, updated.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v2-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch
Description: v2-0001-Allow-pg_recvlogical-to-create-slots-with-failove.patch
> Isn't patch 0001-Fix-invalid-referring-of-hash-ref-for-replication-sl
> unrelated to this thread? Or am, I missing something?
I did attach wrongly, PSA correct set. Sorry for inconvenience.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
v5-0001-Stabilize-035_standby_logical_dec
be fail. I did not reproduce this but
something like this can happen if we activate slots.
Attached patch has a conclusion of these discussions, slots are created but
it seldomly be activated.
Naming of patches are bit different, but please ignore...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
becomes 'undef' thus any tests are meaningless.
It looks like that existing codes want to check the existing of given logical
slots.
So, it is enough to search with key 'plugin'. The valid value is set if exists,
otherwise ''.
How do you think?
Best regards,
vanced till that. Upcoming PRUNE_ON_ACCESS points the txn3 so
that
slot invalidation won't happen in this case.
Based on the fact, I've updated to use injection_points for scenario 5. Of
course,
PG16/17 patches won't use the active slot for that scenario.
Best regards,
Hayato
ce condition though.
Added.
> === 6 (Nit)
>
> In drop_logical_slots(), s/needs_active_slot/drop_active_slot/?
Fixed.
> === 7 (Nit)
>
> In check_slots_conflict_reason(), s/needs_active_slot/checks_active_slot/?
Fixed.
> About PG16-v2-0001
>
> Same as
d emit_wal( in Cluster.pm. Even so, we have
not found the use-case yet, thus I want to retain now and will update based on
the future needs.
I'll investigate another point [1] and then will post new version.
[1]:
https://www.postgresql.org/message-id/CAA4eK1%2Bx5-eOn5%2BMW6FiUjB_1bBCH8jCCARC1uMrx6erZ3J73w%40mail.gmail.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
patch implements it. Since -f/-F option has already been used, -O was
chosen for the short-version. Better idea is very welcomed.
How do you feel?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
0001-Allow-pg_recvlogical-to-create-slots-with-failover-t.patch
Description: 0001-Allow-pg_recvlogical
o the master branch. What do you think should we
> back-patch it as a bug fix or apply it only to master?
Personally considered, such a long-standing but harmless bug can be regarded as
the specification. So, I vote that this is an enhancement and be applied only to
master.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
> (injection_points_attach('heap_update-before-pin', 'wait');) but I
> think it may be better to just leave testing active slots in
> backbranches because anyway the new development happens on HEAD and we
> want to ensure that no breakage happens there.
OK. I've att
SCRIPTION ..." commands and keep
> copy_data=true to ensure the initial replication is setup between
> publisher and subscriber. This is how we use these commands at other
> places.
Agreed. PSA the patch to fix the issue.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
0001-Stablize-tes
Dear Andres,
> I think the new tests just failed in CI:
> https://cirrus-ci.com/task/5602950271205376?logs=test_world#L268
Thanks for reporting, I'll look into it.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
#x27;--subscriber-port' => $node_s->port,
+ '--all',
+ ],
+ 'run pg_createsubscriber with --all');
```
We should test the case when -P does not contain dbname. IIUC, it is enough to
use
`node_p->connstr` instead of `node_p->connstr($db1)`.
[1]:
https://www.postgresql.org/message-id/CAExHW5uvp6LWfgcysohDaOaNhqAbmuc%3D9BwWke%3D6KPRZ%2BwVOkA%40mail.gmail.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
tcase
won't invalidate slots, so they retained.
* 'DROP DATABASE should drops...' invalidates slots, but it does not related
with
xmin horizon, so it retained.
The patch aimed only PG16, but can be created for PG17 as well, if needed.
Best regards,
Hayato Kuroda
FU
the record. This does not need to extend injection_point module.
I tested with reproducer and passed on my env.
Sadly IS_INJECTION_POINT_ATTACHED() was introduced for PG18 so that the patch
could not backport for PG17 as-is.
How do you feel?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
1 - 100 of 816 matches
Mail list logo
