Re: pg14 psql broke \d datname.nspname.relname

2021-11-04 Thread Hamlin, Garick L
On Wed, Oct 13, 2021 at 09:24:53AM -0400, Robert Haas wrote: > > Splitting the pattern on all the dots and throwing away any additional > > leftmost fields is a bug, ... > > I also agree with you right up to here. > > > and when you stop doing that, passing additional dots through to the POSIX >

Re: cleaning perl code

2020-04-16 Thread Hamlin, Garick L
On Thu, Apr 16, 2020 at 08:50:35AM -0400, Andrew Dunstan wrote: > > It would also be more robust using non-greedy matching: This seems more important. I don't know how/where this is being used, but if it has input like: /* one */ something; /* two */ With the old expression 'something;' would

Re: Unix-domain socket support on Windows

2019-12-18 Thread Hamlin, Garick L
On Wed, Dec 18, 2019 at 02:52:15PM +0100, Peter Eisentraut wrote: > To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR > to "" has the desired effect. This mostly already worked like that; > only a few places needed to be adjusted. Notably, the reference to > DEFAULT_PGSOCKET_DI

Re: Dead stores in src/common/sha2.c

2019-05-29 Thread Hamlin, Garick L
On Wed, May 29, 2019 at 11:01:05AM -0400, Tom Lane wrote: > Michael Paquier writes: > > On Wed, May 29, 2019 at 01:24:19PM +0000, Hamlin, Garick L wrote: > >> I ran clang checker and noticed these. It looks like the > >> sha2 implementation is trying to zero out st

Dead stores in src/common/sha2.c

2019-05-29 Thread Hamlin, Garick L
I ran clang checker and noticed these. It looks like the sha2 implementation is trying to zero out state on exit, but clang checker finds at least 'a' is a dead store. Should we fix this? Is something like the attached sensible? Is there a common/better approach to zero-out in PG ? Garick di

Re: libpq compression

2019-02-11 Thread Hamlin, Garick L
On Mon, Feb 11, 2019 at 05:56:24PM +0300, Konstantin Knizhnik wrote: > > Also such attack is possible only if session_id can be somehow "guessed". If > it is just big random number, then it is very unlikely that it can be hacked > in in this way. I am not arguing against compression, but this poi