Am 07.04.22 um 01:54 schrieb Michael Paquier:
> On Wed, Apr 06, 2022 at 02:32:44PM +0200, Gunnar "Nick" Bluth wrote:
>> Ta! Sorry, been ridiculously busy these days, and I do confess that I've
>> been struggling a bit with those tests before ;-)
>
> No probl
be changed significantly, bloating them even if the feature is
inactive).
It also would have made the stats updates synchronous (at TX end), would
have been "blind" for all TOAST efforts done by rolled back TXs etc.
What you can do is of course (just like track_functions):
ALTE
Am 06.04.22 um 18:55 schrieb Andres Freund:
> Hi,
>
> On 2022-04-06 12:24:20 -0400, Robert Haas wrote:
>> On Wed, Apr 6, 2022 at 12:01 PM Gunnar "Nick" Bluth
>> wrote:
>>> Fair enough. At that point, a lot of things become unexpectedly painful.
>>
y, but certainly is a bit out-of-time (and requires
some basic math skills ;-).
Best,
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münster
Mobil +49 172 8853339
Email: gunnar.bl...@pro-open.de
__
"Ceterum censeo SystemD esse delendam" - Cato
how cheap extensions to the
> statistics system will be.
Again, fair enough!
Maybe we first need statistics about statistics collection and handling? ;-)
Best,
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münster
Mobil +49 172 8853339
Email: gunnar.bl...@pro-open.de
__
"Ceterum censeo SystemD esse delendam" - Cato
internally
> starts the target cluster, as of when we retrieve restore_command and
> when we enforce crash recovery to have a target cluster with a clean
> shutdown state. The tests are heavily simplified, having no impact on
> the run-time while improving the coverage for the code pat
Am 05.04.22 um 18:17 schrieb Robert Haas:
> On Thu, Mar 31, 2022 at 9:16 AM Gunnar "Nick" Bluth
> wrote:
>> That was meant to say "v10", sorry!
>
> Hi,
Hi Robert,
and thx for looking at this.
> From my point of view, at least, it would be preferable
Am 31.03.22 um 15:14 schrieb Gunnar "Nick" Bluth:
> Am 22.03.22 um 12:23 schrieb Gunnar "Nick" Bluth:
>> Am 22.03.22 um 02:17 schrieb Andres Freund:
>>> Hi,
>>>
>>> On 2022-03-08 19:32:03 +0100, Gunnar "Nick" Bluth wrote:
>&
Am 22.03.22 um 12:23 schrieb Gunnar "Nick" Bluth:
> Am 22.03.22 um 02:17 schrieb Andres Freund:
>> Hi,
>>
>> On 2022-03-08 19:32:03 +0100, Gunnar "Nick" Bluth wrote:
>>> v8 (applies cleanly to today's HEAD/master) attached.
>>
>>
Am 22.03.22 um 02:17 schrieb Andres Freund:
> Hi,
>
> On 2022-03-08 19:32:03 +0100, Gunnar "Nick" Bluth wrote:
>> v8 (applies cleanly to today's HEAD/master) attached.
>
> This doesn't apply anymore, likely due to my recent pgstat changes - which
>
d; this was already off before this patch
> though.
That one has been triggering my inner Monk too ;-)
Fixed!
[...]
> You removed an empty line here. Maybe rather prepend this with a comment
> on what's going on, and have en empty line before and afterwards.
> Kinde same here.
I
Am 04.01.22 um 12:29 schrieb Gunnar "Nick" Bluth:
> Am 03.01.22 um 22:23 schrieb Alvaro Herrera:
>> Overall I think this is a good feature to have; assessing the need for
>> compression is important for tuning, so +1 for the goal of the patch.
>
> Much appreciated!
Am 01.03.22 um 05:18 schrieb Michael Paquier:
On Mon, Feb 28, 2022 at 08:48:23PM +0100, Gunnar "Nick" Bluth wrote:
So, how should we call the global "find the * 'postgres' executable and
boil out if that fails" function?
char postgres_exec_path[MAXPGPATH]
Am 28.02.22 um 12:56 schrieb Michael Paquier:
On Sun, Feb 27, 2022 at 02:30:33PM +0100, Gunnar "Nick" Bluth wrote:
That's universally true ;-)
-# Internal routine to enable archive recovery command on a standby node
+# Internal routine to enable archive recovery command on
Am 27.02.22 um 13:06 schrieb Michael Paquier:
On Sat, Feb 26, 2022 at 09:55:20AM +0100, Gunnar "Nick" Bluth wrote:
Am 26.02.22 um 06:51 schrieb Michael Paquier:
Shouldn't this one use appendShellString() on config_file?
It probably should, yes. I don't fancy this repetit
Am 26.02.22 um 06:51 schrieb Michael Paquier:
On Fri, Feb 25, 2022 at 10:35:49AM +0100, Gunnar "Nick" Bluth wrote:
Am 24.02.22 um 14:46 schrieb Daniel Gustafsson:
Actually, I think this looks like a saner approach. Putting a config setting
in two place (postgresql.conf and on the c
Am 24.02.22 um 14:46 schrieb Daniel Gustafsson:
On 24 Feb 2022, at 14:43, Gunnar Nick Bluth wrote:
That looks just as good to me, and it already has tests, so I'll happily step
down!
Actually, I think this looks like a saner approach. Putting a config setting
in two
provides a parameter to pass in
restore_command in cases where postgresq.conf isn't reachable:
https://commitfest.postgresql.org/37/3213/
That looks just as good to me, and it already has tests, so I'll happily
step down!
(Note to myself: check the CF first next time ;-)
--
d, it seemed to be
better that the other way...
As the "-c" feature appeared in 12 and existing Debian installations are
unable to use it right now, I suggest to even backport the patch.
Oh, and I'm still not subscribed to -hackers, so the usual "please CC
me" appli
2-Jan-03, Gunnar "Nick" Bluth wrote:
@@ -229,7 +230,9 @@ toast_tuple_try_compression(ToastTupleContext *ttc, int
attribute)
Datum *value = &ttc->ttc_values[attribute];
Datum new_value;
ToastAttrInfo *attr = &ttc->ttc_attr[a
sta ;-)
Removed.
Thx for looking into this!
Patch v7 will be in the next mail.
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münster
Mobil +49 172 8853339
Email: gunnar.bl...@pro-open.de
__
"Ceterum censeo SystemD esse delendam" - Cato
Am 03.01.22 um 20:11 schrieb Alvaro Herrera:
On 2022-Jan-03, Gunnar "Nick" Bluth wrote:
9:38 $ git format-patch PGDG/master -v5 -o ..
../v5-0001-ping-pong-of-thougths.patch
../v5-0002-ping-pong-of-thougths.patch
../v5-0003-adds-some-debugging-messages-in-toast_helper.c.patch
...
Am 03.01.22 um 19:30 schrieb Alvaro Herrera:
On 2022-Jan-03, Gunnar "Nick" Bluth wrote:
Am 03.01.22 um 17:50 schrieb Justin Pryzby:
Soon you will think this is fun :)
As long as you're happy with plain patches like the attached one, I may ;-)
Well, with a zero-byte patch
Am 03.01.22 um 17:50 schrieb Justin Pryzby:
On Mon, Jan 03, 2022 at 05:00:45PM +0100, Gunnar "Nick" Bluth wrote:
Am 03.01.22 um 16:52 schrieb Gunnar "Nick" Bluth:
pg_stat_toast_v0.4.patch attached.
Note that the cfbot says this fails under windows
Thanks for th
Am 03.01.22 um 16:52 schrieb Gunnar "Nick" Bluth:
pg_stat_toast_v0.4.patch attached.
Aaaand I attached a former version of the patch file... sorry, I'm kind
of struggling with all the squashing/rebasing...
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münst
ome tests (as meaningful as they may get, I'm afraid) are now in
src/test/modules/track_toast/.
"make check-world" executes them successfully, although only after I
introduced a "SELECT pg_sleep(1);" to them.
pg_stat_toast_v0.4.patch attached.
Best regards,
--
Gunnar "N
Am 12.12.21 um 17:20 schrieb Gunnar "Nick" Bluth:
Hello -hackers!
Please have a look at the attached patch, which implements some
statistics for TOAST.
The attached v0.3 includes
* a proper GUC "track_toast" incl. postgresql.conf.sample line
* gathering timing informati
w, grabbing the
information from pg_attribute.attcompression. It probably should!
I guess the next step will be to include that view in the catalog
anyway, so I'll do that next.
Thx for the feedback!
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münster
Mobil
Am 13.12.21 um 00:41 schrieb Andres Freund:
Hi,
On 2021-12-13 00:00:23 +0100, Gunnar "Nick" Bluth wrote:
Regarding stats size; it adds one PgStat_BackendToastEntry
(PgStat_BackendAttrIdentifier + PgStat_ToastCounts, should be 56-64 bytes or
something in that ballpark) per TOASTable
Am 12.12.21 um 22:52 schrieb Andres Freund:
Hi,
On 2021-12-12 17:20:58 +0100, Gunnar "Nick" Bluth wrote:
Please have a look at the attached patch, which implements some statistics
for TOAST.
The idea (and patch) have been lurking here for quite a while now, so I
decided to dust it o
type, functions, view columns etc.)
- would it be necessary to implement overflow protection for the size &
time sums?
Thanks in advance & best regards,
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münster
Mobil +49 172 8853339
Email: gunnar.bl...@pro-open.de
___
31 matches
Mail list logo
