Re: PATCH: Add REINDEX tag to event triggers

2023-07-26 Thread Garrett Thornburg
n a little nicer. Let me know what you think here. Until then, I left the code as `lev = LOGSTMT_DDL` for `T_ReindexStmt`. Thanks, Garrett On Thu, Jul 20, 2023 at 10:47 PM Garrett Thornburg wrote: > Added my v1 patch to add REINDEX to event triggers. > > I originally built this against

Re: PATCH: Add REINDEX tag to event triggers

2023-07-26 Thread Garrett Thornburg
Thank you for this, jian he! I will include it in the next patch version. P.S. Sorry for the double post. Sent from the wrong email address so I'm resending so the mailing list gets the email. My apologies! On Wed, Jul 26, 2023 at 4:30 AM jian he wrote: > On Wed, Jul 26, 2023 at 7:51 AM Michael

Re: PATCH: Add REINDEX tag to event triggers

2023-07-26 Thread Garrett Thornburg
m the wrong email so the mailing list didn't get the message. On Tue, Jul 25, 2023 at 12:55 AM Michael Paquier wrote: > On Thu, Jul 20, 2023 at 10:47:00PM -0600, Garrett Thornburg wrote: > > Added my v1 patch to add REINDEX to event triggers. > > > > I originally built thi

PATCH: Add REINDEX tag to event triggers

2023-07-20 Thread Garrett Thornburg
rks really well. I debated returning records of the table or DB that were reindexed but that doesn't really make sense. Returning each index fits my use case of building an audit record around the index lifecycle (hence the motivation for the patch). Thanks for your time, Garrett Thornburg

Re: Looking for context around which event triggers are permitted

2023-07-17 Thread Garrett Thornburg
ing a few more operations could prove useful. Example: You can track Create/Alter/Drop of a table's lifecycle, capturing timestamps in a table, but not indexes without REINDEX. On Mon, Jul 17, 2023 at 10:31 AM Alvaro Herrera wrote: > On 2023-Jul-17, Garrett Thornburg wrote: > > &g

Re: Looking for context around which event triggers are permitted

2023-07-17 Thread Garrett Thornburg
That's a good point, Isaac. Select into, security label, comment, etc are all maintenance style commands but are already added to the matrix. I do think there's a good case to include other maintenance related commands as event triggers. Suppose you want to know the last time a table was vacuumed o

Looking for context around which event triggers are permitted

2023-07-17 Thread Garrett Thornburg
Hey list, I was working on a project with event triggers and was wondering if there was any context from the developers around why some things make this list and others do not. Example: REVOKE/ GRANT are in the event trigger matrix [1] but REINDEX is not. Just wondering if there's a mailing list t