Thanks for bringing this up! I just looked at the uses if isspace() in that
file. It looks like it is the usual thing: it is allowing leading or
trailing whitespace when parsing values, or for this "needs quoting" logic
on output. The fix would be the same: this *should* be
using scanner_isspace. T
Thanks for the detailed discussion. To confirm that I've understood
everything:
* Michael's proposed patch to add hstore_isspace() would be a potential
fix: it resolves my original bug, and does not change the behavior of '\v'.
* We believe the change to '\v' is not a problem, and may be an improv
printf "select 'k=>\vv'::hstore" | psql
hstore
--
"k"=>"\x0Bv"
(1 row)
On Sun, Jun 11, 2023 at 8:18 PM Michael Paquier wrote:
> On Tue, Jun 06, 2023 at 10:16:09AM -0400, Evan Jones wrote:
> > I did a quick look at the plac
On Tue, Jun 6, 2023 at 5:23 PM Peter Eisentraut
wrote:
> This addresses only pg_regress. What about all the other test suites?
> Per the previous discussions, you'd need to patch up other places in a
> similar way, potentially everywhere system() is called.
>
Are there instructions for how I ca
On Mon, Jun 5, 2023 at 10:33 PM Tom Lane wrote:
> > Note that this is a known issue
> Yeah. We have attempted to work around this before, but failed to find
> a solution without more downsides than upsides. I will be interested
> to look at this patch, but lack time for it right now. Anybody e
On Tue, Jun 6, 2023 at 7:37 AM Michael Paquier wrote:
> Indeed. It looks like 9ae2661 missed this spot.
>
I didn't think to look for a previous fix, thanks for finding this commit
id!
I did a quick look at the places found with "git grep isspace" yesterday. I
agree with the comment from commit
\x226b6579c4223d3e2276616c756522
(1 row)
The correct result should be:
hstore
-
"keyą"=>"value"
(1 row)
That query is added to the regression test. The query works on Linux, but
failed on Mac OS X.
For a more detailed explanation of ho
he %s is the current environment variable. The "make check" Makefile
sets this environment variable to the temporary install directory, so this
fixes the above errors.
I tested this on Mac OS X and on Linux (Ubuntu 23.04).
Thanks!
Evan Jones
pg_regress_mac_os_x_dyld.patch
Description: Binary data
