Denis Laxalde a écrit :
Michael Paquier a écrit :
On Wed, Sep 07, 2022 at 12:50:32PM +0500, Ibrar Ahmed wrote:
The patch requires a rebase, please do that.
Hunk #5 succeeded at 454 (offset 28 lines). 1 out of 5 hunks FAILED
-- saving rejects to file doc/src/sgml/ref/grant.sgml.rej
There has
ture still works fine as far as I can tell.From 3e04442e3f283829ed38e4a2b435fd182addf87a Mon Sep 17 00:00:00 2001
From: Denis Laxalde
Date: Wed, 6 Mar 2024 14:55:40 +0100
Subject: [PATCH] fixup! libpq: Add encrypted and non-blocking versions of
PQcancel
---
doc/src/sgml/libpq.sgml |
; the later is already
in the list.From c2e685b51f89d80e6e937afaaa0f8d1231fc4d2c Mon Sep 17 00:00:00 2001
From: Denis Laxalde
Date: Wed, 23 Aug 2023 09:10:28 +0200
Subject: [PATCH] Remove a wrong name in acknowledgments
---
doc/src/sgml/release-16.sgml | 1 -
1 file changed, 1 deletion(-)
The documentation fails to build for me:
$ ninja docs
[1/2] Generating doc/src/sgml/postgres-full.xml with a custom command
FAILED: doc/src/sgml/postgres-full.xml
/usr/bin/python3 ../postgresql/doc/src/sgml/xmltools_dep_wrapper
--targetname doc/src/sgml/postgres-full.xml --depfile
doc/src/sgml/
Michael Paquier a écrit :
On Thu, Apr 27, 2023 at 01:06:27PM +0200, Denis Laxalde wrote:
Thank you; this V2 looks good to me.
Marking as ready for committer.
Please note that we are in a stabilization period for v16 and that the
first commit fest of v17 should start in July, so it will
Hello,
Anton Kirilov a écrit :
On 25/04/2023 15:23, Denis Laxalde wrote:
This sounds like a useful addition to me. I've played a bit with it in
Psycopg and it works fine.
Thank you very much for reviewing my patch! I have attached a new
version of it that addresses your comments and tha
Anton Kirilov wrote:
I would appeciate your thoughts on my proposal.
This sounds like a useful addition to me. I've played a bit with it in
Psycopg and it works fine.
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
index a16bbf32ef..e2b32c1379 100644
--- a/src/i
Hi,
Yurii Rashkovskii a écrit :
On Wed, Apr 19, 2023 at 11:44 PM Aleksander Alekseev <
aleksan...@timescale.com> wrote:
I would like to suggest a patch against master (although it may be
worth
backporting it) that makes it possible to listen on any unused port.
[...]
A bullet-proof approach
The patch set does not apply any more.
I tried to rebase locally; even leaving out 1 ("libpq: Run pgindent
after a9e9a9f32b3"), patch 4 ("Start using new libpq cancel APIs") is
harder to resolve following 983ec23007b (I suppose).
Appart from that, the implementation in v19 sounds good to me,
Jelte Fennema a écrit :
> On Wed, 29 Mar 2023 at 10:43, Denis Laxalde wrote:
> > More importantly, not having PQcancelSend() creating the PGcancelConn
> > makes reuse of that value, passing through PQcancelReset(), more
> > intuitive. E.g., in the tests:
>
> You c
Jelte Fennema a écrit :
> > Namely, I wonder why it returns a PGcancelConn and what's the
> > point of requiring the user to call PQcancelStatus() to see if something
> > got wrong. Maybe it could be defined as:
> >
> > int PQcancelSend(PGcancelConn *cancelConn);
> >
> > where the return value wo
g I found slightly inconvenient is the need to convey the
connection encoding (from PGconn) when handling error message from the
PGcancelConn.)
Cheers,
Denis
>From a5f9cc680ffa520b05fe34b7cac5df2e60a6d4ad Mon Sep 17 00:00:00 2001
From: Denis Laxalde
Date: Tue, 28 Mar 2023 16:06:42 +0200
Subje
DenisFrom de28d9ac1e541c3b3a0279dc58fb5a7f23f775f8 Mon Sep 17 00:00:00 2001
From: Denis Laxalde
Date: Fri, 7 Oct 2022 14:00:24 +0200
Subject: [PATCH] Reset single-row processing mode at end of pipeline commands
queue
Previously, we'd reset the single-row mode only when processing results
of the
Julien Rouhaud a écrit :
I think having a new option for vacuumdb is the right move.
It seems unlikely that any cron or similar on the host will try to run some
concurrent vacuumdb, but we still have to enforce that only the one executed by
pg_upgrade can succeed.
I guess it could be an undocum
Hi,
Julien Rouhaud a écrit :
On Wed, 27 Jan 2021 11:25:11 +0100
Denis Laxalde wrote:
Andres Freund a écrit :
b) when in binary upgrade mode / -b, error out on all wal writes in
sessions that don't explicitly set a session-level GUC to allow
writes.
It should be enough to a
Bruce Momjian a écrit :
On Thu, Aug 26, 2021 at 03:38:23PM +0200, Daniel Gustafsson wrote:
On 26 Aug 2021, at 15:09, Bruce Momjian wrote:
On Thu, Aug 26, 2021 at 03:24:33PM +0800, Julien Rouhaud wrote:
.. I still think that
changing bgworker_should_start_now() is a better option.
I am not sur
cc9e3d2 Mon Sep 17 00:00:00 2001
From: Denis Laxalde
Date: Mon, 23 Aug 2021 15:19:41 +0200
Subject: [PATCH] Disable bgworkers at servers start in pg_upgrade
Background workers may produce undesired activities (writes) on the old
cluster during upgrade which may corrupt the new cluster.
---
Julien Rouhaud a écrit :
On Wed, Jan 27, 2021 at 02:41:32PM +0100, Jehan-Guillaume de Rorthais wrote:
On Wed, 27 Jan 2021 11:25:11 +0100
Denis Laxalde wrote:
Andres Freund a écrit :
I wonder if we could
a) set default_transaction_read_only to true, and explicitly change it
in the
Hi,
Andres Freund a écrit :
> On 2021-01-21 16:23:58 +0100, Denis Laxalde wrote:
> > We found an issue in pg_upgrade on a cluster with a third-party
> > background worker. The upgrade goes fine, but the new cluster is then in
> > an inconsistent state. The background worke
rs to start at this
step.
Please find attached a patch implementing this.
Thanks for considering,
Denis
>From 31b1f31cd3a822d23ccd5883120a013891ade0f3 Mon Sep 17 00:00:00 2001
From: Denis Laxalde
Date: Wed, 20 Jan 2021 17:25:58 +0100
Subject: [PATCH] Disable background workers during servers s
20 matches
Mail list logo
