Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?

2020-11-17 Thread David Pirotte
On Fri, Nov 6, 2020 at 7:05 AM Ashutosh Bapat wrote: > +/* > + * Write MESSAGE to stream > + */ > +void > +logicalrep_write_message(StringInfo out, ReorderBufferTXN *txn, > XLogRecPtr lsn, > +bool transactional, const char *prefix, Size sz, > +const

Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?

2020-11-04 Thread David Pirotte
On Tue, Nov 3, 2020 at 7:19 AM Dave Cramer wrote: > David, > > On Thu, 24 Sep 2020 at 00:22, Michael Paquier wrote: > >> On Tue, Sep 08, 2020 at 12:18:23PM -0700, Andres Freund wrote: >> > A test verifying that a non-transactional message in later aborted >> > transaction is handled correctly wo

Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?

2020-07-29 Thread David Pirotte
On Wed, Jul 29, 2020 at 9:41 PM Dave Cramer wrote: > For logical replication there is no need to implement this, but others are > using the pgoutput plugin for Change Data Capture. The reason they are > using pgoutput is because it is guaranteed to be available as it is in core > postgres. > > Im