Re: Note new NULLS NOT DISTINCT on unique index tutorial page

2023-04-19 Thread David Gilman
gt; > On Thu, 13 Apr 2023 at 02:40, David Gilman wrote: > > The SQL Language part of the docs has a brief page on unique indexes. > > It doesn't mention the new NULLS NOT DISTINCT functionality on unique > > indexes and this is a good place to mention it, as it already warns

Note new NULLS NOT DISTINCT on unique index tutorial page

2023-04-12 Thread David Gilman
The SQL Language part of the docs has a brief page on unique indexes. It doesn't mention the new NULLS NOT DISTINCT functionality on unique indexes and this is a good place to mention it, as it already warns the user about the old/default behavior. -- David Gilman :DG&

Re: Warn when parallel restoring a custom dump without data offsets

2020-07-07 Thread David Gilman
by the tests no longer require it. I've attached the updated patch set. Note that this still shouldn't be merged because of Justin's bug report in 20200706050129.gw4...@telsasoft.com which is unrelated to this change but will leave you with flaky CI u

Re: Warn when parallel restoring a custom dump without data offsets

2020-05-27 Thread David Gilman
I've attached the latest patches after further review from Justin Pryzby. -- David Gilman :DG< https://gilslotd.com >From 90e06cbb724f6f6a244dfc69f3d59ca2e7d29c01 Mon Sep 17 00:00:00 2001 From: David Gilman Date: Wed, 20 May 2020 22:49:28 -0400 Subject: [PATCH 1/4] Scan all TOCs whe

Re: Warn when parallel restoring a custom dump without data offsets

2020-05-25 Thread David Gilman
The earlier patches weren't applying because I had "git config diff.noprefix true" set globally and that was messing up the git format-patch output. On Mon, May 25, 2020 at 01:54:29PM -0500, David Gilman wrote: > And I misunderstood how bad it was. I thought it was reading littl

Re: Warn when parallel restoring a custom dump without data offsets

2020-05-25 Thread David Gilman
Run code seems to support piping in a cross-platform way. I am not a Perl master though and after spending an evening trying to get it to work I went with this approach. If you can put me in touch with anyone to help me out here I'd appreciate it. -- David Gilman :DG< https://gilslotd.com &g

Re: Warn when parallel restoring a custom dump without data offsets

2020-05-23 Thread David Gilman
I've rounded this patch out with a test and I've set up the commitfest website for this thread. The latest patches are attached and I think they are ready for review. On Wed, May 20, 2020 at 11:05 PM David Gilman wrote: > > I did some more digging. To keep everyone on the sam

Re: Warn when parallel restoring a custom dump without data offsets

2020-05-20 Thread David Gilman
allelism, just not as much.) > No idea if this is going to be worth the trouble, but it probably > is worth looking into. > > regards, tom lane -- David Gilman :DG< 0001-pg_restore-fix-v2.patch Description: Binary data

Re: Warn when parallel restoring a custom dump without data offsets

2020-05-20 Thread David Gilman
hy my gut instinct was to warn instead of fail. > If it *is* seekable, could we > make _PrintTocData rewind if it gets to EOF using ftello(SEEK_SET, 0) > and re-scan again from the beginning? Would you want to try that ? I will try this and report back. I will also see if I can get an strace. -- David Gilman :DG<

Warn when parallel restoring a custom dump without data offsets

2020-05-16 Thread David Gilman
If pg_dump can't seek on its output stream when writing a dump in the custom archive format (possibly because you piped its stdout to a file) it can't update that file with data offsets. These files will often break parallel restoration. Warn when the user is doing pg_restore on such a file to give