> On Aug 8, 2018, at 2:57 PM, Simon Muller wrote:
>
> If there's a merge conflict against master, then it'd be good for an
> updated patch to be posted.
>
> Thanks!
>
> Stephen
>
> Attached is an updated patch that should directly apply against current
> master.
>
> --
> Simon Muller
>
>
> On Aug 2, 2018, at 3:30 PM, Simon Muller wrote:
>
> Sure, thanks both for the feedback. Attached is a patch with the error kept
> as ERRCODE_FEATURE_NOT_SUPPORTED.
>
I was able to apply the patch (after resolving a merge conflict which was
expected given an update in master). All looks go
> On Aug 2, 2018, at 8:11 AM, Daniel Verite wrote:
>
> That makes sense, thanks for elaborating, although there are also
> a fair number of ERRCODE_FEATURE_NOT_SUPPORTED in copy.c
> that are raised on forbidden/nonsensical combination of features,
> so the consistency argument could work both w
n ERRCODE_FEATURE_NOT_SUPPORTED and I might also
suggest the message read "COPY HEADER not available in BINARY mode", although
I'm pretty agnostic on the latter.
Regards,
-Cynthia Shang
> On Jul 25, 2018, at 6:09 PM, Simon Muller wrote:
>
> I've incorporated both your suggestions and included the patch you provided
> in the attached patch. Hope it's as expected.
> --
> Simon Muller
>
>
Reviewed and retested. Changing status to Ready for Committer.
On Wed, Jul 25, 2018 at 1:24 PM, Cynthia Shang
wrote:
> With regards to #2, the copy.source tests are for things requiring
> replacement when running the tests. Given that these copy tests do not, I
> have moved the current last set of copy tests to the copy2.sql file and have
>
to stdout with (format text, header true);As for the matching check of the header in the discussion of this patch, I feel that is a separate patch that can be added later since it would affect the general functionality of the copy command, not just the ability to have a text header.
move-copy-tests-v1.patch
Description: Binary data
Best,- Cynthia Shang
