Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

2018-08-06 Thread Curt Tilmes
On Thu, Jul 19, 2018 at 5:39 AM Heikki Linnakangas wrote: > Handy feature! > > On 01/03/18 20:40, Curt Tilmes wrote: > > On Thu, Mar 1, 2018 at 1:13 PM, Andres Freund > wrote: > >> And within the directory which service file wins will be decided by > >> files

Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

2018-07-05 Thread Curt Tilmes
On Mon, Jun 18, 2018 at 12:17 PM Arthur Zakirov wrote: > I think when some error occured in searchServiceFileDirectory() then the > error "definition of service \"%s\" not found" will be raised, because > group_found is false. It may confuse as it hides a real error. For > example, if permission i

Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

2018-03-05 Thread Curt Tilmes
On Mon, Mar 5, 2018 at 7:45 AM, Andreas 'ads' Scherbaum wrote: > On Thu, Mar 1, 2018 at 7:40 PM, Curt Tilmes wrote: >> On Thu, Mar 1, 2018 at 1:13 PM, Andres Freund wrote: > Looked over this patch and found that you limit the directory entries to > files only. >

Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

2018-03-01 Thread Curt Tilmes
On Thu, Mar 1, 2018 at 1:13 PM, Andres Freund wrote: > And within the directory which service file wins will be decided by > filesystem internals. That makes me a bit uncomfortable, this very well > might not be stable. I think it might not be terrible idea to sort the > directory and process alp

Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

2018-03-01 Thread Curt Tilmes
On Thu, Mar 1, 2018 at 11:36 AM, Curt Tilmes wrote: > Do you have any specific suggestions? Would it help if I separated > the new code into its own subroutine? I broke the new directory search out into its own subroutine, so even less impact on existing code. >> In my experien

Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

2018-03-01 Thread Curt Tilmes
On Thu, Mar 1, 2018 at 3:53 AM, Andres Freund wrote: > > On 2018-01-12 09:53:51 -0500, Curt Tilmes wrote: > > The convention widely adopted for this type of thing is to allow > > multiple config files to be in a directory, usually the '.d' version of the > >

[PATCH] Find additional connection service files in pg_service.conf.d directory

2018-01-12 Thread Curt Tilmes
I love centralizing connection service definitions in /pg_service.conf, but for a large enterprise, sometimes we have multiple sets of connection service definitions independently managed. The convention widely adopted for this type of thing is to allow multiple config files to be in a directory,