Re: Allow root ownership of client certificate key

2022-03-01 Thread Chris Bandy
On 3/1/22 3:15 AM, Tom Lane wrote: > Stephen Frost writes: >> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>> I'd be more eager to do that if we had some field complaints >>> about it. Since we don't, my inclination is not to, but I'm >>> only -0.1 or so; anybody else want to vote? > >> This patch wa

Re: Lost logs with csvlog redirected to stderr under WIN32 service

2021-10-06 Thread Chris Bandy
On 10/6/21 12:10 AM, Michael Paquier wrote: > I have thought about various ways to > fix that, and finished with a solution where we handle csvlog first, > and fallback to stderr after so as there is only one code path for > stderr, as of the attached. This reduces a bit the confusion around > the

Re: [PATCH] Add schema and table names to partition error

2020-03-19 Thread Chris Bandy
On 3/18/20 11:46 PM, Amit Kapila wrote: > On Thu, Mar 19, 2020 at 3:55 AM Chris Bandy wrote: >> >> >> Sorry for these troubles. Attached are patches created using `git >> format-patch -n -v6` on master at 487e9861d0. >> > > No problem. I have extracte

Re: [PATCH] Add schema and table names to partition error

2020-03-18 Thread Chris Bandy
On 3/18/20 6:56 AM, Amit Kapila wrote: > On Thu, Mar 12, 2020 at 7:46 PM Amit Kapila wrote: >> >> On Wed, Mar 11, 2020 at 8:51 PM Chris Bandy wrote: >>> >>> On 3/11/20 6:29 AM, Amit Kapila wrote: >>>> >>>> I have tried with git am as we

Re: [PATCH] Add schema and table names to partition error

2020-03-11 Thread Chris Bandy
Amit, On 3/11/20 6:29 AM, Amit Kapila wrote: > On Tue, Mar 3, 2020 at 10:05 AM Chris Bandy wrote: >> >> On 3/1/20 10:09 PM, Amit Langote wrote: >>> Hi Chris, >>> >>> On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote: >>>> On 3/1/20 5:14 AM,

[PATCH] Add tests for integrity violation error fields

2020-03-06 Thread Chris Bandy
On 3/4/20 2:54 AM, Chris Bandy wrote: > I've also convinced myself that the number of integrity errors in the > entire codebase is manageable to test. If others think it is worthwhile, > I can spend some time over the next week to expand this test approach to > cover _all_ SQLSTAT

Re: [PATCH] Add object names to partition errors

2020-03-04 Thread Chris Bandy
On 3/3/20 11:18 PM, Chris Bandy wrote: > On 3/3/20 10:08 AM, Alvaro Herrera wrote: >> I don't suppose you mean to >> test that every single ereport() call that includes errtable() contains >> a TABLE NAME item. > > Correct. I intend only to test the few calls I&

Re: [PATCH] Add schema and table names to partition error

2020-03-03 Thread Chris Bandy
every error in SQLSTATE class 23 has one of these fields filled[1]. The errors in these patches are in that class but lacked any fields. [1] https://www.postgresql.org/docs/current/errcodes-appendix.html Thanks, Chris >From c6b39accf9f51f9c08a2fc62e848144776e23ffb Mon Sep 17 00:00:00 2001 Fr

Re: [PATCH] Add schema and table names to partition error

2020-03-02 Thread Chris Bandy
On 3/1/20 10:09 PM, Amit Langote wrote: Hi Chris, On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote: On 3/1/20 5:14 AM, Amit Kapila wrote: On Sun, Mar 1, 2020 at 10:10 AM Amit Langote wrote: There are couple more instances in src/backend/command/tablecmds.c where partition constraint is

Re: [PATCH] Documentation bug related to client authentication using TLS certificate

2020-03-02 Thread Chris Bandy
Hi, Cary. On 3/2/20 1:06 PM, Cary Huang wrote: Hi I found a document bug about client authentication using TLS certificate. When clientcert authentication is enabled in pg_hba.conf, libpq does not verify that the *common name*in certificate matches*database username*like it is described in t

Re: [PATCH] Add schema and table names to partition error

2020-03-01 Thread Chris Bandy
Thank you both for look at this! On 3/1/20 5:14 AM, Amit Kapila wrote: On Sun, Mar 1, 2020 at 10:10 AM Amit Langote wrote: Hi Chris, On Sun, Mar 1, 2020 at 4:34 AM Chris Bandy wrote: Hello, I'm writing telemetry data into a table partitioned by time. When there is no partition

[PATCH] Add schema and table names to partition error

2020-02-29 Thread Chris Bandy
for my use case: - Insert data into a partitioned table for which there is no partition. - Insert data directly into an incorrect partition. Thanks, Chris >From 8261b366c49b2d04baeb882d39dfa626b9315889 Mon Sep 17 00:00:00 2001 From: Chris Bandy Date: Sat, 29 Feb 2020 12:47:56 -0600 Subject: [PATCH] Ad

Re: Unexpected casts while using date_trunc()

2018-05-25 Thread Chris Bandy
On 5/24/18 2:31 PM, Tom Lane wrote: Andrew Gierth writes: "Tom" == Tom Lane writes: Tom> Yeah. There are two relevant variants of date_trunc(): [...] Tom> So we probably ought to change the docs here. There's also the option of adding an explicit function date_trunc(text,date) return

Unexpected casts while using date_trunc()

2018-05-24 Thread Chris Bandy
I have an application generating the following query on a DATE column in PostgreSQL 10.1: > SELECT TO_CHAR(DATE_TRUNC('month', jobs.active_until), '-MM') > FROM jobs > GROUP BY DATE_TRUNC('month', jobs.active_until) > LIMIT 500 I wanted to support it with an expression index, but was surpri