Re: Patch for SortSupport implementation on inet/cdir

2019-08-01 Thread Brandur Leach
Thanks Peter. V6 is pretty uncontroversial by me — the new conditional ladder broken cleanly into cases of (1) all subnet, (2) network/subnet mix, and (3) all network is a little more verbose, but all in all makes things easier to reason about. > Do you have any final input on the testing, Brandur

Re: Patch for SortSupport implementation on inet/cdir

2019-07-29 Thread Brandur Leach
And a slightly amended version of the last patch with a bug fixed where IPv4 abbreviated keys were were not being initialized correctly on big-endian machines. v5-0001-SortSupport-for-inet-cidr-types.patch Description: Binary data

Re: Patch for SortSupport implementation on inet/cdir

2019-07-28 Thread Brandur Leach
Thanks the follow ups on this one Edmund/Peter! I've attached a new V4 variant of the patch based on Peter's V3, mostly containing comment amendments and a few other minor stylistic fixes. > An interesting thing about sorting IPv4 inets on 64-bit machines is that when the inets are the same, the

Re: Patch for SortSupport implementation on inet/cdir

2019-02-08 Thread Brandur Leach
Attached a V2 patch: identical to V1 except rebased and with a new OID selected. SortSupport-for-inet-cidr-types-v2.patch Description: Binary data

Patch for SortSupport implementation on inet/cdir

2019-02-08 Thread Brandur Leach
Hi list, I've attached a patch that implements SortSupport for the inet/cidr types. It has the effect of typically reducing the time taken to sort these types by ~50-60% (as measured by `SELECT COUNT(DISTINCT ...)` which will carry over to common operations like index creation, `ORDER BY`, and `DI