On Tue, 17 Dec 2024 at 10:43, vignesh C wrote:
> > If I understand your suggestion correctly I think this will break the
> > "--exclude-schema" option of pg_dump. That change will dump all
> > mappings between publications and schemas for publications which are
> > dumped.
> >
> > That solves the
On Mon, 16 Dec 2024 at 12:05, vignesh C wrote:
> I prefer the other approach to remove both the checks in
> getPublicationTables() and getPublicationNamespaces() which also makes
> it consistent with the other case that Amit mentioned at [1].
If I understand your suggestion correctly I think this
On Tue, 15 Oct 2024 at 11:50, jian he wrote:
> based on above information, i am still confused with
> cleanup_in_progress_typentries, in_progress_list_len
> is there any simple sql example to demo
> cleanup_in_progress_typentries, in_progress_list_len> 0.
AFAIK to reproduce cases when `in_progr
On Tue, 15 Oct 2024 at 10:09, Alexander Korotkov wrote:
> > /* Call check_delete_rel_type_cache() if we actually cleared something
> > */
> > if (hadTupDescOrOpclass)
> > delete_rel_type_cache_if_needed(typentry);
> >
> > /*
> > * Call check_delete_rel_type_cache(
Hi all,
On Fri, 13 Sept 2024 at 01:38, Alexander Korotkov wrote:
>
> 0001 - adds comment about concurrent invalidation handling
> 0002 - revised c14d4acb8. Now we track type oids, whose
> TypeCacheEntry's filing is in-progress. Add entry to
> RelIdToTypeIdCacheHash at the end of lookup_type_cac
On Wed, 31 Jul 2024 at 15:42, Daniel Verite wrote:
>
> Sutou Kouhei wrote:
>
> > BTW, here is a diff after pgindent:
>
> PFA a v5 with the cosmetic changes applied.
Thank you Daniel for working on it. I've tested the patch and it seems
it works as expected.
I have a couple of minor comme
a patch to remove checking MINIMUM_VERSION_FOR_PG_WAL.
--
Artur
From cc8e636ad47b9dcc8779934e58f351ca43067b05 Mon Sep 17 00:00:00 2001
From: Artur Zakirov
Date: Fri, 2 Feb 2024 10:06:42 +0100
Subject: [PATCH v2] Fix checking MINIMUM_VERSION_FOR_WAL_SUMMARIES for
creating pg_wal/summaries directo
Shouldn't it be ">=". Otherwise the function
will create "/summaries" only for older PostgreSQL versions.
I've attached a patch to fix it in case this is a typo.
--
Artur
From 24227fdcad1fbdb67e38537bc1d70f65d9bdab05 Mon Sep 17 00:00:00 2001
From: Artur Zakir
On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela wrote:
> Anyway, the v1 patch fixes only the expression eval.
The patch looks good to me.
It seems that initially the code looked similar to your patch. See the
commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755. Then the variables
were moved to foreach
On Fri, Sep 24, 2021 at 2:39 PM Jean-Christophe Arnu wrote:
> Here's a new patch file taking your comments into account.
Nice catch! The patch looks good to me.
Can you also add a more general test case:
=# SELECT $$'' '1' '2'$$::tsvector;
ERROR: syntax error in tsvector: "'' '1' '2'"
LINE 1: S
On Wed, Sep 15, 2021 at 2:57 AM Tom Lane wrote:
> Hearing no comments, I pushed that.
Thank you!
> > I'm inclined to think we should flat-out reject LISTEN in any process
> > that is not attached to a frontend, at least until somebody takes the
> > trouble to add infrastructure that would let it
Thank you Tom for your review.
On Mon, Sep 6, 2021 at 9:27 PM Tom Lane wrote:
>
> Artur Zakirov writes:
> > I attached the patch which fixes it in a different way. It calls
> > SignalBackends() in AtCommit_Notify(). It is possible to call
> > SignalB
to head if there are no
listening backends. But there will be a problem if there is a backend which
is listening but it doesn't process incoming notifications and doesn't update
its queue position. In that case asyncQueueAdvanceTail() is able to advance
tail only up to that backend's
Hello,
On Sat, Apr 11, 2020 at 6:20 PM Pavel Stehule wrote:
> Main motivation for this patch is working with psql for writing and editing
> queries, and browsing result in second terminal with pspg or any other
> similar tool (tail, ...). The advantage of this setup is possibility to see
> sql
Hello,
On Thu, Jul 2, 2020 at 8:23 PM Pavel Borisov wrote:
>
> ср, 1 июл. 2020 г. в 23:16, Tom Lane :
>>
>> Pavel Borisov writes:
>> > Below is my variant how to patch Gin-Gist weights issue:
>>
>> I looked at this patch, but I'm unimpressed, because it's buggy.
>
>
> Thank you, i'd noticed and
On 3/30/2020 9:30 PM, John Naylor wrote:
I attempted this in the attached v7. There are 4 new functions for
truncating timestamptz on an interval -- with and without origin, and
with and without time zone.
Thank you for new version of the patch.
I'm not sure that I fully understand the 'origin
Hello David,
On 3/25/2020 2:08 AM, David Steele wrote:
On 12/17/19 3:10 AM, Arthur Zakirov wrote:
I attached new version of the patch. It still uses
pg_identify_object(), I'm not sure about other ways to build
identities yet.
This patch applies and builds but fails regression tests on Linu
Hello,
On 3/13/2020 4:13 PM, John Naylor wrote:
I've put off adding documentation on the origin piece pending comments
about the approach.
I haven't thought seriously about timezone yet, but hopefully it's
just work and nothing to think too hard about.
Thank you for the patch. I looked it and
On 3/12/2020 11:52 AM, Tom Lane wrote:
Artur Zakirov writes:
I'm not familiar with the patch itself. But I think there is just a lack
of the comma here, after ", /tmp" :-)
[ blink... ] There definitely is a comma there in the version of the
patch that's in the Fedora
Hello,
On 3/12/2020 4:44 AM, Tom Lane wrote:
Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes:
I'm getting build error while building latest snapshot. Any idea why? Please
note that I'm adding this patch to the tarball:
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/postg
Hello,
On Sat, Jan 11, 2020 at 2:12 AM Fujii Masao wrote:
> > +
> > + pg_file_sync fsyncs the specified file or directory
> > + named by filename. Returns true on success,
> > + an error is thrown otherwise (e.g., the specified file is not present).
> > +
> > What's the point of having a fu
If Anastasia doesn't mind I'd like to send new version of the patch.
On 2019/11/28 12:29, Artur Zakirov wrote:
On 2019/11/27 13:22, Michael Paquier wrote:
Yeah, the actual take is if we want to make the frontend code more
complicated with a large set of SQL queries to check that e
On 2019/11/27 13:22, Michael Paquier wrote:
On Wed, Nov 27, 2019 at 11:35:14AM +0900, Artur Zakirov wrote:
Other approach is similar to Anastasia's patch, which is scanning pg_proc,
pg_class, pg_attribute and others to get modified ACL's and compare it with
initial ACL from pg_init_p
Thank you for reviews!
On 2019/11/21 17:53, Michael Paquier wrote:
On Fri, Nov 15, 2019 at 11:30:02AM +0300, Grigory Smolkin wrote:
On 11/9/19 5:26 AM, Michael Paquier wrote:
Another question I have: do we need to care more about other extra
ACLs applied to other object types? For example a s
On Sun, Nov 3, 2019 at 5:48 AM Tom Lane wrote:
>
> Arthur Zakirov writes:
> > On 2019/10/13 10:26, Tomas Vondra wrote:
> >> So I think we need some sort of cross-check here. We certainly need to
> >> make NISortDictionary() check the affix value is within AffixData
> >> bounds, and error out when
25 matches
Mail list logo
