and to determine uniqueness */
2) comments where closing */ is on the last comment line. For example:
file 'crypt-blowfish.c'
before:
/* This has to be bug-compatible with the original implementation, so
* only encode 23 of the 24 bytes. :-) */
after:
/*
* This has to be bug-compatible with the original implementation, so
* only encode 23 of the 24 bytes. :-) */
Best regards,
Arseniy Mukhin
On Wed, Jun 18, 2025 at 2:39 PM Andrey Borodin wrote:
>
>
>
> > On 18 Jun 2025, at 11:33, Arseniy Mukhin
> > wrote:
> >
> > Interesting, I used btree check as reference when started
> > writing brin check, and in btree check there 53
> >
On Mon, Jun 9, 2025 at 1:16 AM Tomas Vondra wrote:
>
> On 6/8/25 14:39, Arseniy Mukhin wrote:
> > Hi,
> >
> > Here is a new version.
> >
> > TAP tests were added. Tried to reproduce more or less every violation.
> > I don't include 2 tests where
messages:
in v8-0002-amcheck-Fix-checks-of-entry-order-for-GIN-indexes.patch
- parent key is creator
- as the core incorrectly expected
and 'Arseniy Mikhin' in some patches.
Best regards,
Arseniy Mukhin
e are some thought about patches.
>
Hi Andrey! Thank you for the review.
>
> > On 10 Jun 2025, at 13:18, Arseniy Mukhin
> > wrote:
> > <0001-amcheck-Add-gin_index_check-on-a-multicolumn-index.patch>
>
> The test seems harmless and nice to have. I understand t
On Mon, Jun 9, 2025 at 7:37 PM Arseniy Mukhin
wrote:
>
> On Mon, Jun 9, 2025 at 6:34 PM Tomas Vondra wrote:
> >
> > On 6/9/25 00:14, Tomas Vondra wrote:
> > > ...
> > >
> > > I propose to split it like this, into three parts, each addressing a
&g
ill needs the commit
> message, though.
The way it splitted seems reasonable to me. Intertwined issues are
grouped together, and patches are more or less independent.
Also the test for 'posting tree parent_key check' that was added last
started failing locally. Don't know what cha
found and fixed.
Also ci compiler warnings were fixed.
Best regards,
Arseniy Mukhin
From 918cc8b07eb19f74646949cc302d6ed67f1bc920 Mon Sep 17 00:00:00 2001
From: Arseniy Mukhin
Date: Wed, 16 Apr 2025 11:26:45 +0300
Subject: [PATCH v2 1/2] brin refactoring
---
src/backend/access/brin/brin_tup
On Mon, May 26, 2025 at 7:28 PM Arseniy Mukhin
wrote:
> On Mon, May 26, 2025 at 1:27 PM Tomas Vondra wrote:
> > Also, I've noticed that the TAP test passes even with some (most) of the
> > verify_gin.c changes reverted. See the 0002 patch - this does not break
> > the
Hello Tomas,
On Mon, May 26, 2025 at 1:27 PM Tomas Vondra wrote:
>
> Hello Arseniy,
>
> I finally got time to look at this more closely, and do some testing.
Thank you for looking into this.
> Are there any cases when the current code incorrectly reports corruption
> for a valid index? So far
stack->parenttup = gin_refind_parent(rel, stack->parentblk,
stack->blkno, strategy);
I think we can remove gin_refind_parent() and do ereport right away here.
The same logic as with 3). AFAIK it's impossible to have a child item
,
Arseniy Mukhin
diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c
index a7b7b5996e3..5643c423627 100644
--- a/src/backend/access/gin/gininsert.c
+++ b/src/backend/access/gin/gininsert.c
@@ -218,7 +218,8 @@ addItemPointersToLeafTuple(GinState *ginstate
tem.
So it seems that normally all items in additionalEntries have a
curItem larger than or equal to minItem.
It seems the correct first sentence would be:
"Normally, none of the items in additionalEntries can have a curItem
LESS than minItem"
Best regards,
Arseniy Mukhin
eviewed and more or less finalized)
3) pg_amcheck integration
Big thanks to Tomas Vondra for the first patch idea and initial review.
[1]
https://www.postgresql.org/message-id/45AC9B0A-2B45-40EE-B08F-BDCF5739D1E1%40yandex-team.ru
Best regards,
Arseniy Mukhin
From 7de60e8da824a97327a5c28ccd9d8a384
I tried Tomas's stress tests with applied patch and didn't have deadlocks.
Also there is a another way how issue can be reproduced:
apply deadlock-sleep.patch (it just adds 15 sec sleep in brin_doupdate
and few logs)
execute deadlock.sql
execute deadlock2.sql from another client (t
15 matches
Mail list logo
