2017-12-14 15:08 GMT+07:00 Michael Paquier :
>
> On Thu, Dec 14, 2017 at 2:49 PM, Justin Pryzby wrote:
> > On Thu, Dec 14, 2017 at 08:51:06AM +0700, Ali Akbar wrote:
> >> 2017-12-13 15:37 GMT+07:00 Amit Langote :
> >> Patch for adding check in pg_upgrade. Going
2017-12-13 15:37 GMT+07:00 Amit Langote :
> On 2017/12/13 15:59, Ali Akbar wrote:
> >
> > Thanks for the link to those thread.
> >
> > Judging from the discussion there, it will be a long way to prevent DROP
> > NOT NULL.
>
> Yeah, I remembered that discus
the end of the
> transaction, and usually you need to be careful about potential lock
> upgrades that could cause deadlocks. This patch looks wrong for both
> of those things.
Thanks. Judging from above, it's better that we continue the DROP NOT NULL
problem in another patch (and another thread)
Best Regards,
Ali Akbar
> For me, it's better to prevent that from happening. So, attempts to
> DROP NOT NULL on the child must be rejected. The attached patch does
> that.
I'm sorry. Accidentaly i "--color"-ed the patch format. Attached the
correct patch.
Best Regards,
Ali Akbar
dif
rade to check
for this problem before attempting to dump schema. In my case, because
the cluster has many databases, the error arise much late in the
process, it will be much better if pg_upgrade complains while
performing pre-checks.
Best Regards,
Ali Akbar
[1mdiff --git a/src/backend/catalog/pg
