Hi Dean,
Thanks for the patch!
I reviewed the patch and it looks good to me. I’ve run some tests, and
everything works as expected.
I have one minor thought:
On Sun, Mar 2, 2025 at 2:30 AM Dean Rasheed
wrote:
> On Thu, 14 Nov 2024 at 22:35, Dean Rasheed
> wrote:
> >
> > On Thu, 14 Nov 2024 a
Hi Amul,
On Thu, Feb 27, 2025 at 12:57 AM Amul Sul wrote:
> Attached is the rebased patch set against the latest master head,
> which also includes a *new* refactoring patch (0001). In this patch,
> I’ve re-added ATExecAlterChildConstr(), which is required for the main
> feature patch (0008) to
Hi Matheus,
On Mon, Mar 3, 2025 at 1:43 PM Matheus Alcantara
wrote:
> On Mon, Mar 3, 2025 at 4:16 PM Matheus Alcantara
> wrote:
> >
> > Hi Alex,
> >
> > The code comments and the commit messages help a lot when reviewing!
> Thanks for
> > the new version.
> >
> > The code LGTM and check-world i
Hello hackers,
While reviewing Mark Dilger’s patch series "Index AM API cleanup" [1],
I noticed some unexpected plan diffs when running the xtree and treeb
test modules. Specifically, an additional Sort node appears on top of
an Index Only Scan, even when the index key and sort key are the same.
F
Hello hackers,
On Thu, Feb 27, 2025 at 9:46 AM Alexandra Wang
wrote:
> Summary of changes:
>
> v8-0001 through v8-0005:
> Refactoring and preparatory steps for the actual implementation.
>
> v8-0006 (Implement read-only dot notation for JSONB):
> I removed the vars field (i
Hello hackers,
I’ve fixed the compilation failure for hstore and updated the patches.
In this version, I’ve further cleaned up the code and added more
comments. I hope this helps!
Summary of changes:
v8-0001 through v8-0005:
Refactoring and preparatory steps for the actual implementation.
v8-00
Hi,
On Wed, Feb 5, 2025 at 1:20 AM Alexandra Wang
wrote:
> I attached a minimized version of Nikita’s patch (v7):
>
> - The first three patches are refactoring steps that could be squashed
> if preferred.
> - The last two patches implement dot notation and wildcard access,
&
for dot notation and wildcard access.
- Dropped the two patches in v6 that enabled non-parenthesized column
references (per Nikita’s suggestion, this will need its own separate
discussion).
For reference, I’ve also attached the operator-like function approach
in 0001-WIP-Operator-approach-JSONB-
Hi,
On Tue, Nov 19, 2024 at 6:06 PM Nikita Glukhov wrote:
>
> Hi, hackers.
>
> I have implemented dot notation for jsonb using type subscripting back
> in April 2023, but failed post it because I left Postgres Professional
> company soon after and have not worked anywhere since, not even had
> an
On Fri, Oct 4, 2024 at 7:33 AM jian he wrote:
>
> On Thu, Sep 26, 2024 at 11:45 PM Alexandra Wang
> wrote:
> >
> > Hi,
> >
> > I didn’t run pgindent earlier, so here’s the updated version with the
> > correct indentation. Hope this helps!
> >
>
&
Hi,
I didn’t run pgindent earlier, so here’s the updated version with the
correct indentation. Hope this helps!
Best,
Alex
v4-0001-Add-JSON-JSONB-simplified-accessor.patch
Description: Binary data
Hi Peter,
Thank you so much for helping!
On Mon, Sep 16, 2024 at 12:44 PM Peter Eisentraut wrote:
>
> On 29.08.24 18:33, Alexandra Wang wrote:
> > I’ve implemented the member and array accessors and attached two
> > alternative patches:
> >
> > 1. v1-
On Thu, Aug 22, 2024 at 11:28 AM Mark Dilger
wrote:
> > On Aug 22, 2024, at 1:36 AM, Alexandra Wang
> > wrote:
> > "make installcheck" for treeb is causing issues on my end. I can
> > investigate further if it’s not a problem for others.
>
> The test modu
1]
https://docs.oracle.com/en/database/oracle/oracle-database/21/adjsn/simple-dot-notation-access-to-json-data.html#GUID-7249417B-A337-4854-8040-192D5CEFD576
[2]
https://www.postgresql.org/message-id/8022e067-818b-45d3-8fab-6e0d94d03...@eisentraut.org
From 99ee1cbc45ebd76ce21881bda95933d8a5a104c6
Hi Mark,
On Wed, Aug 21, 2024 at 2:25 PM Mark Dilger
wrote:
>
>
> For validation purposes, the first patch creates shallow copies of hash and
> btree named "xash" and "xtree" and introduces some infrastructure to run the
> src/test/regress and src/test/isolation tests against them without needi
> On 2 July 2020, at 06:39, Daniel Gustafsson wrote:
> > On 10 Apr 2020, at 23:50, Alexandra Wang wrote:
>
> > On Fri, Apr 10, 2020 at 8:37 AM Ashutosh Bapat
> > mailto:ashutosh.ba...@2ndquadrant.com>>
> > wrote:
> > > for a multi-key value the ^
&g
> On 2 July 2020, at 06:39, Daniel Gustafsson wrote:
> > On 10 Apr 2020, at 23:50, Alexandra Wang wrote:
>
> > On Fri, Apr 10, 2020 at 8:37 AM Ashutosh Bapat <
ashutosh.ba...@2ndquadrant.com <mailto:ashutosh.ba...@2ndquadrant.com>>
wrote:
> > > for a mu
patch to also report the exact column
for the partition overlap errors.
From f7cf86fcf7c1a26895e68f357717244f776fe5cd Mon Sep 17 00:00:00 2001
From: Alexandra Wang
Date: Fri, 10 Apr 2020 13:51:53 -0700
Subject: [PATCH v2] Improve check new partition bound error position report
---
src/backe
On Fri, 10 Apr 2020 at 14:31, Amit Langote wrote:
> I agree with that. Tried that in the attached 0002, although trying
> to get the cursor to point to exactly the offending column seems a bit
> tough for partition overlap errors. The patch does allow to single
> out which one of the lower and u
On Wed, Apr 8, 2020 at 6:11 PM Michael Paquier wrote:
> Please note that you forgot to update the regression test output.
Yep thanks! Please see my previous email for the updated patch.
Forgot to run make installcheck. Here's the new version of the patch that
updated the test answer file.
From 9071918648412383e41976a01106257bd6a2539e Mon Sep 17 00:00:00 2001
From: Alexandra Wang
Date: Wed, 8 Apr 2020 16:07:28 -0700
Subject: [PATCH v2] Report error position in partition
7;2006-01-01').
Another option is to not pass the parser_errposition() argument at all
to ereport() in this function, since the query is relatively short and
the error message is already descriptive enough.
Alex and Ashwin
From b1aedddaf7ae0f609910ff82af136d93c0132c2e Mon Sep 17 00:00:
Hi Peter,
On Fri, Nov 22, 2019 at 6:22 PM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> Here is another patch set that implements the temporary slot use on the
> walreceiver side, essentially mirroring what pg_basebackup already does.
>
> I think this patch set might be useful on
Hi Ashutosh,
Sorry I indeed missed your question, thanks for the reminder!
On Wed, Sep 25, 2019 at 4:10 AM Ashutosh Sharma
wrote:
> > Further, the UPDATE operation on zedstore table is very slow. I think
> > that's because in case of zedstore table we have to update all the
> > btree data struc
On Tue, Sep 17, 2019 at 4:15 AM Ashutosh Sharma
wrote:
> create table t1(a int, b int) using zedstore;
> insert into t1 select i, i+10 from generate_series(1, 100) i;
> postgres=# update t1 set b = 200;
> server closed the connection unexpectedly
> This probably means the server terminated ab
On Tue, Aug 27, 2019 at 12:03 AM Ashutosh Sharma
wrote:
> My point is, once we find the leaf page containing the given tid, we go
> through each item in the page until we find the data corresponding to the
> given tid which means we kind of perform a sequential scan at the page
> level. I'm refer
On Sun, Aug 18, 2019 at 12:35 PM Justin Pryzby wrote:
>
> . I was missing a way to check for compression ratio;
Here are the ways to check compression ratio for zedstore:
Table level:
select sum(uncompressedsz::numeric) / sum(totalsz) as compratio from
pg_zs_btree_pages();
Per column level:
Current sequence of operations for drop database (dropdb())
1. Start Transaction
2. Make catalog changes
3. Drop database buffers
4. Forget database fsync requests
5. Checkpoint
6. Delete database directory
7. Commit Transaction
Problem
This sequence is unsafe from couple of fronts. Like if drop d
28 matches
Mail list logo
