Re: [PATCH] Add regress test for pg_read_all_stats role

2018-08-24 Thread Alexandra Ryzhevich
On Thu, Aug 23, 2018 at 9:12 AM Michael Paquier wrote: > On Tue, Aug 21, 2018 at 05:48:49PM +0100, Alexandra Ryzhevich wrote: > > Just to check if changes broke something. I haven't find these checks in > > other regress tests. In other way we get only positive tests. If th

Re: [PATCH] Add regress test for pg_read_all_stats role

2018-08-21 Thread Alexandra Ryzhevich
; session_preload_libraries or dynamic_preload_libraries. Still that's > pretty restrictive, and would only test one out of the three code paths > available. > Changed to use session_preload_libraries. Alexandra From 9d16cdb419b8cea547a40bf4f188b0bd744de310 Mon Sep 17 00:00:00 2

Creating extensions for non-superusers

2018-08-10 Thread Alexandra Ryzhevich
which does not need superuser privilege to create any extensions. However we are not sure if it's the best approach. Are there any other ideas, proposals or feedback? Is this something you would consider adding to the next major release? Best regards, Alexandra Ryzhevich

Re: [PATCH] Add regress test for pg_read_all_stats role

2018-08-03 Thread Alexandra Ryzhevich
Thank you for pointing to some problems of the patch. I've attached a modified version below. On Thu, Aug 2, 2018 at 8:38 PM Michael Paquier wrote: > On Thu, Aug 02, 2018 at 06:25:14PM +0100, Alexandra Ryzhevich wrote: > > I have noticed that there is no regression tests for defa

[PATCH] Add regress test for pg_read_all_stats role

2018-08-02 Thread Alexandra Ryzhevich
without CREATE permission on it, and to read "query" column of pg_stat_activity table without SUPERUSER privilege. Best regards, Alexandra Ryzhevich From 3cf3d1b9e252902e0e8f05436c703d1ec2d90125 Mon Sep 17 00:00:00 2001 From: Alexandra Ryzhevich Date: Thu, 2 Aug 2018 18:06:13 +0100 Subject: