Re: Adding error messages to a few slash commands

Thanks Pavel, done now https://commitfest.postgresql.org/patch/5699/ Thanks On Mon, Apr 14, 2025 at 4:27 AM Pavel Luzanov wrote: > > On 13.04.2025 19:40, Abhishek Chanda wrote: > > Thanks for the feedback, attached an updated patch that changes most > of those "Did not fin

Re: Adding error messages to a few slash commands

this loop for now. I will follow up once the merge window opens again. Thanks On Sun, Apr 13, 2025 at 1:47 AM Pavel Luzanov wrote: > > On 13.04.2025 08:29, Tom Lane wrote: > > Abhishek Chanda writes: > > Currently, some slash commands in psql return an error saying "D

Re: Adding error messages to a few slash commands

ot;foo". postgres => \df foo Did not find any function named "foo". postgres => \du foo Did not find any role named "foo". Thanks On Sat, Apr 12, 2025 at 10:43 PM Abhishek Chanda wrote: > > Hello hackers, > > Currently, some slash commands in psql return an

Adding error messages to a few slash commands

l patch to wait for feedback, happy to do that if this patch is acceptable. I did not add any tests yet because the existing ones did not seem to have any, happy to add tests if needed. Also, I know that we are in a feature freeze, is such a change acceptable now? Thanks -- Thanks and regards Abhis

Re: Adding support for SSLKEYLOGFILE in the frontend

utoconf (I > had missed git adding the configure file..) and Windows where the backslashes > weren't escaped properly. It also removes the environment variable and has > documentation touchups. > > -- > Daniel Gustafsson > -- Thanks and regards Abhishek Chanda

Re: Adding support for SSLKEYLOGFILE in the frontend

Attached a v6 with O_NOFOLLOW removed, I noticed that it failed on windows. Please let me know if I should do this in any other way that is portable across platforms. Thanks On Thu, Feb 27, 2025 at 11:39 PM Abhishek Chanda wrote: > > Thanks for the review, Daniel. Please find v5 of this

Re: Adding support for SSLKEYLOGFILE in the frontend

: > > > On 20 Feb 2025, at 04:36, Abhishek Chanda wrote: > > Please find attached a new version of this patch. I rebased on master, > > added better error reporting and skipped the permissions check on > > windows. Please let me know if this needs any changes. I tested this >

Re: Adding support for SSLKEYLOGFILE in the frontend

Abhishek Chanda wrote: > > Thanks, Daniel. Here is an updated patch with all previous changes, > added a simple connection test and another check to make sure file > mode is correct, and the env var fix. Please let me know if anything > needs to be changed. I tested this loca

Re: Adding support for SSLKEYLOGFILE in the frontend

manually. Thanks Abhishek On Fri, Jan 10, 2025 at 9:29 AM Daniel Gustafsson wrote: > > > On 10 Jan 2025, at 04:59, Abhishek Chanda wrote: > > Thanks for the new version. > > + {"sslkeylogfile", "SSLKEYLOGFILE", > The env var should be PGSSLKEYLOGFILE

Re: Adding support for SSLKEYLOGFILE in the frontend

ter and not via an environment variable. > > Making it a connection parameter also keeps us from colliding with any > other linked libraries' use of SSLKEYLOGFILE (I'm thinking about > libcurl at the moment, but I think maybe NSS used it too?). > > --Jacob -- Thanks and reg

Adding support for SSLKEYLOGFILE in the frontend

sts for the surrounding functions. 2. Should I use perror to report error here? I did not want to use libpq_append_conn_error because this is not a connection related error. Please let me know if I can clarify anything. -- Thanks and regards Abhishek Chanda 0001-Add-support-for-dumping-SSL-keylog-to-a