Re: [BUG] Remove self joins causes 'variable not found in subplan target lists' error

On Wed, Aug 27, 2025 at 2:26 AM Tom Lane wrote: > Richard Guo writes: > > Instead of repeatedly calling make_pathkeys_for_sortclauses to detect > > redundant expressions, I'm wondering if we could introduce a function > > that detects whether a given expression is known equal to a constant > > by

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

On Tue, Aug 26, 2025 at 2:32 AM shveta malik wrote: > > On Tue, Aug 26, 2025 at 12:54 AM Masahiko Sawada > wrote: > > > > I've attached the updated patch that incorporated the comments and is > > rebased to the current HEAD. > > > > Thanks for the patch, please find a few comments concerning LOG

Re: pg_restore --no-policies should not restore policies' comment

On Tue, Aug 26, 2025 at 7:43 PM Fujii Masao wrote: > > > > > summary of attached patch: > > Thanks for the patches! > > > 01: make pg_restore not restore comments if comments associated > > objects are excluded. > > > TODO: need perl tests > > How about adding tests for pg_restore --no-policies in

Re: Adding REPACK [concurrently]

Mihail Nikalayeu wrote: > Hello, Antonin! > > Antonin Houska : > > > > Where exactly should HeapTupleSatisfiesDirty() conclude that the tuple is > > visible? TransactionIdIsCurrentTransactionId() will not do w/o the > > modifications that you proposed earlier [1] and TransactionIdIsInProgress()

Re: SQL:2023 JSON simplified accessor support

On Tue, Aug 26, 2025 at 11:53 AM Alexandra Wang wrote: > > Hi Jian, > > I’ve attached v14, which includes only indentation and comment changes > from v13. > hi. still reviewing v14-0001 to v14-0005. I am confused by the comments in jsonb_subscript_transform "" * (b) jsonb_subscript_make_jso

RE: Conflict detection for update_deleted in logical replication

On Tuesday, August 26, 2025 2:45 PM Amit Kapila wrote: > On Mon, Aug 25, 2025 at 5:05 PM Amit Kapila > wrote: > > > > A few comments on 0001: > > > > Some more comments: Thanks for the comments! > 1. > + /* > + * Return false if the leader apply worker has stopped retaining > + * information f

Re: Fixes a trivial bug in dumped parse/query/plan trees

Retry again to attach the path file. Chao Li (Evan) - Highgo Software Co., Ltd. https://www.highgo.com/ Chao Li 于2025年8月27日周三 09:35写道： > > > On Aug 25, 2025, at 16:57, Chao Li wrote: > > > Resending the patch file. > > -- > Chao Li (Evan) > HighGo Software Co., Ltd. > http

Re: Fixes a trivial bug in dumped parse/query/plan trees

On Aug 25, 2025, at 16:57, Chao Li wrote:Resending the patch file. --Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/ v1-0001-Fixes-a-trivial-bug-in-dumped-parse-query-plan-tr.patch Description: Binary data

Re: Why CI doesn't run?

On Aug 27, 2025, at 09:23, David G. Johnston wrote:On Tue, Aug 26, 2025 at 6:05 PM Chao Li wrote:Anyone has an idea why CI has not yet run against https://commitfest.postgresql.org/patch/5996/?Mail server didn't recognize your patch as an attachment (I can't answer why tha

Re: Why CI doesn't run?

On Tue, Aug 26, 2025 at 6:05 PM Chao Li wrote: > > Anyone has an idea why CI has not yet run against > https://commitfest.postgresql.org/patch/5996/? > > Mail server didn't recognize your patch as an attachment (I can't answer why that may be. I do see it in GMail though). You will note there i

Re: Making jsonb_agg() faster

>> On Aug 23, 2025, at 03:11, Tom Lane wrote: >> >> >> v2-0001 takes care of that, and also adopts your suggestion in [1] >> about not using two calls of pushJsonbValueScalar where one would do. >> I also did a bit more micro-optimization in appendKey, appendValue, >> appendElement to avoid red

Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)

On Sat, 2 Aug 2025 at 02:36, Melanie Plageman wrote: > > On Thu, Jul 31, 2025 at 6:58 PM Melanie Plageman > wrote: > > > > The patch "Set-pd_prune_xid-on-insert.txt" can be applied as the last > > patch in the set. It sets pd_prune_xid on insert (so pages filled by > > COPY or insert can also be

Why CI doesn't run?

Hi Hacker, Anyone has an idea why CI has not yet run against https://commitfest.postgresql.org/patch/5996/? Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: Adding REPACK [concurrently]

Hello, Antonin! Antonin Houska : > > Where exactly should HeapTupleSatisfiesDirty() conclude that the tuple is > visible? TransactionIdIsCurrentTransactionId() will not do w/o the > modifications that you proposed earlier [1] and TransactionIdIsInProgress() is > not suitable as I explained in [2].

Re: Buffer locking is special (hints, checksums, AIO writes)

On Fri, Aug 22, 2025 at 03:44:48PM -0400, Andres Freund wrote: > I'm working on making bufmgr.c ready for AIO writes. Nice! > == Problem 2 - AIO writes vs exclusive locks == > > Separate from the hint bit issue, there is a second issue that I didn't have a > good answer for: Making acquiring an

Re: Improve LWLock tranche name visibility across backends

> > On Mon, Aug 25, 2025 at 04:59:41PM -0500, Sami Imseih wrote: > > > hmm, can we really avoid a shared lock when reading from shared memory? > > > considering access for both reads and writes can be concurrent to shared > > > memory. We are also taking an exclusive lock when writing a new tranche

Re: Generate GUC tables from .dat file

On Mon, Aug 25, 2025 at 4:36 PM Peter Eisentraut wrote: > > Here is an updated patch with the remaining comments carried over. I'm > not sure how I lost these. I also added some more comments to the Perl > script and have it print the usual boilerplate into the header. And I > added some .gitig

Re: Improve LWLock tranche name visibility across backends

fixed the issues mentioned above in v13. > We probably need to do the sprintf/strcpy before LWLockNewTrancheId(). > Also, I'm thinking we should just use the same tranche for both the DSA and > the dshash table [0] to evade the DSMR_DSA_TRANCHE_SUFFIX problem, i.e., > those tranche names potential

Re: Per backend relation statistics tracking

> > That is why I think we should be careful about naming. pg_stat_backend feels > > very generic, but right now it only shows relation stats. Maybe we call it > > pg_stat_backend_tables to start? Then if we later add I/O, we could have > > pg_stat_backend_io, or for conflicts, pg_stat_backend_conf

Re: pgsql: oauth: Add unit tests for multiplexer handling

On Tue, Aug 26, 2025 at 2:18 PM Jacob Champion wrote: > Thanks! The meson side needs an additional thread_dep as well; once > that passes CI I will push. Committed and backpatched. Thanks again! --Jacob

Re: ABI Compliance Checker GSoC Project

Hello Hackers Again! It's been a long time since we last had a talk and I have a good update on this project. If someone is new to this thread so for your context, initially I worked on checking ABI breakages in PostgreSQL by comparing every two commits on the stable branches using BuildFarm. But

Re: pgsql: oauth: Add unit tests for multiplexer handling

On Tue, Aug 26, 2025 at 1:45 PM Christoph Berg wrote: > The patch fixes the autoconf build here. Thanks! The meson side needs an additional thread_dep as well; once that passes CI I will push. --Jacob

Re: pgsql: oauth: Add unit tests for multiplexer handling

Re: Jacob Champion > oauth: Add unit tests for multiplexer handling This seems to require more linking on Debian bullseye: 20:19:29 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-

Re: Buffer locking is special (hints, checksums, AIO writes)

Hi, On 2025-08-26 16:21:36 -0400, Robert Haas wrote: > On Fri, Aug 22, 2025 at 3:45 PM Andres Freund wrote: > > My conclusion from the above is that we ought to: > > > > A) Make Buffer Locks something separate from lwlocks > > B) Merge BufferDesc.state and the content lock > > C) Allow some modif

Re: Improve LWLock tranche name visibility across backends

On Tue, Aug 26, 2025 at 02:56:22PM -0500, Sami Imseih wrote: > Here is v12 that replaces the LWLock to access the shared memory with a > ShmemLock and implements a local counter. This looks much closer to what I was imagining. /* Initialize the LWLock tranche for the DSA. */ -

Re: pgsql: oauth: Add unit tests for multiplexer handling

Re: Jacob Champion > On Tue, Aug 26, 2025 at 1:10 PM Jacob Champion > wrote: > > Okay. So I need to pull in PTHREAD_CFLAGS/LIBS as well... > > Christoph, are you able to verify the attached patch fixes the build? The patch fixes the autoconf build here. Thanks, Christoph

Re: pgsql: oauth: Add unit tests for multiplexer handling

On Tue, Aug 26, 2025 at 1:10 PM Jacob Champion wrote: > Okay. So I need to pull in PTHREAD_CFLAGS/LIBS as well... Christoph, are you able to verify the attached patch fixes the build? --Jacob fix-bullseye.diff Description: Binary data

Re: Buffer locking is special (hints, checksums, AIO writes)

On Fri, Aug 22, 2025 at 3:45 PM Andres Freund wrote: > My conclusion from the above is that we ought to: > > A) Make Buffer Locks something separate from lwlocks > B) Merge BufferDesc.state and the content lock > C) Allow some modifications of BufferDesc.state while holding spinlock +1 to (A) and

Re: plan shape work

On Tue, Aug 26, 2025 at 10:58:33AM -0400, Robert Haas wrote: > During planning, there is one range table per subquery; at the end if > planning, those separate range tables are flattened into a single > range table. Prior to this change, it was impractical for code > examining the final plan to und

Re: pgsql: oauth: Add unit tests for multiplexer handling

On Tue, Aug 26, 2025 at 12:48 PM Christoph Berg wrote: > This seems to require more linking on Debian bullseye: Bleh. Thanks for the report; looks like none of the bullseye animals in the farm are building with Curl yet. (cc Stefan: guaibasaurus seems like it'd be a good candidate; would you con

Re: [BUG] Remove self joins causes 'variable not found in subplan target lists' error

On 8/26/25 20:26, Tom Lane wrote: Richard Guo writes: We could then use this function to remove expressions that are known constant from semi_rhs_exprs. And if we find that all expressions in semi_rhs_exprs are known constant (the second loose end you mentioned), we can give up building uniq

Re: vacuumdb --missing-stats-only and permission issue

On Tue, Aug 26, 2025 at 09:00:53PM +0900, Fujii Masao wrote: > On Tue, Aug 26, 2025 at 1:20 AM Nathan Bossart > wrote: >> Okay. I'll plan on committing the documentation update in the next 24-48 >> hours, provided no additional feedback materializes. > > The patch looks good to me. Thanks! Com

Re: Aggregate Function corr does not always return the correct value

Em ter., 26 de ago. de 2025 às 14:34, Tom Lane escreveu: > Maxim Orlov writes: > > One of the clients complained as to why the query for calculating the > > correlation coefficient with the CORR function yielded such weird > > results. After a little analysis, it was discovered that they were >

Schedule for PG 18 RC and GA releases

The release team has agreed that we should put out 18rc1 next week (wrap 9/1, announce 9/4). If the RC period goes smoothly, we'll put out 18.0 the last full week of September (wrap 9/22, announce 9/25). regards, tom lane

Re: Aggregate Function corr does not always return the correct value

Hi, Try casting it to numeric or use an expression that avoids floating-point rounding off : WITH dataset AS ( SELECT x, CAST(0.125 AS numeric) AS y FROM generate_series(0, 5) AS x ) SELECT corr(x, y) FROM dataset; Thanks & Regards Dinesh Nair From

Re: [BUG] Remove self joins causes 'variable not found in subplan target lists' error

Richard Guo writes: > Instead of repeatedly calling make_pathkeys_for_sortclauses to detect > redundant expressions, I'm wondering if we could introduce a function > that detects whether a given expression is known equal to a constant > by the EquivalenceClass machinery. This function should not

Re: Aggregate Function corr does not always return the correct value

Maxim Orlov writes: > One of the clients complained as to why the query for calculating the > correlation coefficient with the CORR function yielded such weird > results. After a little analysis, it was discovered that they were > calculating the correlation coefficient for two sets, one of which

Re: fixing tsearch locale support

On 18/08/2025 18:56, Daniel Verite wrote: There is a PG18 open item to document this possible upgrade incompatibility. I think the following text could be added to the release notes: """ The locale implementation underlying full-text search was improved. It now observes the locale provider con

Re: Explicitly enable meson features in CI

On Tue, Aug 26, 2025 at 12:27 AM Nazir Bilal Yavuz wrote: > Patches LGTM. I also checked the CI tasks and everything looks good. Great, thanks! The full diff of the Meson configure output for each task also looks good. So I'll plan to push v7. --Jacob

Re: Proper object locking for GRANT/REVOKE

On 19/08/2025 21:21, Nathan Bossart wrote: On Mon, Jun 23, 2025 at 04:16:09PM -0700, Noah Misch wrote: On Wed, Jun 11, 2025 at 05:22:53PM +0200, Peter Eisentraut wrote: There is an open item for PG18 for this. So here is a patch that adds a comment back, mostly from your descriptions in this t

Re: C11 / VS 2019

Peter Eisentraut writes: > Tom: You ought to update the configuration on the buildfarm members > longfin and sifaka from > 'CC' => 'ccache clang -std=gnu99', > to > 'CC' => 'ccache clang -std=gnu11', > for the master branch. Roger, will do. regards, tom lane

Re: Parallel heap vacuum

On Wed, Jul 23, 2025 at 12:06 PM Andres Freund wrote: > > On 2025-07-22 11:44:29 -0700, Masahiko Sawada wrote: > > Do you think it makes sense to implement the above idea that we launch > > parallel vacuum workers for heap through the same vacuumparallel.c > > codebase and maintain the consistent

Re: C11 / VS 2019

On 30.07.25 00:11, David Rowley wrote: On Wed, 30 Jul 2025 at 00:57, Tom Lane wrote: David Rowley writes: On Fri, 18 Jul 2025 at 23:12, Peter Eisentraut wrote: Note that gcc and clang switched to C11 by default a long time ago (gcc-5 and clang-3.6), so for most users all these tests won't

Aggregate Function corr does not always return the correct value

Hi! One of the clients complained as to why the query for calculating the correlation coefficient with the CORR function yielded such weird results. After a little analysis, it was discovered that they were calculating the correlation coefficient for two sets, one of which is more or less random a

Re: Dead code in ps_status.c

Hi, On Tue, Aug 26, 2025 at 03:55:30PM +0200, Michael Banck wrote: > On Thu, Feb 16, 2023 at 04:52:33PM +1300, Thomas Munro wrote: > > Therefore I think it is safe to drop the PS_USE_PS_STRING and > > PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments > > and macro tests, and pr

Re: Feature request: A method to configure client-side TLS ciphers for streaming replication

Hi, On 2025-08-26 10:09:56 -0400, Tom Lane wrote: > xx Z writes: > > For security compliance, we need to restrict the ciphers used by the > > client. Is there a way to configure the list of supported TLS ciphers on > > the standby for the replication connection? > > No. It's not really apparent

Re: Feature request: A method to configure client-side TLS ciphers for streaming replication

On Tue, Aug 26, 2025 at 7:10 AM Tom Lane wrote: > (For that matter, if you have system-level security specifications > to meet, why would you not alter the system-wide OpenSSL configuration > on the client's host?) There is that, or you can maybe use OPENSSL_CONF for more granularity. (But I'm be

Re: index prefetching

On 8/26/25 01:48, Andres Freund wrote: > Hi, > > On 2025-08-25 15:00:39 +0200, Tomas Vondra wrote: >> Thanks. Based on the testing so far, the patch seems to be a substantial >> improvement. What's needed to make this prototype committable? > > Mainly some testing infrastructure that can trigg

Re: PoC: pg_dump --filter-data (like Oracle Where Clause on RMAN for specific tables)

On Sat, Aug 23, 2025 at 8:05 AM jian he wrote: > hi. > > I just found this > > https://www.postgresql.org/message-id/flat/CALAY4q8o00Sg5nemi2AuqNuLvmGLaR6br%2BYrvM41ZuSPjM2Qvg%40mail.gmail.com > maybe it's not that very helpful. > > IMV, > pg_dump --option="view_name" > is better than > pg_dump -

Re: Non-reproducible AIO failure

On Tue, Aug 26, 2025 at 04:59:54PM +0300, Konstantin Knizhnik wrote: > > > But we have observed the generated code being pretty grotty and it's caused > > more than enough confusion - so let's just replace them with plain uint8's > > and > > cast in switches. > > +1 > > May be I am wrong, but i

Marking shared buffer lookup table as HASH_FIXED_SIZE

Hi All, StrategyInitialize() calls InitBufTable() passing the maximum number of possible entries in the shared buffer lookup table. The table can not have more entries than the number of available shared buffers + number of partitions as explained in the comment in StrategyInitialize(). If there ar

Avoid overwiriting cache entry (src/backend/utils/cache/relcache.c)

Hi. In function *CheckNNConstraintFetch* the array index is incremented only when "null combin" is not found. IMO the last cache entry can be overwriting if the next tuple is null, because, the fill array fields is not syncronized with array index increment. Fix by moving the array fill. patch

Re: [PATCH] Generate random dates/times in a specified range

Le 25.08.2025 15:33, Greg Sabino Mullane a écrit : Your v3 did not get attached to the previous email. My bad, here it is -- Damien ClochardFrom 046deb02a7a1d468ff90b714e3fdcba29f865c3b Mon Sep 17 00:00:00 2001 From: damien Date: Thu, 3 Jul 2025 13:13:30 + Subject: [PATCH v3 2/2] Generate

Re: [WiP] B-tree page merge during vacuum to reduce index bloat

On Tue, Aug 26, 2025 at 6:33 AM Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > On Tue, 26 Aug 2025 at 11:40, Andrey Borodin wrote: > > > > Hi hackers, > > > > Together with Kirk and Nik we spent several online hacking sessions to > tackle index bloat problems [0,1,2]. As a result

Re: Feature request: A method to configure client-side TLS ciphers for streaming replication

xx Z writes: > For security compliance, we need to restrict the ciphers used by the > client. Is there a way to configure the list of supported TLS ciphers on > the standby for the replication connection? No. It's not really apparent to me why the client would have stronger needs for this than t

Redundant parameter in the get_useful_pathkeys_for_relation

Hi, Working on an unrelated project, I found that the get_useful_pathkeys_for_relation routine has redundant parameter 'require_parallel_safe'. This routine is static and is called only once with the 'true' value. Hence, it is evident that this parameter is a redundant one. The thread [1] see

Re: Non-reproducible AIO failure

On 26/08/2025 3:37 AM, Andres Freund wrote: Hi, I'm a bit confused by this focus on bitfields - both Alexander and Konstantin stated they could reproduce the issue without the bitfields. Sorry if I am not correct, but it seems that the problem was never reproduced with replaced bitfields. I

Re: Dead code in ps_status.c

Hi, On Thu, Feb 16, 2023 at 04:52:33PM +1300, Thomas Munro wrote: > Therefore I think it is safe to drop the PS_USE_PS_STRING and > PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments > and macro tests, and prune the defunct configure/meson probe. I noticed Postgres no longer up

Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring

On Tue, Jul 8, 2025 at 5:22 AM Andres Freund wrote: > > Hi, > > On 2025-06-30 12:27:10 -0400, Andres Freund wrote: > > On 2025-06-05 14:32:10 -0400, Andres Freund wrote: > > > On 2025-06-05 12:47:52 -0400, Tom Lane wrote: > > > > Andres Freund writes: > > > > > I think this is a big enough pitfal

Re: Adding REPACK [concurrently]

Mihail Nikalayeu wrote: > Antonin Houska : > > > Although it could work, I think it'd be confusing to consider the > > transactions > > being replayed as "current" from the point of view of the backend that > > executes REPACK CONCURRENTLY. > > Just realized SnapshotDirty is the thing that fit

Re: Detoast iterators -take 2

Hi Nikita, Thanks for working on this. > master: > [...] > Time: 47.346 ms > > patched: > [...] > Time: 7.607 ms Looks impressive. I believe there is still some room for improvement though: 1. IMO the new API (create_detoast_iterator et al) should have corresponding unit tests. 2. Suggestion: p

Re: index prefetching

On 8/26/25 03:08, Peter Geoghegan wrote: > On Mon Aug 25, 2025 at 10:18 AM EDT, Tomas Vondra wrote: >> The attached patch is a PoC implementing this. The core idea is that if >> we measure "miss probability" for a chunk of requests, we can use that >> to estimate the distance needed to generate e_i

Re: vacuumdb --missing-stats-only and permission issue

On Tue, Aug 26, 2025 at 1:20 AM Nathan Bossart wrote: > > On Tue, Aug 26, 2025 at 12:24:27AM +0900, Yugo Nagata wrote: > > Thank you for the clarification. I understand your points now, > > so I'll withdraw my proposal. > > Okay. I'll plan on committing the documentation update in the next 24-48

Re: Non-reproducible AIO failure

Hi, On 2025-08-26 15:21:34 +1200, Thomas Munro wrote: > On Tue, Aug 26, 2025 at 12:45 PM Andres Freund wrote: > > On 2025-08-25 10:43:21 +1200, Thomas Munro wrote: > > > On Mon, Aug 25, 2025 at 6:11 AM Konstantin Knizhnik > > > wrote: > > > > In theory even replacing bitfield with in should not

How to configure client-side TLS ciphers for streaming replication?

Hello, Is there a way for a streaming replication standby (client) to restrict its list of supported TLS ciphers, similar to how the ssl_ciphers parameter works on the primary server? We need this for security compliance but can't find an equivalent setting for the client-side connection in primary

Re: pg_waldump: support decoding of WAL inside tarfile

On Mon, Aug 25, 2025 at 5:58 PM Amul Sul wrote: > > On Thu, Aug 7, 2025 at 7:47 PM Amul Sul wrote: > > [] > > --- > > Known Issues & Status: > > --- > > - Timeline Switching: The current implementation in patch 006 does not > > c

Re: pg_restore --no-policies should not restore policies' comment

On Thu, Jul 3, 2025 at 11:32 PM jian he wrote: > > On Wed, Jul 2, 2025 at 5:18 PM Fujii Masao > wrote: > > > > > hi. > > > > > > I’ve tested the pg_restore options --no-policies, --no-publications, and > > > --no-subscriptions locally. > > > > Thanks for updating the patch! Could you add it to t

Re: Per backend relation statistics tracking

Hi, On 2025-08-26 06:38:41 +, Bertrand Drouvot wrote: > > and IO related counters aren't > > incremented remotely as often as the scan related counters are. > > You mean the flush are not triggered as often? If so, yeah that's also > something > you've mentioned ([1]) and that I've in mind t

Re: [BUG?] check_exclusion_or_unique_constraint false negative

On Mon, Aug 25, 2025 at 7:02 PM Mihail Nikalayeu wrote: > > Amit Kapila : > > > > What if the new insert happens in a page prior to the current page? I > > mean that the scan won't encounter the page where Insert happens. > > Hmm Yes - if the TID lands to the page left of the current > positio

Re: Problem in 'ORDER BY' of a column using a created collation?

On Mon, Aug 25, 2025 at 8:59 PM jian he wrote: > On Mon, Aug 25, 2025 at 3:52 PM Nishant Sharma > wrote: > > > > > > Experiment 1:- > > SQL File : PG_Exp_1.sql > > > > Actual Output : PG_Exp_1.out > > > > Created COLLATION : CREATE COLLATION test_coll ( > > provider = icu, locale = 'ja-u-kr-latn

Re: Conflict detection for update_deleted in logical replication

Please find some more comments: 1) In CheckSubDeadTupleRetention(), shall we have below instead of retain_dead_tuples check in all conditions? if (retain_dead_tuples) guc checks (wal_level and tracl_commit) else max retention check 2) Currently stop and resume messages are: ~~ LOG: logic

Re: [WiP] B-tree page merge during vacuum to reduce index bloat

On Tue, 26 Aug 2025 at 11:40, Andrey Borodin wrote: > > Hi hackers, > > Together with Kirk and Nik we spent several online hacking sessions to tackle > index bloat problems [0,1,2]. As a result we concluded that B-tree index page > merge should help to keep an index from pressuring shared_buffer

Re: Per backend relation statistics tracking

Hi, On Mon, Aug 25, 2025 at 05:51:38PM -0500, Sami Imseih wrote: > Thanks for the patches. > > I have not gone through them in detail yet, but +1 on adding backend activity > stats. Thanks for sharing your thoughts. > This provides another level of drill down to spot anomalous sessions or > dif

Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)

On Sat, 2 Aug 2025 at 02:36, Melanie Plageman wrote: > > On Thu, Jul 31, 2025 at 6:58 PM Melanie Plageman > wrote: > > > > The patch "Set-pd_prune_xid-on-insert.txt" can be applied as the last > > patch in the set. It sets pd_prune_xid on insert (so pages filled by > > COPY or insert can also be

Re: Report reorder buffer size

> > > > > > If we are going > > > to report so much statistics about the contents of the reorder buffer, > > > is it better to have a separate view pg_stat_reorder_buffer for the > > > same? > > > > Given logical decoding can be used also by regular backend processes, > > I guess that such dynamic

Re: [BUG] Remove self joins causes 'variable not found in subplan target lists' error

On Tue, Aug 26, 2025 at 4:16 AM Tom Lane wrote: > I wrote: > > Yeah. I think this is an oversight in create_unique_paths(): it's > > building an ORDER BY list without consideration for the possibility > > that some of the entries are known to be constant. In fact, because > > make_pathkeys_for_s

Re: Report reorder buffer size

Hi, On Tue, Aug 26, 2025 at 02:56:14PM +0530, Ashutosh Bapat wrote: > On Mon, Aug 25, 2025 at 6:28 PM Bertrand Drouvot > wrote: > > > I didn't know this is how it works. Thanks for correcting me. In that > > > case, I think we should > > > add a column in pg_stat_replication_slots reporting the n

Re: Report reorder buffer size

Hi Masahiko, Thanks for your inputs. On Tue, Aug 26, 2025 at 2:17 AM Masahiko Sawada wrote: > On Wed, Aug 13, 2025 at 5:40 AM Ashutosh Bapat > wrote: > > Thank you for starting the thread about this topic. This is one of the > topics that I've been eager to address. Here are some random comment

Re: Per backend relation statistics tracking

Hi, On Tue, Aug 26, 2025 at 06:38:41AM +, Bertrand Drouvot wrote: > Hi, > > On Mon, Aug 25, 2025 at 08:28:04PM -0400, Andres Freund wrote: > > I don't like that this basically doubles the overhead of keeping stats by > > tracking everythign twice. The proper solution is to do that not in the

[WiP] B-tree page merge during vacuum to reduce index bloat

Hi hackers, Together with Kirk and Nik we spent several online hacking sessions to tackle index bloat problems [0,1,2]. As a result we concluded that B-tree index page merge should help to keep an index from pressuring shared_buffers. We are proposing a feature to automatically merge nearly-emp

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

On Tue, Aug 26, 2025 at 12:54 AM Masahiko Sawada wrote: > > I've attached the updated patch that incorporated the comments and is > rebased to the current HEAD. > Thanks for the patch, please find a few comments concerning LOG messages: 1) slotsync worker gives LOG: LOG: replication slot synchr

Re: [BUG] Remove self joins causes 'variable not found in subplan target lists' error

On Tue, Aug 26, 2025 at 4:16 AM Tom Lane wrote: > Here is a patch that fixes it that way. I like this better than > Sergey's approach because it is making the plans better not worse. > > There are a couple loose ends yet to be dealt with: > > * The fact that we now avoid duplicate unique-ificatio

Re: Report reorder buffer size

On Mon, Aug 25, 2025 at 6:28 PM Bertrand Drouvot wrote: > > I didn't know this is how it works. Thanks for correcting me. In that > > case, I think we should > > add a column in pg_stat_replication_slots reporting the number of > > times the memory limit is reached since the last reset. I am +0.5

Re: Adding REPACK [concurrently]

Antonin Houska : > Although it could work, I think it'd be confusing to consider the transactions > being replayed as "current" from the point of view of the backend that > executes REPACK CONCURRENTLY. Just realized SnapshotDirty is the thing that fits into the role - it respects not-yet committ

Re: Conflict detection for update_deleted in logical replication

On Tue, Aug 26, 2025 at 12:15 PM Amit Kapila wrote: > > On Mon, Aug 25, 2025 at 5:05 PM Amit Kapila wrote: > > Some comments on latest patch 0001: 1. + + Note that setting a non-zero value for this option could lead to + information for conflict detection being rem

Re: RFC: extensible planner state

On 25/8/2025 21:46, Robert Haas wrote: On Wed, Aug 20, 2025 at 3:13 PM Robert Haas wrote: Here's v2. 0001 is what you saw before with an attempt to fix the memory context handling. 0002 removes join_search_private. All I've tested is that the tests pass. Here's v3 with a few more patches. I'm

Re: Adding REPACK [concurrently]

Mihail Nikalayeu wrote: > Antonin Houska : > > I think the problem is that HeapTupleSatisfiesSelf() uses > > TransactionIdIsInProgress() instead of checking the snapshot: > > Yes, some issues might be possible for SnapshotSelf. > Possible solution is to override TransactionIdIsCurrentTransaction

Feature request: A method to configure client-side TLS ciphers for streaming replication

Hello PostgreSQL community, I have a question regarding the configuration of streaming replication. When setting up streaming replication over TLS, I've noticed that while the primary server can restrict its supported encryption algorithms using the ssl_ciphers parameter, there doesn't seem to be

Re: Support getrandom() for pg_strong_random() source

> On 26 Aug 2025, at 00:38, Jacob Champion > wrote: > > On Mon, Aug 25, 2025 at 3:22 PM Masahiko Sawada wrote: >> >> For instance, we could >> introduce a GUC parameter that lets users specify their preferred >> random number source. Or the server can automatically select it based >> on the ke

Detoast iterators -take 2

Hi hackers! Some time ago there was a discussion on detoast iterators [1]. The original thread stalled, but we took it, reviewed and refactored, and used it for some of our ideas. I've refactored it onto the current master and made some tests, iterative detoast provides significant improvement ov

Re: Explicitly enable meson features in CI

Hi, On Tue, 26 Aug 2025 at 02:37, Jacob Champion wrote: > > On Mon, Jul 28, 2025 at 11:20 AM Jacob Champion > wrote: > > Sounds good. I will take another look at this with a committer hat and > > push Sometime Soon. > > Getting back to this -- for v7 I've rebased over the FASTLINK commit. > I've

Re: Making WAL archiving faster — multi-file support and async ideas

Hi Greg! Thanks for your question — it made me take a closer look at the recovery process. You're absolutely right, and I appreciate you pointing that out. Postgres requests history files from the archive, which helps determine whether to wait for the next segment or if the timeline is finished. I

Re: Calling PGReserveSemaphores() from CreateOrAttachShmemStructs

Hi Thomas, On Mon, Aug 25, 2025 at 3:11 PM Thomas Munro wrote: > > On Mon, Aug 25, 2025 at 9:10 PM Ashutosh Bapat > wrote: > > Is this change correct? Was there any reason to leave it like that in > > e25626677f8076eb3ce94586136c5464ee154381? Or was it just something > > that didn't fit in that