On Mon, 6 Jan 2025 at 12:30, Alexander Lakhin wrote:
>
> Hello hackers,
>
> I'd like to share my investigation of one mysterious stats.sql failure
> occurred in December: [1].
> The difference of the failure is:
> --- C:/prog/bf/root/HEAD/pgsql/src/test/regress/expected/stats.out 2024-09-18
> 19:
Hi Michael,
#include "miscadmin.h"
+#include "nodes/execnodes.h"
#include "nodes/pg_list.h"
#include "nodes/value.h"
Do we need to include this? I did not see any compilation error when I
removed this.
> Now for the second part with the SRF making the injection point
> information available
On Thu, Jul 3, 2025 at 3:32 PM Fujii Masao wrote:
>
>
>
> On 2025/07/03 11:08, Shinya Kato wrote:
> > On Wed, Jul 2, 2025 at 4:48 PM Fujii Masao
> > wrote:
> >
> Regarding the documentation, how about explicitly stating that when
> MATCH is specified, only
> the first line is ski
On Thu, 3 Jul 2025 at 02:03, Jacob Champion
wrote:
> Okay, wait -- JDBC was _copying_ our weird behavior? Why? Does
> something depend it in the wild?
I'm pretty sure there was no intent behind this, but it's simply
because our weird behaviour is the simplest from the client
implementation side w
On Thu, Jul 3, 2025 at 9:32 AM Amit Kapila wrote:
>
> On Wed, Jul 2, 2025 at 5:50 PM Ashutosh Bapat
> wrote:
> >
> > On Wed, Jul 2, 2025 at 12:36 PM shveta malik wrote:
> > >
> > > On Wed, Jul 2, 2025 at 10:50 AM Ashutosh Bapat
> > > wrote:
> > > >
> > > > Hi All,
> > > >
> > > > The failover s
On Wed, Jul 2, 2025 at 9:46 PM Masahiko Sawada wrote:
>
> On Wed, Jun 18, 2025 at 1:07 PM shveta malik wrote:
> >
> > On Wed, Jun 18, 2025 at 6:06 AM Masahiko Sawada
> > wrote:
> > >
> > > Thank you for the comments!
> > >
> > > >
> > > > 2)
> > > > I see that when primary switches back its eff
On 2025/07/03 11:08, Shinya Kato wrote:
On Wed, Jul 2, 2025 at 4:48 PM Fujii Masao wrote:
Regarding the documentation, how about explicitly stating that when MATCH is
specified, only
the first line is skipped? While this may seem obvious, it’s worth clarifying,
as the semantics
of the HEA
On Thu, Jul 03, 2025 at 08:51:56AM +0900, Michael Paquier wrote:
> This results in the second patch attached. Comments are welcome.
There has been a blip with the regression test output, so rebased.
--
Michael
From e70d1606306a9933655fbae6f8a3f472c110 Mon Sep 17 00:00:00 2001
From: Michael Pa
On Thu Jul 3, 2025 at 2:03 AM CEST, Jacob Champion wrote:
On Wed, Jul 2, 2025 at 3:18 PM Jelte Fennema-Nio wrote:
I will hold off on detailed review until Heikki gives an opinion on
the design (or we get closer to the end of the month), to avoid making
busy work for you -- but I will say that I
On Thu, 3 Jul 2025 at 04:11, Tatsuo Ishii wrote:
> After thinking more, I reached a conclusion it would better to apply
> attached simple patch to v18 since v18 is already in the beta phase
> and we want to make changes to it minimal.
I thought that clarifying docs was exactly one of the things t
On Thu, Jul 3, 2025 at 10:43 AM Amit Kapila wrote:
>
> On Thu, Jul 3, 2025 at 10:26 AM Dilip Kumar wrote:
> >
> > On Wed, Jul 2, 2025 at 12:58 PM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> >
> > > During local testing, I discovered a bug caused by my oversight in
> > > assigning
> > > the new xmin
On Thu, Jul 3, 2025 at 10:26 AM Dilip Kumar wrote:
>
> On Wed, Jul 2, 2025 at 12:58 PM Zhijie Hou (Fujitsu)
> wrote:
> >
>
> > During local testing, I discovered a bug caused by my oversight in assigning
> > the new xmin to slot.effective, which resulted in dead tuples remaining
> > non-removable
On Wed, Jul 2, 2025 at 10:05 PM Amit Langote wrote:
> On Wed, Jul 2, 2025 at 7:05 PM Etsuro Fujita wrote:
> > On Tue, Jul 1, 2025 at 4:42 PM Amit Langote wrote:
> > > On Tue, Jul 1, 2025 at 11:55 AM Etsuro Fujita
> > > wrote:
> > > > While working on something else, I noticed that while we dis
On Wed, Jul 2, 2025 at 12:58 PM Zhijie Hou (Fujitsu)
wrote:
>
> During local testing, I discovered a bug caused by my oversight in assigning
> the new xmin to slot.effective, which resulted in dead tuples remaining
> non-removable until restart. I apologize for the error and have provided
> corre
On Wed, Jul 2, 2025 at 7:18 PM Amit Langote wrote:
> Just to clarify -- I was hoping that, at least for SELECTs, we
> wouldn’t need to lock all leaf partitions up front.
>
> One of the potential selling points of global indexes (compared to
> partitioned indexes) is that we can avoid expand_parti
On Wed, Jul 2, 2025 at 5:50 PM Ashutosh Bapat
wrote:
>
> On Wed, Jul 2, 2025 at 12:36 PM shveta malik wrote:
> >
> > On Wed, Jul 2, 2025 at 10:50 AM Ashutosh Bapat
> > wrote:
> > >
> > > Hi All,
> > >
> > > The failover slots documentation [1] is good for PG - PG logical
> > > replication, but t
On Wed, Jul 2, 2025 at 2:46 PM torikoshia wrote:
>
> On 2025-07-01 14:20, Masahiko Sawada wrote:
> > On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada
> > wrote:
> >>
> >> On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart
> >> wrote:
> >> >
> >> > On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sa
On Fri, Apr 25, 2025 at 01:50:16PM +, David Steele wrote:
> That was my expectation. I just had some time to get this patch updated so
> took the opportunity.
And well, now is the time to get this patch done. So, applied after
an extra lookup, with a switch from UINT_MAX to PG_UINT32_MAX in t
>
> Thanks for the feedbacks!
To be honest, I'm fine with v3, since it only increases the sleep time
> after 5000 loop iterations, which has negligible performance impact.
> But if these functions aren't intended to be used during recovery and
> the loop shouldn't reach that many iterations, I'm a
>> I agree that that's strictly true, but I think I still prefer my newly
>> proposed wording for a few reasons:
>> 1. My new wording is generic enough that we don't need to update it in
>> the future.
>> 2. A 3.2 server will currently still receive a 3.0 message, and might
>> want to support downg
On Wed, Jul 2, 2025 at 4:48 PM Fujii Masao wrote:
> >> Regarding the documentation, how about explicitly stating that when MATCH
> >> is specified, only
> >> the first line is skipped? While this may seem obvious, it’s worth
> >> clarifying, as the semantics
> >> of the HEADER option have becom
Andrei Lepikhov 于2025年7月2日周三 22:29写道：
> On 30/6/2025 04:38, Tender Wang wrote:
> > Do you think it's worth doing this?
> >
> >
> > Hi all,
> >
> > I have added this patch to commitfest[1]. I'm hoping someone can review
> > it for me.
> It makes sense to apply. If you return the comment to its
On Wed, 02 Jul 2025 at 09:57, Peter Eisentraut wrote:
> On 01.05.25 15:47, Japin Li wrote:
>> On Thu, 01 May 2025 at 12:13, Peter Eisentraut wrote:
>>> On 30.04.25 17:48, Japin Li wrote:
While working on [1], I found outdated comments in IndexInfo.
The attached patch corrects them.
On Wed, 02 Jul 2025 at 11:21, John H wrote:
> Hi,
>
> Thanks for the quick review.
>
> On Tue, Jul 1, 2025 at 8:16 PM wenhui qiu wrote:
>> > Perhaps decide_wal_file_action() could be defined in filemap.c.
>>
>
> That's a good point. I updated the patch to reflect that.
>
Thanks for updating the
Hi,
On Wed, Jul 2, 2025 at 10:56 PM Fujii Masao
wrote:
>
>
> On 2025/07/02 23:19, Andres Freund wrote:
> > Hi,
> >
> > On July 2, 2025 10:15:09 AM EDT, Fujii Masao <
> masao.fu...@oss.nttdata.com> wrote:
> >>
> >>
> >> On 2025/07/02 23:04, Andres Freund wrote:
> >>> Hi,
> >>>
> >>> On 2025-07-02
Dear Michael, Fujii-san,
> Ah, indeed, so it was reported a couple of months ago. I am not sure
> that the argument about all the other GUCs potentially impacted holds
> much value; we are talking about a specific code path.
Yeah, I did report but sadly it was missed by others :-(. To clarify,
T
On Thu, Jul 3, 2025 at 7:32 AM Michael Paquier wrote:
>
> On Wed, Jul 02, 2025 at 08:57:45PM +0200, Alvaro Herrera wrote:
> > I think a tool would have to be severely miswritten in order to become
> > broken from this change. Our own code to scan LSNs is to use
> > scanf('%X/%X') which should wor
On Sun, Sep 8, 2024 at 2:08 PM Lars Kanis wrote:
> To fix this issue the attached patch calls pqReadData() repeatedly in
> PQconsumeInput() until there is no buffered SSL data left to be read.
> Another solution could be to process buffered SSL read bytes in
> PQisBusy() instead of PQconsumeInput
On Thu, Jul 03, 2025 at 09:48:40AM +0900, Fujii Masao wrote:
> Is this the same issue that was discussed in [1]?
>
> [1]
> https://postgr.es/m/oscpr01mb14966ff9e4c4145f37b937e52f5...@oscpr01mb14966.jpnprd01.prod.outlook.com
Ah, indeed, so it was reported a couple of months ago. I am not sure
th
On 2025/07/02 9:38, Andy Fan wrote:
Hi,
When working with the commit_ts module, I find the following issue:
After configure with --enable-cassert option, then initdb with:
initdb -D x2 -c track_commit_timestamp=on
Then we can get the following core dump:
Is this the same issue that was
On Wed, Jul 2, 2025 at 6:44 PM Andrei Lepikhov wrote:
> On 2/7/2025 11:14, Richard Guo wrote:
> > On Wed, Jul 2, 2025 at 4:32 PM Andrei Lepikhov wrote:
> >> Therefore, it would be better to find a way to refactor the
> >> `preprocess_relation_rtes` function to gather table statistics lazily
> >>
On Wed, Jul 02, 2025 at 09:03:35AM +, Bertrand Drouvot wrote:
> +* Don't bother to record commit_ts for Booststrap mode.
>
> typo: s/Booststrap/Bootstrap/
>
> Also, grep on "Bootstrap mode" and "bootstrap mode" gives much more
> occurrences
> for the later, so maybe use "bootstrap mo
On Wed, Jul 2, 2025 at 3:18 PM Jelte Fennema-Nio wrote:
> I think you might have meant: "If libpq doesn't
> allow it, even though the spec suggets it should, then people will still
> blame the server implemantion".
Yes. Same for clients which disallow corner cases that the spec is
silent on but l
On Tue, Apr 15, 2025 at 08:00:50AM +0900, Michael Paquier wrote:
> On Mon, Apr 14, 2025 at 04:29:37PM +0300, Aleksander Alekseev wrote:
>> If I didn't miss anything, all SQL functions dealing with injection
>> points are gathered in injection_points extension so IMO
>> pg_get_injection_points() bel
On Mon, Jun 30, 2025 at 3:01 PM Robert Haas wrote:
>
> I'm pretty concerned about this change:
>
> /*
> * If the page is all visible, need to clear that, unless we're only
> * going to add further frozen rows to it.
> *
> * If we're only adding alre
On Tue, Jul 1, 2025 at 1:42 PM Jacob Champion
wrote:
> I do
> not yet understand why this protection is not extended to
> GSS-encrypted connections.
After repurposing some of my test code for d98cefe11, I'm able to
reproduce the hang with gssencmode when the server uses a
smaller-than-standard (1
On Wed, Jun 04, 2025 at 09:15:08AM +0900, Michael Paquier wrote:
> On Tue, Jun 03, 2025 at 03:34:16PM -0400, Andres Freund wrote:
>> I'm somewhat doubtful this is is the right direction. Tests that require
>> injection points before consistency also can't wait for injection points
>> using
>> the
On Wed, Jul 02, 2025 at 01:44:55PM +0200, Peter Eisentraut wrote:
> Couldn't this also be done by making that global variable thread-local? But
> getting rid of it is even nicer.
Getting rid of it like Daniel is proposing is by putting this
information in the backend Port is much more elegant IMO.
On Wed, Jul 02, 2025 at 08:57:45PM +0200, Alvaro Herrera wrote:
> I think a tool would have to be severely miswritten in order to become
> broken from this change. Our own code to scan LSNs is to use
> scanf('%X/%X') which should work just fine with and without the leading
> zeroes. I honestly do
On Tue, 1 Jul 2025 at 18:50, Jacob Champion
wrote:
Not what I said. I'm saying that if a server implementation claims
Postgres compatibility but fails to talk to deployed versions of libpq
in practice, people will roll their eyes, even if other client
implementations work. The most widely depl
Peter Eisentraut writes:
> ... The aclitem parsing ends up in getid()
> in src/backend/utils/adt/acl.c, which thinks that an input string
> consisting entirely of "" is an escaped double quote.
Yeah, that is definitely broken, and also it occurs to me that this
coding is not robust in the face
Peter pointed out at [1] that acl.c's getid() behaves oddly
when presented with a string of just two double quotes ("").
If that has any sane interpretation it's as an empty string,
but what you got was a single double quote.
While looking at this I realized that there's another problem:
if the st
Hi!
Here is a new version. I added a commit message. I will add it to PG19-2.
Best regards,
Arseniy Mukhin
From 0b5a1fce01dd2bb9ef43febeb497dae4eb274405 Mon Sep 17 00:00:00 2001
From: Arseniy Mukhin
Date: Wed, 2 Jul 2025 22:00:31 +0300
Subject: [PATCH v2] Add check for compressed posting list i
On Wed, Jul 02, 2025 at 12:37:37PM -0500, Nathan Bossart wrote:
> Oops, it looks like renaming the test_dsm_registry functions wasn't a good
> idea:
>
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2025-07-02%2017%3A11%3A10
>
> Will fix...
Seems to be fixed with comm
On 2025-Jul-03, Masahiko Sawada wrote:
> On Wed, Jul 2, 2025 at 10:56 PM Japin Li wrote:
> Interesting. While this is a better format, could it break
> compatibility with existing tools that for example compares LSN
> strings?
I think a tool would have to be severely miswritten in order to beco
Hi All,
We'd like to share updated performance results for tuple sort after improving
the benchmark to better stress sort. We added an offset to the query to
eliminate the contribution of data movement to the client (referring to
https://www.postgresql.org/message-id/flat/CANWCAZbAmaZ7P%2BARjS9
Hi,
Thanks for the quick review.
On Tue, Jul 1, 2025 at 8:16 PM wenhui qiu wrote:
> > Perhaps decide_wal_file_action() could be defined in filemap.c.
>
That's a good point. I updated the patch to reflect that.
> > While this is unrelated to WAL logging, it could also contribute to faster
> >
Arseniy Mukhin writes:
> Sorry, I think I wasn't clear enough. I agree with this logic, but I
> think it implies an impossible scenario for the "equals" case. The
> scenario where during a scan we first have keys that are less than
> orig_datum, and then a key that is equal to orig_datum. Why I th
Oops, it looks like renaming the test_dsm_registry functions wasn't a good
idea:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2025-07-02%2017%3A11%3A10
Will fix...
--
nathan
Committed.
--
nathan
On 2025/07/02 22:24, Fujii Masao wrote:
On 2025/07/02 19:10, Anthonin Bonnefoy wrote:
Hi,
I've been looking at page cache usage as some of our replicas were
under memory pressure (no inactive pages available) which led to WAL
replay lag as the recovery process had to read from disk. One th
On Wed, Jul 2, 2025 at 10:56 PM Japin Li wrote:
>
> On Tue, 01 Jul 2025 at 22:00, Japin Li wrote:
> > On Tue, 01 Jul 2025 at 13:39, Álvaro Herrera wrote:
> >> On 2025-Jul-01, Japin Li wrote:
> >>
> >>> This inconsistency, while minor, could be confusing when cross-referencing
> >>> LSNs within p
On 2025/07/03 0:31, Álvaro Herrera wrote:
On 2025-Jul-02, Fujii Masao wrote:
Regarding the 0003 patch:
+ if (($11 & CAS_NOT_ENFORCED) != 0)
+ ereport(ERROR,
+
Committed.
--
nathan
> On 2 Jul 2025, at 04:51, Steve Chavez wrote:
> While updating an extension to support 18beta1, I stumbled on the removal of
> `pg_attribute_noreturn()` in favor of `pg_noreturn`, which wasn't mentioned
> in the release notes.
That admittedly seems like something worth including since it's ot
On Wed, 2 Jul 2025 at 12:02, Aleksander Alekseev
wrote:
> It seems like cfbot.cputube.org started to miss a *few* entries since
> CF started. Does it have anything to do with the CF application
> update?
That's fixed now.
On Wed, Jun 18, 2025 at 1:07 PM shveta malik wrote:
>
> On Wed, Jun 18, 2025 at 6:06 AM Masahiko Sawada wrote:
> >
> > Thank you for the comments!
> >
> > >
> > > 2)
> > > I see that when primary switches back its effective wal_level to
> > > replica while standby has wal_level=logical in conf fi
Hi,
This is a follow-up to b45242fd30ff [1]. Previously we separated
varlena.c into varlena.c and bytea.c. This patch makes
bytea_sortsupport() independent from varlena.c code as it was proposed
before [2][3]. The benefits of this change are summarized in the
commit message that I included to the
Dean Rasheed writes:
> On Sat, 21 Jun 2025 at 22:21, Tom Lane wrote:
>> The attached patch does what was discussed in the pgsql-docs
>> thread at [1], namely change the four-argument variants of
>> width_bucket() to allow their first argument to be NaN,
>> treating that value as larger than any n
On 2025-Jul-02, Fujii Masao wrote:
> Regarding the 0003 patch:
>
> + if (($11 & CAS_NOT_ENFORCED) != 0)
> + ereport(ERROR,
> +
> errmsg("constraint triggers
Hi Peter,
Thanks for your detailed analysis. I appreciate you digging deeper into the
root cause.
For this patch, I'd like to keep the changes to `initdb` minimal and
focused on rejecting empty usernames, as that seems to be the consensus
from the previous discussion.
I'll be happy to discuss th
On 2025/07/02 23:19, Andres Freund wrote:
Hi,
On July 2, 2025 10:15:09 AM EDT, Fujii Masao
wrote:
On 2025/07/02 23:04, Andres Freund wrote:
Hi,
On 2025-07-02 22:55:16 +0900, Fujii Masao wrote:
On 2025/06/24 1:32, Xuneng Zhou wrote:
3. The proposed solution
If the above analysis is s
On 2025/07/02 23:31, Fujii Masao wrote:
On 2025/07/01 3:27, Álvaro Herrera wrote:
On 2025-Jun-30, Álvaro Herrera wrote:
Just one note: Jian's patch doesn't handle the same issue for TRIGGER
case, so that part might still need to be addressed.
Okay, here's my take on this, wherein I rewo
On Wed, Jul 2, 2025 at 5:45 AM Ivan Kush wrote:
>
> Thanks for the clarification! I thought linker flags should be installed
> globally for all compilation targets.
Not for libcurl, since the libpq-oauth module split.
> Another question:
>
> Why don't we set LIBS in the configure in "checking fo
John Naylor writes:
> After pushing my fix, I looked into this, and CI works around this by
> disabling ICU. A proper fix was discussed here, but it trailed off:
> https://www.postgresql.org/message-id/flat/20230311033727.koa4saxy5wyquu6s%40awork3.anarazel.de#03346c63050bbc69dfca8981a5698e4a
> I c
>> Actually, I think there's a problem with this approach...
You're right. I forgot we can reset the table options. While we could
use a placeholder and resolve it on-demand, that seems like too much
work.
> On 2 Jul 2025, at 16:29, Dagfinn Ilmari Mannsåker wrote:
> I noticed that the PL/Perl makefile makes the use of the -output option
> conditional on coverage+vpath, because that option is not supported
> until Perl 5.9.3. But these days we require Perl 5.14, so we can remove
> that conditional
On 02.07.25 04:55, Jianghua Yang wrote:
While working with `initdb`, I noticed that passing an empty string to
the `-U` option (e.g., `initdb -U ''`) causes it to fail with a
misleading error:
performing post-bootstrap initialization ... 2025-07-01 19:48:42.006 PDT
[14888] FATAL:role """ does
On 2025/07/01 3:27, Álvaro Herrera wrote:
On 2025-Jun-30, Álvaro Herrera wrote:
Just one note: Jian's patch doesn't handle the same issue for TRIGGER
case, so that part might still need to be addressed.
Okay, here's my take on this, wherein I reworded the proposed error
message. I also ha
Hi hackers,
Based on the suggestion that we should explicitly reject empty usernames
instead of silently falling back, I’ve updated the patch accordingly.
### Changes in v2:
- `initdb` now errors out immediately if the `-U` or `--username` argument
is an empty string.
- The error message is:
On Wed, Jul 2, 2025 at 7:05 PM Etsuro Fujita wrote:
> On Tue, Jul 1, 2025 at 4:42 PM Amit Langote wrote:
> > On Tue, Jul 1, 2025 at 11:55 AM Etsuro Fujita
> > wrote:
> > > While working on something else, I noticed that while we disallow
> > > transition tables on foreign tables, we allow trans
Hi hackers,
I noticed that the PL/Perl makefile makes the use of the -output option
conditional on coverage+vpath, because that option is not supported
until Perl 5.9.3. But these days we require Perl 5.14, so we can remove
that conditional (which also matches what Meson does). Please see the
at
On 2025/07/02 19:10, Anthonin Bonnefoy wrote:
Hi,
I've been looking at page cache usage as some of our replicas were
under memory pressure (no inactive pages available) which led to WAL
replay lag as the recovery process had to read from disk. One thing
I've noticed was that the last WAL file
Hi,
On July 2, 2025 10:15:09 AM EDT, Fujii Masao
wrote:
>
>
>On 2025/07/02 23:04, Andres Freund wrote:
>> Hi,
>>
>> On 2025-07-02 22:55:16 +0900, Fujii Masao wrote:
>>> On 2025/06/24 1:32, Xuneng Zhou wrote:
3. The proposed solution
If the above analysis is sound, one potential
Thanks for the feedback!
I've updated the test to use `command_fails_like()` instead of
`command_fails()`, so it now asserts that the error message matches the
expected stderr output.
I also changed the test invocation to use the `-U => ''` syntax for
consistency, as seen in the adjacent `--userna
On 2025/07/02 23:04, Andres Freund wrote:
Hi,
On 2025-07-02 22:55:16 +0900, Fujii Masao wrote:
On 2025/06/24 1:32, Xuneng Zhou wrote:
3. The proposed solution
If the above analysis is sound, one potential fix would be to add
separate branching for standby in XactLockTableWait. However, thi
On Thu, Jun 5, 2025 at 3:00 AM Andres Freund wrote:
>
> > > The dereference is not reachable
> > > because of the preceding "var->datatype->typlen == -1" check,
> > > but that's not stopping the optimizer from bitching.
> >
> > > I experimented with modifying exec_set_found thus:
> > >
> > > v
> On 2 Jul 2025, at 15:52, Jianghua Yang wrote:
>
> Hi hackers,
>
> Based on the suggestion that we should explicitly reject empty usernames
> instead of silently falling back, I’ve updated the patch accordingly.
>
> ### Changes in v2:
>
> - `initdb` now errors out immediately if the `-U` or
Jianghua Yang writes:
> - A regression test is added to `src/bin/initdb/t/001_initdb.pl` to verify
> that the case `initdb -U ''` fails as expected.
[ ... ]
> diff --git a/src/bin/initdb/t/001_initdb.pl b/src/bin/initdb/t/001_initdb.pl
> index 15dd10ce40a..67eb53064f6 100644
> --- a/src/bin/initd
Hi,
On 2025-07-02 22:55:16 +0900, Fujii Masao wrote:
> On 2025/06/24 1:32, Xuneng Zhou wrote:
> > 3. The proposed solution
> >
> > If the above analysis is sound, one potential fix would be to add
> > separate branching for standby in XactLockTableWait. However, this seems
> > inconsistent with t
On 2025/06/24 1:32, Xuneng Zhou wrote:
Hi,
Here's patch version 4.
1. The problem
I conducted further investigation on this issue. The 1ms sleep in XactLockTableWait that
falls back to polling was not problematic in certain scenarios prior to v16. It became an
potential issue after the
On Wed, Jul 2, 2025 at 1:04 PM Dilip Kumar wrote:
> On Tue, Jul 1, 2025 at 7:12 PM Amit Langote wrote:
> > I’ve been working on improving how we handle partition locking during
> > execution of generic plans. Specifically, I committed a patch to defer
> > locking of partitions until after pruning
Thanks for the clarification! I thought linker flags should be installed
globally for all compilation targets.
Another question:
Why don't we set LIBS in the configure in "checking for curl_multi_init"
using LIBCURL_LIBS or LIBCURL_LDFLAGS?
https://github.com/postgres/postgres/blob/master/co
On 7/2/25 13:37, Ashutosh Bapat wrote:
> On Wed, Jul 2, 2025 at 12:37 AM Tomas Vondra wrote:
>>
>>
>> 3) v1-0003-freelist-Don-t-track-tail-of-a-freelist.patch
>>
>> Minor optimization. Andres noticed we're tracking the tail of buffer
>> freelist, without using it. So the patch removes that.
>>
Hi Dmitry,
Thanks for sharing the patches.
On Fri, Jun 20, 2025 at 3:49 PM Dmitry Dolgov <9erthali...@gmail.com> wrote:
> 3. Shared memory shrinking
>
> So far only shared memory increase was implemented. These patches from
> Ashutosh
> support shrinking as well, which is tricky due to the need
On Wed, Jul 2, 2025 at 12:36 PM shveta malik wrote:
>
> On Wed, Jul 2, 2025 at 10:50 AM Ashutosh Bapat
> wrote:
> >
> > Hi All,
> >
> > The failover slots documentation [1] is good for PG - PG logical
> > replication, but the first two queries require pg_subscription which
> > may not be present
On 27.06.25 19:24, Daniel Gustafsson wrote:
The OpenSSL code in libpq have two issues for multithreading: the verify_cb
callback use a global variable to pass back error detail state and there is one
use of strerror().
Slightly misleading title: This is actually about the *backend* libpq code.
On Wed, Jul 2, 2025 at 12:37 AM Tomas Vondra wrote:
>
>
> 3) v1-0003-freelist-Don-t-track-tail-of-a-freelist.patch
>
> Minor optimization. Andres noticed we're tracking the tail of buffer
> freelist, without using it. So the patch removes that.
>
The patches for resizing buffers use the lastFreeB
On 02.07.25 09:22, Nazir Bilal Yavuz wrote:
One thing I’m unsure about the patch is that all these features are
stored in the MESON_FEATURES environment variable in each task. I
wonder if it might be clearer to rename these variables to
${TASK_NAME}_MESON_FEATURES to avoid confusion.
I would ho
On 30.06.25 05:21, Daniil Davydov wrote:
Hi,
I noticed that some asserts and cycles use magic numbers 1 and 0
instead of BTLessStrategyNumber and InvalidStrategy.
At the same time, the BTMaxStrategyNumber macro is used there.
I suggest using appropriate macros for 1 and 0 values.
This code, bot
On Thu, 15 May 2025 at 16:16, Kirill Panin wrote:
>
> Hi hackers!
>
> The "cube" extention is frequently used for vectors, but the current
> implementation lacks support for binary operators, such as +, -, *, /.
> The attached (fairly trivial) patch adds support for these with the
> required docum
Hi,
On Wed, Jul 02, 2025 at 06:39:25AM +, Bertrand Drouvot wrote:
> Hi,
>
> On Tue, Jul 01, 2025 at 07:46:30PM +0200, Tomas Vondra wrote:
> > On 7/1/25 19:20, Bertrand Drouvot wrote:
> > > Now it's just a matter of extracting the necessary pieces from
> > > pg_buffercache_numa_pages()
> > >
Hi,
I've been looking at page cache usage as some of our replicas were
under memory pressure (no inactive pages available) which led to WAL
replay lag as the recovery process had to read from disk. One thing
I've noticed was that the last WAL files are in the pagecache even
after having been repla
Hi Amit-san,
On Tue, Jul 1, 2025 at 4:42 PM Amit Langote wrote:
> On Tue, Jul 1, 2025 at 11:55 AM Etsuro Fujita wrote:
> > While working on something else, I noticed that while we disallow
> > transition tables on foreign tables, we allow transition tables on
> > partitioned tables with foreign-
Hi,
> > > Ugh... Turns out it was a bug, there definitely should be a "New
> > > patch" button on both the 19-1 and on the Drafts page. And there
> > > was... but only if you were logged in as a staff user.
> >
> > There is now a "New patch" button on the CF entry page. Many thanks!
>
> I felt we
On Tue, Jun 24, 2025 at 4:11 PM Ajin Cherian wrote:
>
> Hello,
>
> Creating this thread for a POC based on discussions in thread [1].
> Hou-san had created this patch, and I just cleaned up some documents,
> did some testing and now sharing the patch here.
>
> In this patch, the pg_sync_replicatio
> On 2 Jul 2025, at 10:06, Bertrand Drouvot
> wrote:
> On Wed, Jul 02, 2025 at 09:55:52AM +0200, Daniel Gustafsson wrote:
>> how about the attached?
>
> LGTM.
Thanks, committed.
--
Daniel Gustafsson
On 2/7/2025 11:14, Richard Guo wrote:
On Wed, Jul 2, 2025 at 4:32 PM Andrei Lepikhov wrote:
I must say that I appreciate Tom's idea and see significant benefits in
making the parse tree a read-only structure. In complex queries, it can
be frustrating to make copies of the parse tree, leading to
Álvaro, Andrey, Alexander, hello!
Since the master branch became the PG19dev and PG18 is now stable, I
have directed this patch into PG19. Could we continue with it now?
Álvaro, should I rename the SimpleLruZeroPageExt function?
Best regards,
Evgeny Voropaev.
On 14.03.2025 21:43, Evgeny wro
On Tue, Jul 1, 2025 at 10:54 PM torikoshia wrote:
>
> Hi,
>
> Thanks for updating the patch and I've read
> v17-0001-COPY-on_error-set_null.patch and here are some comments.
>
> + if (current_row_erroneous)
> + cstate->num_errors++;
>
> Is there any reason this error counting i
1 - 100 of 121 matches
Mail list logo
