Re: Improve CRC32C performance on SSE4.2

2025-06-14 Thread Andy Fan
Jesper Pedersen writes: Hi, Thank you Nathan, Tomas and Jesper for the answers. The patch at [0] works for me and I could work with master smoothly now. > On 6/14/25 9:56 AM, Nathan Bossart wrote: >> I'm also genuinely curious why folks are using -O0... >> > > Personally, I use > > -O0 -fno-o

Re: Handling OID Changes in Regression Tests for C Extensions

2025-06-14 Thread Michael Paquier
On Sat, Jun 14, 2025 at 11:20:31AM -0400, Tom Lane wrote: > Tomas Vondra writes: >> The OIDs for user-defined objects (e.g. those from extensions) are not >> stable, and this will not change. The only way is to prevent the test >> output, e.g. by not including OIDs in the results, and eliminating

Re: Replace some %llu remnants in the tree

2025-06-14 Thread Michael Paquier
On Thu, Jun 12, 2025 at 08:13:08PM -0400, Andres Freund wrote: > FWIW, I find it utterly unsurpising that new users of %llu were introduced > after 15a79c73111f. For one, 15a79c73111f explicitly says "(minimal trial)" in > the subject line, it'd have hardly been sensible to introduce PRI* uses at >

Re: Non-reproducible AIO failure

2025-06-14 Thread Konstantin Knizhnik
On 13/06/2025 11:20 pm, Andres Freund wrote: Hi, On 2025-06-12 12:23:13 -0400, Andres Freund wrote: On 2025-06-12 11:52:31 -0400, Andres Freund wrote: On 2025-06-12 17:22:22 +0300, Konstantin Knizhnik wrote: On 12/06/2025 4:57 pm, Andres Freund wrote: The problem appears to be in that swit

[PATCH] Fix incomplete memory clearing in OAuth authentication

2025-06-14 Thread Taras Kloba
Hi hackers, I discovered a minor security issue in the OAuth authentication code where sensitive bearer tokens are not completely cleared from memory. ## The Issue In src/backend/libpq/auth-oauth.c, the oauth_exchange() function attempts to clear the bearer token from memory using explicit_bzero

Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward

2025-06-14 Thread Dimitrios Apostolou
On Sat, 14 Jun 2025, Dimitrios Apostolou wrote: On Fri, 13 Jun 2025, Nathan Bossart wrote: On Fri, Jun 13, 2025 at 01:00:26AM +0200, Dimitrios Apostolou wrote: By the way, I might have set the threshold to 1MB in my program, but lowering it won't show a difference in my test case, since th

Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward

2025-06-14 Thread Dimitrios Apostolou
On Fri, 13 Jun 2025, Nathan Bossart wrote: On Fri, Jun 13, 2025 at 01:00:26AM +0200, Dimitrios Apostolou wrote: By the way, I might have set the threshold to 1MB in my program, but lowering it won't show a difference in my test case, since the lseek()s I was noticing before the patch were mostl

Re: Replication slot is not able to sync up

2025-06-14 Thread Dilip Kumar
On Fri, May 30, 2025 at 3:38 PM Zhijie Hou (Fujitsu) wrote: > > On Wed, May 28, 2025 at 2:09 AM Masahiko Sawada wrote: > > > > On Fri, May 23, 2025 at 10:07 PM Amit Kapila > > wrote: > > > > > > In the case presented here, the logical slot is expected to keep > > > forwarding, and in the consecut

Re: Handling OID Changes in Regression Tests for C Extensions

2025-06-14 Thread Tom Lane
Tomas Vondra writes: > On 6/14/25 11:43, Lakshmi Narayana Velayudam wrote: >> I am facing a challenge related to OID changes in regression tests while >> working on a PostgreSQL C extension. Whenever I add or remove a function >> to the SQL file, it alters OIDs and leads to cascading modifications

Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

2025-06-14 Thread David E. Wheeler
On Jun 4, 2025, at 11:27, David E. Wheeler wrote: > And these should fix the CI failure. I also ran pgindent. Here’s a quick rebase. I think it’s ready for committer review, but since I’ve poked at it quite a bit myself, I updated the Commitfest item [1] to “Needs Review”. Best, David [1]:

Re: Improve CRC32C performance on SSE4.2

2025-06-14 Thread Jesper Pedersen
Hi Nathan, On 6/14/25 9:56 AM, Nathan Bossart wrote: I'm also genuinely curious why folks are using -O0... Personally, I use -O0 -fno-omit-frame-pointer for FlameGraph [1] investigations. [1] https://github.com/brendangregg/FlameGraph Best regards, Jesper

Re: Improve CRC32C performance on SSE4.2

2025-06-14 Thread Tomas Vondra
On 6/14/25 15:56, Nathan Bossart wrote: > On Sat, Jun 14, 2025 at 03:47:33PM +0200, Tomas Vondra wrote: >> I suggest you try with a newer gcc, perhaps 13.4. There's been a bunch >> of fixes related to AVX512 since 13.0, chances are this was already >> fixed. I don't see this failure on 14.3.1. >

Re: Improve CRC32C performance on SSE4.2

2025-06-14 Thread Nathan Bossart
On Sat, Jun 14, 2025 at 03:47:33PM +0200, Tomas Vondra wrote: > I suggest you try with a newer gcc, perhaps 13.4. There's been a bunch > of fixes related to AVX512 since 13.0, chances are this was already > fixed. I don't see this failure on 14.3.1. >From the config.log, it looks like Andy is usin

Re: Handling OID Changes in Regression Tests for C Extensions

2025-06-14 Thread Tomas Vondra
Hello Narayana, On 6/14/25 11:43, Lakshmi Narayana Velayudam wrote: > Dear pg-hackers, > > I am facing a challenge related to OID changes in regression tests while > working on a PostgreSQL C extension. Whenever I add or remove a function > to the SQL file, it alters OIDs and leads to cascading m

Re: Improve CRC32C performance on SSE4.2

2025-06-14 Thread Tomas Vondra
Hi, I suggest you try with a newer gcc, perhaps 13.4. There's been a bunch of fixes related to AVX512 since 13.0, chances are this was already fixed. I don't see this failure on 14.3.1. T. On 6/14/25 12:24, Andy Fan wrote: > Hi, > > Recently I always get below error during initdb. > > """ > UT

Handling OID Changes in Regression Tests for C Extensions

2025-06-14 Thread Lakshmi Narayana Velayudam
Dear pg-hackers, I am facing a challenge related to OID changes in regression tests while working on a PostgreSQL C extension. Whenever I add or remove a function to the SQL file, it alters OIDs and leads to cascading modifications in multiple test files. This creates a significant overhead in mai

Re: Proposal: Global Index for PostgreSQL

2025-06-14 Thread Dilip Kumar
On Mon, Jun 9, 2025 at 3:28 PM Dilip Kumar wrote: > > On Mon, Jun 9, 2025 at 2:03 PM Nikita Malakhov wrote: > > 4) Update-heavy partitioned tables that should run vacuum frequently. > > Significant > > vacuum slowdown would result in going beyond SLAs without corresponding > > significant impro

pglogical3 : support

2025-06-14 Thread Perumal Raj
Hi Team, I am looking to upgrade pg17 with near zero downtime using logical replication(master <-> master) . The current pglogical2 ( open) has some limitation with 'REPLICA IDENTITY FULL' tables. Do we have any plan to make pglogical3 open source in near future? 😊 or is there better way to ach

Resolved: Logical Replication slot disappeared after promote Standby

2025-06-14 Thread Perumal Raj
On Fri, Jun 13, 2025 at 9:46 PM Amit Kapila wrote: > On Fri, Jun 13, 2025 at 10:52 PM Perumal Raj wrote: > > > > Thanks for explanation Shveta! > > > > > > As Summary in this original thread, > > > > Prerequisites for Setting Up a Logical Replication Slot sync in >= pg17 > > > > To

Re: pg_dump --with-* options

2025-06-14 Thread Fujii Masao
On 2025/06/14 5:32, Nathan Bossart wrote: On Fri, Jun 13, 2025 at 08:58:04AM -0700, Jeff Davis wrote: On Fri, 2025-06-13 at 09:39 +0900, Fujii Masao wrote: By the way, if we keep --with-statistics in pg_dump, are we planning to continue using the --with-xxx naming pattern for new options tha

Re: Make tuple deformation faster

2025-06-14 Thread David Rowley
On Sat, 7 Jun 2025 at 23:00, Alexander Lakhin wrote: > #5 0x5dd0a1788377 in ExceptionalCondition (conditionName=0x5dd0a1822ee8 > "memcmp(&tmp, cattr, sizeof(CompactAttribute)) == 0", > fileName=0x5dd0a1822ed9 "tupdesc.c", lineNumber=165) at assert.c:66 Thanks for finding that and for th