Re: Should fix a comment referring to stats collector?

2024-12-27 Thread Junwang Zhao
On Tue, Oct 31, 2023 at 11:02 PM Bruce Momjian wrote: > > On Mon, Aug 1, 2022 at 09:05:45PM +0900, torikoshia wrote: > > On 2022-07-30 02:53, Alvaro Herrera wrote: > > > > > I don't think this refers to the statistics collector process; I > > > understand it to refer to ANALYZE that captures the

Re: Proposal: add new API to stringinfo

2024-12-27 Thread Tatsuo Ishii
Michael said: > New APIs are materials for HEAD, so recompilation needs to happen > anyway. Using a macro makes things slightly simpler and it would not > break unnecessarily the compilation of existing extensions. Ok. David said: > I didn't review the patch in detail, but I think "initsize" wou

Re: Expand applicability of aggregate's sortop optimization

2024-12-27 Thread Andrei Lepikhov
On 12/11/24 07:22, Michael Paquier wrote: On Fri, Nov 08, 2024 at 01:05:04PM +0700, Andrei Lepikhov wrote: Rebase onto current master and slight improvement. Your patch is failing in the CI, please rebase. I have it to the next CF for now, waiting on author. Thanks, I overlooked the fact tha

Re: Logging parallel worker draught

2024-12-27 Thread Sami Imseih
Thanks for rebasing. I took a look and have some high level comments. 1/ The way the patches stand now, different parallel commands will result in a different formatted log line. This may be OK for reading the logs manually, but will be hard to consume via tools that parse logs and if we support

RE: Connection limits/permissions, slotsync workers, etc

2024-12-27 Thread Zhijie Hou (Fujitsu)
On Saturday, December 28, 2024 1:31 AM Tom Lane wrote: > > "Zhijie Hou (Fujitsu)" writes: > > On Thursday, December 26, 2024 3:50 AM Tom Lane > >> I wonder if the AV launcher and slotsync worker could be reclassified > >> as "auxiliary processes" instead of being their own weird animal. > > >

Re: Add the ability to limit the amount of memory that can be allocated to backends.

2024-12-27 Thread Tomas Vondra
On 12/27/24 20:14, James Hunter wrote: > Reviving this thread, because I am thinking about something related -- > please ignore the "On Fri, Dec 27, 2024" date, this seems to be an > artifact of me re-sending the message, from the list archive. The > original message was from January 28, 2024. >

Re: PoC: history of recent vacuum/checkpoint runs (using new hooks)

2024-12-27 Thread Tomas Vondra
On 12/27/24 05:00, Michael Paquier wrote: > On Thu, Dec 26, 2024 at 06:58:11PM +0100, Tomas Vondra wrote: >> If 128MB is insufficient, why would 256MB be OK? A factor of 2x does not >> make a fundamental difference ... >> >> Anyway, the 128MB value is rather arbitrary. I don't mind increasing th

Re: [PATCHES] Post-special page storage TDE support

2024-12-27 Thread David Christensen
On Fri, Dec 27, 2024 at 1:58 PM Bruce Momjian wrote: > > On Fri, Dec 27, 2024 at 12:25:11PM -0500, Greg Sabino Mullane wrote: > > On Fri, Dec 27, 2024 at 10:12 AM Bruce Momjian wrote: > > > > The value of TDE is limited from a security value perspective, but high > > on > > the list of s

Re: More reliable nbtree detection of unsatisfiable RowCompare quals involving a leading NULL key/element

2024-12-27 Thread Peter Geoghegan
On Mon, Dec 23, 2024 at 1:02 PM Peter Geoghegan wrote: > Attached patch fixes the problem by moving detection of RowCompare > unsatisfiable-due-to-NULL cases into _bt_fix_scankey_strategy. Attached is v2, which adds several new regression tests, giving certain relevant nbtree code paths test cove

Re: Add Postgres module info

2024-12-27 Thread David E. Wheeler
On Dec 26, 2024, at 20:09, Andrei Lepikhov wrote: > We intentionally wrote a library, not an extension. According to user usage > and upgrade patterns, it works across the whole instance and in any database > or locally in a single backend and ends its impact at the end of its life. The same i

Re: Connection limits/permissions, slotsync workers, etc

2024-12-27 Thread Tom Lane
Also, here's a patch for the rest of what I was talking about. We'll need to back-patch this given that the CVE-2024-10978 changes caused these sorts of problems in all branches, but I've not yet attempted to back-patch. It looks like it might be a bit painful thanks to past code churn in these a

Re: [PATCHES] Post-special page storage TDE support

2024-12-27 Thread Bruce Momjian
On Fri, Dec 27, 2024 at 12:25:11PM -0500, Greg Sabino Mullane wrote: > On Fri, Dec 27, 2024 at 10:12 AM Bruce Momjian wrote: > > The value of TDE is limited from a security value perspective, but high on > the list of security policy requirements.  Our community is much more > respons

Re: Add the ability to limit the amount of memory that can be allocated to backends.

2024-12-27 Thread James Hunter
Reviving this thread, because I am thinking about something related -- please ignore the "On Fri, Dec 27, 2024" date, this seems to be an artifact of me re-sending the message, from the list archive. The original message was from January 28, 2024. On Fri, Dec 27, 2024 at 11:02 AM Tomas Vondra wro

Re: RFC: Allow EXPLAIN to Output Page Fault Information

2024-12-27 Thread Jeremy Schneider
On Fri, 27 Dec 2024 15:15:40 +0100 "Jelte Fennema-Nio" wrote: > On Tue Dec 24, 2024 at 4:52 PM CET, Tom Lane wrote: > > torikoshia writes: > >> I have attached a PoC patch that modifies EXPLAIN to include page > >> fault information during both the planning and execution phases of > >> a query

Re: Connection limits/permissions, slotsync workers, etc

2024-12-27 Thread Tom Lane
"Zhijie Hou (Fujitsu)" writes: > On Thursday, December 26, 2024 3:50 AM Tom Lane >> I wonder if the AV launcher and slotsync worker could be reclassified as >> "auxiliary >> processes" instead of being their own weird animal. > It appears that the current aux processes do not run transactions a

Re: [PATCHES] Post-special page storage TDE support

2024-12-27 Thread Greg Sabino Mullane
On Fri, Dec 27, 2024 at 10:12 AM Bruce Momjian wrote: > The value of TDE is limited from a security value perspective, but high on > the list of security policy requirements. Our community is much more > responsive to actual value vs policy compliance value. > True. The number of forks, though,

Re: [PATCHES] Post-special page storage TDE support

2024-12-27 Thread Greg Sabino Mullane
Re-reading this thread, and this has been nagging me: On Mon, Nov 13, 2023 at 3:03 PM David Christensen < david.christen...@crunchydata.com> wrote: > - so why do we need to recompute offsets on every single page? I'd >> instead > > add a distinct offset variable for each feature. >> > > This

Re: POC: make mxidoff 64 bits

2024-12-27 Thread Maxim Orlov
On Wed, 18 Dec 2024 at 13:21, Heikki Linnakangas wrote: > > Attached is some more cleanup on top of patch set v9, removing more dead > stuff related to wraparound. I also removed the oldestOffsetKnown > variable and related code. It was needed to deal with clusters upgraded > from buggy 9.3 and 9

Re: Re: proposal: schema variables

2024-12-27 Thread jian he
hi. + if (!OidIsValid(varid)) + AcceptInvalidationMessages(); + else if (OidIsValid(varid)) + LockDatabaseObject(VariableRelationId, varid, 0, AccessShareLock); we can change it to + if (!OidIsValid(varid)) + AcceptInvalidationMessages(); + else + LockDatabaseObject(VariableRelationId, varid, 0,

Re: An improvement of ProcessTwoPhaseBuffer logic

2024-12-27 Thread Vitaly Davydov
On Friday, December 27, 2024 10:37 MSK, Michael Paquier wrote: > So please see the attached. You will note that RemoveTwoPhaseFile(), > ProcessTwoPhaseBuffer() and TwoPhaseFilePath() now require a > FullTransactionId, hence callers need to think about the epoch to use. > That should limit futur

Re: [PATCHES] Post-special page storage TDE support

2024-12-27 Thread Bruce Momjian
On Thu, Dec 12, 2024 at 09:15:55AM -0600, David Christensen wrote: > On Tue, Dec 10, 2024 at 12:54 AM Michael Paquier wrote: > > > > On Wed, Mar 13, 2024 at 11:26:48AM -0500, David Christensen wrote: > > > Enclosing v4 for this patch series, rebased atop the > > > constant-splitting series[1]. Fo

Re: cannot to compile extension by meson on windows

2024-12-27 Thread Pavel Stehule
pá 27. 12. 2024 v 9:50 odesílatel Vladlen Popolitov < v.popoli...@postgrespro.ru> napsal: > Pavel Stehule писал(а) 2024-12-01 20:52: > > Hi > > > > Did somebody test compilation of any extension on the WIN platform by > > using meson? > > > > I prepared meson.build > > https://github.com/orafce/or

Re: FileFallocate misbehaving on XFS

2024-12-27 Thread Bruce Momjian
On Fri, Dec 20, 2024 at 01:25:41PM +0100, Jakub Wartak wrote: > On Thu, Dec 19, 2024 at 7:49 AM Michael Harris wrote: > No one else has responded, so I'll try. My take is that we got very limited > number of reports (2-3) of this stuff happening and it always seem to be >90% > space used, yet the

Re: RFC: Allow EXPLAIN to Output Page Fault Information

2024-12-27 Thread Jelte Fennema-Nio
On Tue Dec 24, 2024 at 4:52 PM CET, Tom Lane wrote: torikoshia writes: I have attached a PoC patch that modifies EXPLAIN to include page fault information during both the planning and execution phases of a query. Surely these numbers would be too unstable to be worth anything. What makes y

Remove support for OpenSSL *eay32 libs on Windows

2024-12-27 Thread Daniel Gustafsson
The thread in [0] which adds Meson support for *eay32 OpenSSL library names on Windows reminded me that we should remove these from master since we no longer support OpenSSL 1.0.2 (which was the final version with those names). Attached is a small (as of yet untested on Windows/autoconf) diff remo

Re: [Bug Fix]standby may crash when switching-over in certain special cases

2024-12-27 Thread px shi
Hi, I inserted the following code in walsender.c:2509(v15.8) to reproduce the issue. { WalSnd *walsnd = MyWalSnd; SpinLockAcquire(&walsnd->mutex); if (walsnd->flush % wal_segment_size == 0 && walsnd->sentPtr == walsnd->flush && walsnd->flush > wal_segment_size)

Re: add support for the old naming libs convention on windows (ssleay32.lib and libeay32.lib)

2024-12-27 Thread Daniel Gustafsson
> On 9 Dec 2024, at 07:25, Darek Ślusarczyk wrote: > I've prepared another patch: > - it prioritizes libssl and libcrypto over ssleay32 and libeay32 > - it checks ssleay32 and libeay32 on windows only > - I tested it locally on both lnx/win enforcing various possible scenarios I'm neither a Wind

Re: Exists pull-up application with JoinExpr

2024-12-27 Thread Ilia Evdokimov
Hi Alena, Thank you for your work on subqueries with JOIN. Have you considered the scenario where in subquery includes a qual like (tc.aid = 1)? When I tried executing those queries I receive different results. In my opinion, to prevent this, we should add filters for such quals within the lo

Re: Test to dump and restore objects left behind by regression

2024-12-27 Thread Daniel Gustafsson
> On 20 Dec 2024, at 11:01, Ashutosh Bapat wrote: > On Wed, Dec 18, 2024 at 7:39 PM Daniel Gustafsson wrote: >> >>> On 18 Dec 2024, at 12:28, Ashutosh Bapat >>> wrote: >> + if ( $ENV{PG_TEST_EXTRA} >> + && $ENV{PG_TEST_EXTRA} =~ /\bregress_dump_test\b/) >> Should this also test that

Bug and memory leaks with access to file links with long names (Windows, MSVS)

2024-12-27 Thread Vladlen Popolitov
Hi! PostgreSQL build under Windows with MS Visual Studio has functions to work with links (unlike msys2 that has own functions). If a database has link pointing to location longer 130 chars, function pgreadlink fails to recognise this link and cancels query. The reason of the error - small b

RE: Connection limits/permissions, slotsync workers, etc

2024-12-27 Thread Zhijie Hou (Fujitsu)
On Thursday, December 26, 2024 3:50 AM Tom Lane Hi, > In connection with the discussion at [1], I started to look at exactly which > server > processes ought to be subject to connection limits (datconnlimit, > ACL_CONNECT, and related checks). The current situation seems to be an > inconsisten

Re: Fix bank selection logic in SLRU

2024-12-27 Thread Andrey Borodin
> On 19 Dec 2024, at 20:48, Yura Sokolov wrote: > > Here's version with type change bits16 -> uint16 Thanks! This version looks good to me. I’ll mark the CF entry as RfC. Best regards, Andrey Borodin.

Re: Convert macros to static inline functions

2024-12-27 Thread Peter Eisentraut
On 16.05.22 10:27, Peter Eisentraut wrote: Inspired by [0], I looked to convert more macros to inline functions. This is an older thread where I left something unfinished: Note 2: Many macros in htup_details.h operate both on HeapTupleHeader and on MinimalTuple, so converting them to a functi

RE: Logical Replication of sequences

2024-12-27 Thread Hayato Kuroda (Fujitsu)
Dear Vignesh, Thanks for updating the patch! Here are my comments. 01. SyncingRelationsState ``` * SYNC_RELATIONS_STATE_NEEDS_REBUILD The subscription relations state is no * longer valid and the subscription relations should be rebuilt. ``` Can we follow the style like other lines? Like: SY

Re: Logical replication timeout

2024-12-27 Thread RECHTÉ Marc
> Right, because of the reason I posted [1]. > > I updated the patch which did the same approach. It could pass my CI. > Could you please apply on 17.2 and test it? > > [1]: > https://www.postgresql.org/message-id/OSCPR01MB14966B646506E0C9B81B3A4CFF5022%40OSCPR01MB14966.jpnprd01.prod.outlook.com

Re: pure parsers and reentrant scanners

2024-12-27 Thread Heikki Linnakangas
On 26/12/2024 20:27, Peter Eisentraut wrote: On 22.12.24 22:43, Andreas Karlsson wrote: On 12/19/24 9:57 PM, Peter Eisentraut wrote: Here is an updated patch set on top of what has been committed so far, with all the issues you pointed out addressed. Other than the discussion of how old versi

Re: Windows meson build

2024-12-27 Thread Vladlen Popolitov
Vladlen Popolitov писал(а) 2024-12-27 09:57: Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31: Hi, Thank you for your advice. I added a sample setting PKG_CONFIG_PATH based on your advice. How do you think about this? Regards, Kohei Harikae Hi, From my point of view it looks good. Actual

Re: cannot to compile extension by meson on windows

2024-12-27 Thread Vladlen Popolitov
Pavel Stehule писал(а) 2024-12-01 20:52: Hi Did somebody test compilation of any extension on the WIN platform by using meson? I prepared meson.build https://github.com/orafce/orafce/blob/master/meson.build I tested it successfully on Linux. But it fails on Windows - a lot of compilation fail

Re: Crash: invalid DSA memory alloc request

2024-12-27 Thread Andreas 'ads' Scherbaum
On Wed, Dec 18, 2024 at 2:42 AM Andreas 'ads' Scherbaum wrote: > On 17/12/2024 22:32, Nathan Bossart wrote: > > Committed. > > > > Thanks, I see you backpatched it all the way to 13. > Will see how far back I can test this, will take a while. > Was able to test HEAD in all branches back to 13, n

RE: Memory leak in pg_logical_slot_{get,peek}_changes

2024-12-27 Thread Zhijie Hou (Fujitsu)
On Thursday, December 26, 2024 8:01 PM vignesh C wrote: > > Here is an updated version which includes registers to reset the memory > context that is in-line with a recently committed patch at [1]. Thanks for updating patches ! They look good to me. Just to confirm, would the other stuff (strea