On Sat, Oct 12, 2024, at 02:48, jian he wrote:
> git version 2.34.1
> cannot do `git apply`
Sorry about that, fixed.
> typedef enum CopyFormat
> {
> COPY_FORMAT_TEXT,
> COPY_FORMAT_BINARY,
> COPY_FORMAT_CSV
> } CopyFormat;
Thanks, fixed.
> CopyFormat should add to
> src/tools/pginde
Hi,
Zhang Mingli
www.hashdata.xyz
On Oct 12, 2024 at 07:48 +0800, Joel Jacobson , wrote:
>
> Add missing checks for FORCE_NOT_NULL and FORCE_NULL when applied to
> all columns via "*". These options now correctly require CSV mode and
> are disallowed in COPY TO as appropriate.
Right.
we introduc
On Sat, Oct 12, 2024, at 01:48, Joel Jacobson wrote:
> Hi hackers,
>
> Here is a patch that fixes a minor problem in copy.c's ProcessCopyOptions,
> as well as fixing thinko in its tests, as well as adding new tests for
> the bugfix.
Rebase only.
/Joel
v2-0001-Fix-thinko-in-tests-for-COPY-options
On Sat, Oct 12, 2024 at 5:02 AM Joel Jacobson wrote:
>
> On Fri, Oct 11, 2024, at 22:29, Joel Jacobson wrote:
> > Hi hackers,
> >
> > This thread is about implementing a new "raw" COPY format.
> ...
> > The attached patch implements the above ideas.
> >
> > I think with these changes, it would be
Hi,
On Thu, Oct 10, 2024 at 10:37 PM Bertrand Drouvot
wrote:
>
> Hi hackers,
>
> While working on [1], I noticed that we missed using
> deconstruct_array_builtin()
> in 062a8444242.
>
> Indeed, d746021de1 added construct_array_builtin and deconstruct_array_builtin
> but , later on, 062a8444242 m
Hi,
I realized an obsolete comment in the definition of ReorderBufferTXN.
Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
allocating ReorderBufferTXN entries instead of using a caching
mechanism, so the txn->node is no longer used as an element of the
list of preallocated Reorder
On Fri, Oct 11, 2024 at 11:15 AM Masahiko Sawada wrote:
>
> On Fri, Oct 11, 2024 at 6:15 AM Bertrand Drouvot
> wrote:
> >
> > Hi,
> >
> > On Thu, Oct 10, 2024 at 05:38:43PM -0700, Masahiko Sawada wrote:
> > > On Thu, Oct 10, 2024 at 6:10 AM Bertrand Drouvot
> > > wrote:
> > >
> > > The patches m
Hi hackers,
Here is a patch that fixes a minor problem in copy.c's ProcessCopyOptions,
as well as fixing thinko in its tests, as well as adding new tests for
the bugfix.
[PATCH 1/2] Fix thinko in tests for COPY options force_not_null
and force_null.
Use COPY FROM for the negative tests that chec
On Thu, Oct 10, 2024 at 1:41 PM Peter Geoghegan wrote:
> The main simplification new to v4 is that v4 isolates the need to call
> _bt_drop_lock_and_maybe_pin to only 2 functions: _bt_readnextpage, and
> its new _bt_readfirstpage "sibling" function. The functions have
> similar preconditions, and i
This is a rebased version.
I have split queries, vacuum and index creation in different patches.
I have also split the declartion that are in common with the
pg_stat_database patch.
--
Benoit Lobréau
Consultant
http://dalibo.comFrom cfa426a080ca2d0c484ac8f5201800bd6434 Mon Sep 17 00:00:00
On 10/11/24 09:33, Guillaume Lelarge wrote:
FWIW, with the recent commits of the pg_stat_statements patch, you need
a slight change in the patch I sent on this thread. You'll find a patch
attached to do that. You need to apply it after a rebase to master.
Thanks.
Here is an updated version, I
On Mon, 2024-09-23 at 08:57 +0800, jian he wrote:
> newtup = heap_modify_tuple_by_cols(ctup, tupdesc, ncols,
> replaces, nulls);
>
> you just directly declared "bool nulls[3] = {false, false,
> false};"
Those must be false (not NULL), because in pg_class those are non-NULL
attributes. They
On Fri, Oct 11, 2024 at 09:47:58AM -0400, Andrew Dunstan wrote:
> On 2024-10-10 Th 6:28 PM, Tom Lane wrote:
>> On the whole I agree with Heikki's comment that we should just
>> do it (disallow MD5, full stop) whenever we feel that enough
>> time has passed. These intermediate states are mostly goi
> On 5 Sep 2024, at 00:10, Daniel Gustafsson wrote:
> Thanks for reviewing, I plan on going ahead with this patch shortly.
That ended up not being shortly, but having spent a fair bit of time reading
the diff over and testing on multiple versions of OpenSSL and LibreSSL I've now
pushed it. The
On Fri, Oct 11, 2024, at 22:29, Joel Jacobson wrote:
> Hi hackers,
>
> This thread is about implementing a new "raw" COPY format.
...
> The attached patch implements the above ideas.
>
> I think with these changes, it would be easier to hack on new and existing
> copy options and formats.
>
> /Joel
Hi hackers,
This thread is about implementing a new "raw" COPY format.
This idea came up in a different thread [1], moved here.
[1] https://postgr.es/m/47b5c6a7-5c0e-40aa-8ea2-c7b95ccf296f%40app.fastmail.com
The main use-case for the raw format, is when needing to import arbitrary
unstructured
On Fri, Oct 11, 2024, at 15:04, Joel Jacobson wrote:
> On Thu, Oct 10, 2024, at 10:37, Daniel Verite wrote:
>> Joel Jacobson wrote:
>>
>>> - No Headers or Metadata:
>>
>> It's not clear why it's necessary to disable the HEADER option
>> for this format?
>
> It's not necessary, no, just couldn't see
On Fri, Oct 11, 2024 at 6:15 AM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Thu, Oct 10, 2024 at 05:38:43PM -0700, Masahiko Sawada wrote:
> > On Thu, Oct 10, 2024 at 6:10 AM Bertrand Drouvot
> > wrote:
> >
> > The patches mostly look good to me. Here are some minor comments:
>
> Thanks for looking at
pá 11. 10. 2024 v 18:08 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > I tested it and it is working nicely. I tested it against Orafce and I
> > found an interesting point. The body of plpgsql functions is not checked.
> > Do you know the reason?
>
> In execute_extension_script():
>
>
Hi,
On Thu, Sep 19, 2024 at 07:54:21AM +, Bertrand Drouvot wrote:
> Hi,
>
> On Wed, Sep 18, 2024 at 04:04:53PM -0500, Nathan Bossart wrote:
> > On Thu, Sep 05, 2024 at 04:59:54AM +, Bertrand Drouvot wrote:
> > > Please find attached v6, a mandatory rebase due to catversion bump
> > > con
On Fri, Oct 11, 2024 at 4:20 PM Alexander Korotkov
wrote:
> This is all for now. The feedback is welcome.
>
Just figured out, I forgot the patchset itself. Here it goes.
--
Regards,
Alexander Korotkov
Supabase
v41-0001-Transform-OR-clauses-to-SAOP-s-during-index-matc.patch
Description:
Pavel Stehule writes:
> I tested it and it is working nicely. I tested it against Orafce and I
> found an interesting point. The body of plpgsql functions is not checked.
> Do you know the reason?
In execute_extension_script():
/*
* Similarly disable check_function_bodies, to ensure th
On Fri, Oct 11, 2024 at 11:09:30AM +0900, Fujii Masao wrote:
> On 2024/10/08 23:36, Nathan Bossart wrote:
>> The patch posted upthread looks reasonable to me, so I'll go commit it soon
>> unless there is any feedback.
>
> Thanks! The patch looks good to me, too.
Committed.
--
nathan
Hi
Did you post the wrong link? This one looks same as the one I mentioned. Though
I realized that you have replied to this thread:
https://www.postgresql.org/message-id/56EA3507.6090701%40anastigmatix.net
Regards, Steve.
> On Oct 11, 2024, at 8:42 PM, Chapman Flack wrote:
>
> On 10/11/24 01
Hi,
With PG17's new SAOP handling the performance of certain index scans
significantly improved performance in the serial case. However, for
parallel index scans the performance picture is not as
straightforward, and this has caused some issues earlier.
Background
--
Before PG17, we had o
On 2024-10-10 Th 6:28 PM, Tom Lane wrote:
Andrew Dunstan writes:
Hmm, yeah. It would be easy enough to prevent MD5 passwords in things
like CREATE ROLE / ALTER ROLE, but harder to check for MD5 if there are
direct updates to pg_authid. Maybe we need to teach pg_dumpall a way to
do that as a w
Hi
út 8. 10. 2024 v 22:18 odesílatel Tom Lane napsal:
> I wrote:
> > ... There's still a question
> > of whether reporting the whole script as the query is OK when
> > we have a syntax error, but I have no good ideas as to how to
> > make that terser.
>
> I had an idea about this: we can use a p
Hi, Robert!
Thank you so much for your very valuable review. It took some time to
address all the points. Hopefully I didn't miss anything.
On Fri, Oct 4, 2024 at 4:34 PM Robert Haas wrote:
> On Mon, Sep 23, 2024 at 7:11 AM Alexander Korotkov
wrote:
> > Makes sense. Please, check the attache
Hi,
On Fri, Oct 11, 2024 at 12:59:33PM +1100, Peter Smith wrote:
> Hi, Here are a few comments for patch set v13*
Thanks for looking at it.
> //
>
> Patch v13-0001
>
> ==
> Commit message
>
> 1.1
> /were no use case/was no use case/
Updated in v14 just shared up-thread.
> ~~~
>
On Fri, 2024-10-11 at 20:45 +1300, David Rowley wrote:
> diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
> index ff689b6524..861b9cf0bc 100644
> --- a/doc/src/sgml/perform.sgml
> +++ b/doc/src/sgml/perform.sgml
> @@ -578,6 +578,34 @@ WHERE t1.unique1 < 100 AND t1.unique2 = t2.uni
Hi,
On Thu, Oct 10, 2024 at 05:38:43PM -0700, Masahiko Sawada wrote:
> On Thu, Oct 10, 2024 at 6:10 AM Bertrand Drouvot
> wrote:
>
> The patches mostly look good to me. Here are some minor comments:
Thanks for looking at it!
>
> + sprintf(path, "%s/%s",
> + PG_LOGI
On Thu, Oct 10, 2024, at 10:37, Daniel Verite wrote:
> Joel Jacobson wrote:
>
>> - No Headers or Metadata:
>
> It's not clear why it's necessary to disable the HEADER option
> for this format?
It's not necessary, no, just couldn't see a use-case,
since I only thought about the COPY FROM case
where
On 10/11/24 01:33, Steve Lau wrote:
> Before hitting the issue, I thought -1 will be passed if and only if
> this type does not have type modifiers, as it is indeed unknown. However,
> it surprises me that it could also be unknown if your type needs
> type modifiers and the type modifiers have been
> [v5]
0001 - LGTM, maybe can be squashed with 0009?
0002 - I went through this again and don't see anything that should
raise eyebrows.
+ # HACK: insert our own %nonassoc line after IDENT.
+ # XXX: this seems pretty wrong, IDENT is not last on its line!
We can come back to this afterwards, as
On Fri, 11 Oct 2024 at 22:19, jian he wrote:
> array subscript 0 is outside array bounds of ‘char[0]’
> [-Werror=array-bounds=]
> 230 | (((varattrib_1b_e *) (PTR))->va_tag)
> |^
Please read the thread at
https://postgr.es/m/flat/CAFj8pRBJD_Y-Xcq
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, meson buildtype=release works fine.
gcc-14.1.0 meson buildtype=debug works fines
but the $SUBJECT error occurred.
my system: ubuntu1~22.04
[1409/1982] Compiling C object src/pl/plpgsql/src/plpgsql.so.p/pl_exec.c.o
FAILED: src/pl/plpgsql/src/plpgsql.so.p/
{
"emoji": "❤️",
"version": 1
}
Hello,
Add a reference method for shared_memory_size_in_huge_pages
with the "SHOW" command.
The current documentation explains the use of the postgres -C command,
but this method may be limited in DBaaS or managed service environments.
In particular, CloudNativePG does not allow the server to be
Hi,
On Fri, Oct 11, 2024 at 11:07:29AM +0300, Kouber Saparev wrote:
> На чт, 10.10.2024 г. в 17:42 Bertrand Drouvot
> написа:
>
> >
> > Does the error message looks like (added in [1]):
> >
> > "
> > trying to drop stats entry already dropped: kind=%s dboid=%u objoid=%u
> > refcount=%u",
> > "
>
On 11/10/2024 09:59, Yushi Ogiwara wrote:
Hi,
I found the attributes of the functions consume_xids and
consume_xids_until are incorrectly specified:
- Both functions are marked as IMMUTABLE attribute, but they advance the
transaction ID, which modifies the system state. Thus, they should be
ma
На чт, 10.10.2024 г. в 17:42 Bertrand Drouvot
написа:
>
> Does the error message looks like (added in [1]):
>
> "
> trying to drop stats entry already dropped: kind=%s dboid=%u objoid=%u
> refcount=%u",
> "
>
> by any chance? If so, would you mind to share it?
>
> Regards,
>
> [1]: https://postgr
On Fri, 11 Oct 2024 21:00:47 +1300
David Rowley wrote:
> On Fri, 11 Oct 2024 at 20:53, Yugo Nagata wrote:
> > It is not applied to the web (yet?), though.
> > https://www.postgresql.org/docs/17/release-17.html
>
> Those will only be updated when 17.1 is released.
Thank you for letting me know
On 2024/10/11 16:18, Yugo NAGATA wrote:
On Fri, 11 Oct 2024 14:44:43 +0800
px shi wrote:
+1
Materialized view is introduced by 3bf3ab8c563 and at that UNLOGGED was
allowed, and it is disallowed by another commit 3223b25ff73. However,
it seems that the tab-complement is missed to fixed.
> On 7 Oct 2024, at 22:04, Nathan Bossart wrote:
>
> On Mon, Oct 07, 2024 at 03:37:35PM -0400, Bruce Momjian wrote:
>> On Tue, Oct 1, 2024 at 09:28:54AM +0200, Daniel Gustafsson wrote:
>>> Correct, sorry for being unclear. The consistency argument would be to
>>> expand
>>> pg_upgrade to repor
On Fri, 11 Oct 2024 at 20:53, Yugo Nagata wrote:
> It is not applied to the web (yet?), though.
> https://www.postgresql.org/docs/17/release-17.html
Those will only be updated when 17.1 is released.
David
On Thu, 26 Sep 2024 14:21:27 +0900
Yugo NAGATA wrote:
> On Thu, 26 Sep 2024 13:27:54 +0930
> Tom Dunstan wrote:
>
> > On Thu, 26 Sept 2024 at 13:21, Yugo Nagata wrote:
> >
> > > By the way, this is not mentioned in CREATE MATERIALIZED VIEW
> > > documentation, although
> > > we can find in RE
On Fri, 11 Oct 2024 at 19:44, Laurenz Albe wrote:
>
> On Fri, 2024-10-11 at 17:24 +1300, David Rowley wrote:
> > I've now pushed this change and will look at the docs now.
>
> Thanks you for taking care of that!
I've attached a patch for this. It's very similar to your patch and in
the same locat
On Fri, 11 Oct 2024 13:54:54 +0900 (JST)
Tatsuo Ishii wrote:
> >>> Thanks for the fix. Here is the new run with the v2 patch. The result
> >>> looks good to me.
> >>>
> >>> src/bin/pgbench/pgbench -p 11002 -c1 -t 1 -f c.sql -f d.sql
> >>> --failures-detailed -r test
> >>> pgbench (18devel)
> >
Le mar. 8 oct. 2024 à 14:03, Benoit Lobréau a
écrit :
> On 10/7/24 10:19, Guillaume Lelarge wrote:
> > I've done the split, but I didn't go any further than that.
>
> Thank you Guillaume. I have done the rest of the reformatting
> suggested by Michael but I decided to see If I have similar stuff
Robert,
On Fri, Oct 11, 2024 at 5:15 AM Robert Haas wrote:
>
> Hi Amit,
>
> This is not a full review (sorry!) but here are a few comments.
Thank you for taking a look.
> In general, I don't have a problem with this direction. I thought
> Tom's previous proposal of abandoning ExecInitNode() in
On Fri, 11 Oct 2024 14:44:43 +0800
px shi wrote:
> >
> > +1
> >
> > Materialized view is introduced by 3bf3ab8c563 and at that UNLOGGED was
> > allowed, and it is disallowed by another commit 3223b25ff73. However,
> > it seems that the tab-complement is missed to fixed.
Sorry, the comment above
51 matches
Mail list logo
