Re: Obsolete comment in pg_stat_statements

2024-09-14 Thread Julien Rouhaud
On Sat, 14 Sept 2024, 23:44 Tom Lane, wrote: > Julien Rouhaud writes: > > On Sat, 14 Sept 2024, 12:39 Tom Lane, wrote: > >> Hmm ... I agree that para is out of date, but is there anything to > >> salvage rather than just delete it? > > > I thought about it but I think that now that knowledge is

[PATCH] WIP: replace method for jsonpath

2024-09-14 Thread Florents Tselai
Hi,When working with jsonb/jsonpath, I’ve always wanted more fluent string operations for data cleaning.Ideally, chaining text processing methods together.Here’s a draft patch that adds a string replace method.It works like thisselect jsonb_path_query('"hello world"', '$.replace("hello","bye")'); j

Re: Detailed release notes

2024-09-14 Thread Bruce Momjian
On Fri, Sep 13, 2024 at 12:39:28PM -0400, Bruce Momjian wrote: > I applied this patch to PG 17. You can see the results at: > > https://momjian.us/pgsql_docs/release-17.html > > The community doc build only shows the master branch, which is PG 18, > and the PG 17 docs are only built before

Re: Why don't we consider explicit Incremental Sort?

2024-09-14 Thread Tomas Vondra
On 9/14/24 05:37, Richard Guo wrote: > On Fri, Sep 13, 2024 at 7:35 PM Tomas Vondra wrote: >> On 9/13/24 06:04, Richard Guo wrote: >>> It seems to me that some parts of our code assume that, for a given >>> input path that is partially ordered, an incremental sort is always >>> preferable to a ful

Re: Why don't we consider explicit Incremental Sort?

2024-09-14 Thread Tomas Vondra
On 9/14/24 05:50, Richard Guo wrote: > On Fri, Sep 13, 2024 at 7:51 PM Tomas Vondra wrote: >> Sure, an incremental sort can improve things if things go well, no doubt >> about that. But how significant can the improvement be, especially if we >> need to sort everything? In your example it's ~15

Re: may be a mismatch between the construct_array and construct_md_array comments

2024-09-14 Thread Alena Rybakina
On 12.09.2024 20:44, Tom Lane wrote: Alena Rybakina writes: I noticed that there is a comment that values ​​with NULL are not processed there, but in fact this function calls the construct_md_array function, which contains a comment that it can handle NULL values. Right. construct_md_array ha

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-14 Thread Thomas Munro
On Sun, Sep 15, 2024 at 8:32 AM Thomas Munro wrote: > template copy trick, is that robocopy.exe tries to use Windows' block Erm, sorry for my fumbled early morning message editing and garbled English... I meant to write "one thing I noticed is that..".

Re: Regression tests fail with tzdata 2024b

2024-09-14 Thread Tom Lane
Wolfgang Walther writes: > Building --with-system-tzdata and the latest tzdata 2024b fails the > regression tests for me (see attached .diffs). This seems to be because > of [1], which changed the way "PST8PDT" is handled. This is the timezone > that the regression tests are run with. That's q

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-14 Thread Thomas Munro
On Sun, Sep 15, 2024 at 1:00 AM Alexander Lakhin wrote: > (That is, 0.1-0.2 MB leaks per one robocopy run.) > > I observed this on Windows 10 (Version 10.0.19045.4780), with all updates > installed, but not on Windows Server 2016 (10.0.14393.0). Moreover, using > robocopy v14393 on Windows 10 does

Cleaning up ERRCODE usage in our XML code

2024-09-14 Thread Tom Lane
I noticed while working on bug #18617 [1] that we are fairly slipshod about which SQLSTATE to report when libxml2 returns an error. There are places using ERRCODE_INTERNAL_ERROR for easily-triggered errors; there are different places that use different ERRCODEs for exactly the same condition; and

Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

2024-09-14 Thread Akshat Jaimini
Hi, Quick question, are there any more revisions left to be done on this patch from the previous feedback? Or should I continue with reviewing the current patch? Regards, Akshat Jaimini

Re: access numeric data in module

2024-09-14 Thread Ed Behn
Good afternoon- Was there a resolution of this? I'm wondering if it is worth it for me to submit a PR for the next commitfest. -Ed On Mon, Sep 9, 2024 at 8:40 PM Ed Behn wrote: > Sorry for taking so long to respond. I was at my day-job. > > As I mentioned, I am the maintainer

Re: Psql meta-command conninfo+

2024-09-14 Thread Tom Lane
Alvaro Herrera writes: > I don't understand why this is is printing half the information in > free-form plain text and the other half in tabular format. All these > items that you have in the free-form text lines should be part of the > table, I think. +1, that was my reaction as well. I can se

Re: Psql meta-command conninfo+

2024-09-14 Thread Alvaro Herrera
On 2024-Sep-14, Hunaid Sohail wrote: > I agree that both messages should be printed together. IMO the message > "You are connected to database..." should be printed at the top, no? > Because it shows important info that the user may be interested to see > first. Then we can combine the ssl message

Re: Obsolete comment in pg_stat_statements

2024-09-14 Thread Tom Lane
Julien Rouhaud writes: > On Sat, 14 Sept 2024, 12:39 Tom Lane, wrote: >> Hmm ... I agree that para is out of date, but is there anything to >> salvage rather than just delete it? > I thought about it but I think that now that knowledge is in the else > branch, with the mention that we still have

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-14 Thread Alexander Lakhin
Hello Andrew, 14.09.2024 17:22, Andrew Dunstan wrote: On 2024-09-14 Sa 9:00 AM, Alexander Lakhin wrote: While trying to reproduce inexplicable drongo failures (e. g., [1]) seemingly related to BackgroundPsql, I stumbled upon close, but not the same issue. ... Interesting, good detective wor

Re: why there is not VACUUM FULL CONCURRENTLY?

2024-09-14 Thread Junwang Zhao
On Wed, Sep 4, 2024 at 7:41 PM Antonin Houska wrote: > > Junwang Zhao wrote: > > > Thanks for working on this, I think this is a very useful feature. > > > > The patch doesn't compile in the debug build with errors: > > > > ../postgres/src/backend/commands/cluster.c: In function ‘get_catalog_stat

Re: Mutable foreign key constraints

2024-09-14 Thread Tom Lane
Andrew Dunstan writes: > On 2024-09-12 Th 5:33 PM, Tom Lane wrote: >> I'm inclined to propose rejecting FK constraints if the comparison >> operator is not immutable. > Isn't there an upgrade hazard here? People won't thank us if they can't > now upgrade their clusters. If we can get around that

Re: meson vs windows perl

2024-09-14 Thread Andrew Dunstan
On 2024-07-30 Tu 3:47 PM, Andrew Dunstan wrote: On 2024-07-20 Sa 9:41 AM, Andrew Dunstan wrote: On 2024-05-28 Tu 6:13 PM, Andres Freund wrote: Hi, On 2024-04-05 16:12:12 -0400, Andrew Dunstan wrote: OK, this has been fixed and checked. The attached is what I propose. The perl command is p

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-14 Thread Andrew Dunstan
On 2024-09-14 Sa 9:00 AM, Alexander Lakhin wrote: Hello hackers, While trying to reproduce inexplicable drongo failures (e. g., [1]) seemingly related to BackgroundPsql, I stumbled upon close, but not the same issue. After many (6-8 thousands) iterations of the 015_stream.pl TAP test, psql fai

Re: Detailed release notes

2024-09-14 Thread Bruce Momjian
On Fri, Sep 13, 2024 at 05:54:31PM -0400, Bruce Momjian wrote: > On Fri, Sep 13, 2024 at 06:41:30PM -0300, Marcos Pegoraro wrote: > > Em sex., 13 de set. de 2024 às 13:39, Bruce Momjian > > escreveu: > > > > I changed the patch to use the section symbol "§" instead of showing > > the hash

Re: First draft of PG 17 release notes

2024-09-14 Thread Bruce Momjian
On Wed, Sep 11, 2024 at 07:50:40PM +0200, Álvaro Herrera wrote: > There's also a bunch of items on EXPLAIN, which could perhaps be grouped > in a single item with sub-paras for each individual change; I'd also > move it to the bottom of E.1.3.2. Oh, I hadn't noticed I have five EXPLAIN items --- t

Regression tests fail with tzdata 2024b

2024-09-14 Thread Wolfgang Walther
Building --with-system-tzdata and the latest tzdata 2024b fails the regression tests for me (see attached .diffs). This seems to be because of [1], which changed the way "PST8PDT" is handled. This is the timezone that the regression tests are run with. From 2024b on, "PST8PDT" is the same as "

Re: Psql meta-command conninfo+

2024-09-14 Thread Hunaid Sohail
Hi Jim, On Fri, Sep 13, 2024 at 4:27 PM Jim Jones wrote: > I just noticed that messages' order has been slightly changed. The > message "You are connected to database "postgres" as user "hunaid" via > socket in "/tmp" at port "5430" used to be printed after the table, and > now it is printed bef

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-14 Thread Tomas Vondra
On 9/12/24 16:49, Matthias van de Meent wrote: > On Mon, 9 Sept 2024 at 21:55, Peter Geoghegan wrote: >> > ... > > The fix in 0001 is relatively simple: we stop backends from waiting > for a concurrent backend to resolve the NEED_PRIMSCAN condition, and > instead move our local state machine so t

Re: Use streaming read API in ANALYZE

2024-09-14 Thread Mats Kindahl
On Fri, Sep 13, 2024 at 10:10 AM Mats Kindahl wrote: > On Tue, Sep 10, 2024 at 6:04 AM Thomas Munro > wrote: > >> On Tue, Sep 10, 2024 at 10:27 AM Thomas Munro >> wrote: >> > Mats, what do you think about >> > this? (I haven't tried to preserve the prefetching behaviour, which >> > probably di

Re: Mutable foreign key constraints

2024-09-14 Thread Andrew Dunstan
On 2024-09-12 Th 5:33 PM, Tom Lane wrote: I happened to notice that Postgres will let you do regression=# create table foo (id timestamp primary key); CREATE TABLE regression=# create table bar (ts timestamptz references foo); CREATE TABLE This strikes me as a pretty bad idea, because whether

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

2024-09-14 Thread Tatsuo Ishii
>> > or the case when the last usage fit in memory but an earlier >> > usage spilled to disk. >> >> In my understanding once tuplestore changes the storage type to disk, >> it never returns to the memory storage type in terms of >> tuplestore_get_stats. i.e. once state->usedDisk is set to true, it