Re: tests fail on windows with default git settings

2024-07-13 Thread Thomas Munro
On Fri, Jul 12, 2024 at 3:49 AM Dave Page wrote: > So I received an off-list tip to checkout [1], a discussion around GSSAPI > causing test failures on windows that Alexander Lakhin was looking at. Thomas > Munro's v2 patch to try to address the issue brought me down to just a single > test fai

Re: MAINTAIN privilege -- what do we need to un-revert it?

2024-07-13 Thread Noah Misch
On Fri, Jul 12, 2024 at 04:50:17PM -0700, Jeff Davis wrote: > On Fri, 2024-07-12 at 16:11 -0700, Noah Misch wrote: > > Since refresh->relation is a RangeVar, this departs from the standard > > against > > repeated name lookups, from CVE-2014-0062 (commit 5f17304). > > Interesting, thank you. > >

Re: Remove dependence on integer wrapping

2024-07-13 Thread Nathan Bossart
On Sat, Jul 13, 2024 at 10:24:16AM -0400, Joseph Koshakow wrote: > On Fri, Jul 12, 2024 at 12:49 PM Nathan Bossart > wrote: >> IIUC some of these changes are bug fixes. Can we split out the bug fixes >> to their own patches so that they can be back-patched? > > They happen to already be split ou

Re: Remove dependence on integer wrapping

2024-07-13 Thread Joseph Koshakow
On Fri, Jul 12, 2024 at 12:49 PM Nathan Bossart wrote: > On Sat, Jul 06, 2024 at 07:04:38PM -0400, Joseph Koshakow wrote: >> I've added another patch, 0004, to resolve the jsonb wrap-arounds. >> >> The other patches, 0001, 0002, and 0003 are unchanged but have their >> version number incremented.

Re: Things I don't like about \du's "Attributes" column

2024-07-13 Thread Pavel Luzanov
On 12.07.2024 12:22, Rafia Sabih wrote: Other thoughts came to my mind, should we have this column in \du+ instead, maybe connection limit too. I know in the current version we have all this in \du itself, but then all clubbed in one column. But now since our table has got wider, it might be aest

RE: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-07-13 Thread Zhijie Hou (Fujitsu)
On Tuesday, July 9, 2024 8:53 PM Hayato Kuroda (Fujitsu) wrote: > > > 0001 - Codes for SUBOPT_TWOPHASE_COMMIT are moved per requirement > [1]. > >Also, checks for failover and two_phase are unified into one > > function. > > 0002 - updated accordingly. An argument for the check function

Re: [PATCH] TODO “Allow LISTEN on patterns”

2024-07-13 Thread Alexander Cheshev
Hi Emanuel, I did a test over the "UNLISTEN >" behavior, and I'm not sure if this is > expected. > This command I assume should free all the listening channels, however, it > doesn't > seem to do so: TODO “Allow LISTEN on patterns” [1] is a bit vague about that feature. So I didn't implement it