Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

2024-06-29 Thread Noah Misch
On Thu, Jun 06, 2024 at 05:21:46PM +0900, Kyotaro Horiguchi wrote: > At Thu, 06 Jun 2024 17:15:15 +0900 (JST), Kyotaro Horiguchi > wrote in > > By the way, the need to shift by 2 seconds to tolerate clock skew > > suggests that the current launcher-postmaster association mechanism is > > somewha

Re: Built-in CTYPE provider

2024-06-29 Thread Noah Misch
On Wed, Mar 20, 2024 at 05:13:26PM -0700, Jeff Davis wrote: > On Tue, 2024-03-19 at 13:41 +0100, Peter Eisentraut wrote: > > * v25-0002-Support-C.UTF-8-locale-in-the-new-builtin-collat.patch > > > > Looks ok. > > Committed. > > + pg_c_utf8 > + > + > +This collati

Re: Flush pgstats file during checkpoints

2024-06-29 Thread Tomas Vondra
On 6/28/24 09:32, Konstantin Knizhnik wrote: > > On 18/06/2024 9:01 am, Michael Paquier wrote: >> Hi all, >> >> On HEAD, xlog.c has the following comment, which has been on my own >> TODO list for a couple of weeks now: >> >>   * TODO: With a bit of extra work we could just start with a >>

Re: pgsql: Add more SQL/JSON constructor functions

2024-06-29 Thread Tom Lane
Alvaro Herrera writes: >> +/* >> + * For domains, consider the base type's typmod to decide whether to >> setup >> + * an implicit or explicit cast. >> + */ >> +if (get_typtype(returning->typid) == TYPTYPE_DOMAIN) >> +(void) getBaseTypeAndTypmod(returning->typid, &

Re: pgsql: Add more SQL/JSON constructor functions

2024-06-29 Thread Alvaro Herrera
> diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c > index 233b7b1cc9..df766cdec1 100644 > --- a/src/backend/parser/parse_expr.c > +++ b/src/backend/parser/parse_expr.c > @@ -3583,6 +3583,7 @@ coerceJsonFuncExpr(ParseState *pstate, Node *expr, > Node *res;

Re: Optimize numeric.c mul_var() using the Karatsuba algorithm

2024-06-29 Thread Tom Lane
Dean Rasheed writes: > There's another complication though (if the threshold is made > configurable): the various numeric functions that use mul_var() are > immutable, which means that the results from the Karatsuba algorithm > must match those from the schoolbook algorithm exactly, for all > inpu

Re: Optimize numeric.c mul_var() using the Karatsuba algorithm

2024-06-29 Thread Dean Rasheed
On Sun, Jun 23, 2024 at 09:00:29AM +0200, Joel Jacobson wrote: > Attached, rebased version of the patch that implements the Karatsuba > algorithm in numeric.c's mul_var(). > Something to watch out for is that not all callers of mul_var() want an exact result. Several internal callers request an a

Re: LogwrtResult contended spinlock

2024-06-29 Thread Alexander Lakhin
Hi Alvaro, Thank you for looking at this! 29.06.2024 13:23, Alvaro Herrera wrote: TRAP: failed Assert("TYPEALIGN(8, (uintptr_t)(&currval)) == (uintptr_t)(&currval)"), File: "...\src\include\port/atomics.h", Line: 597, PID: 7556 child process was terminated by exception 0xC409 Oh. This is

Re: LogwrtResult contended spinlock

2024-06-29 Thread Alvaro Herrera
Hi On 2024-Jun-29, Alexander Lakhin wrote: > --- stderr --- > TRAP: failed Assert("TYPEALIGN(8, (uintptr_t)(&currval)) == > (uintptr_t)(&currval)"), File: "...\src\include\port/atomics.h", Line: 597, > PID: 7556 > child process was t

Re: Converting README documentation to Markdown

2024-06-29 Thread Jelte Fennema-Nio
On Fri, 28 Jun 2024 at 20:40, Peter Eisentraut wrote: > I have my "less" set up so that "less somefile.md" automatically renders > the markdown. That's been pretty useful. But if that now keeps making > a mess out of PostgreSQL's README files, then I'm going to have to keep > fixing things, and

Re: cfbot update: Using GitHub for patch review

2024-06-29 Thread Jelte Fennema-Nio
On Sat, 29 Jun 2024 at 01:13, Thomas Munro wrote: > > On Sat, Jun 29, 2024 at 1:10 AM Ashutosh Bapat > wrote: > > I need to sign in to github to add my review comments. So those who do not > > have a github account can not use it for review. But I don't think that can > > be fixed. We need a wa

Re: LogwrtResult contended spinlock

2024-06-29 Thread Alexander Lakhin
Hello Alvaro and Bharath, 07.04.2024 15:19, Alvaro Herrera wrote: I pushed the "copy" pointer now, except that I renamed it to "insert", which is what we call the operation being tracked. I also added some comments. I've discovered that Windows x86 build fails tests after commit f3ff7bf83. Us