Re: meson and check-tests

2024-06-01 Thread Tom Lane
"Tristan Partin" writes: > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: >> We talked this off-list at the conference. It seems we have to somehow >> avoid passing pg_regress --schedule argument and instead pass the list of >> tests. Any idea how to do that? > I think there are 2 sol

Re: meson and check-tests

2024-06-01 Thread jian he
On Sun, Jun 2, 2024 at 4:48 AM Tristan Partin wrote: > > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: > > Hi Tristan, > > Using make I can run only selected tests under src/test/regress using > > TESTS=... make check-tests. I didn't find any way to do that with meson. > > meson test

Extension security improvement: Add support for extensions with an owned schema

2024-06-01 Thread Jelte Fennema-Nio
Writing the sql migration scripts that are run by CREATE EXTENSION and ALTER EXTENSION UPDATE are security minefields for extension authors. One big reason for this is that search_path is set to the schema of the extension while running these scripts, and thus if a user with lower privileges can cr

Fix grammar oddities in comments

2024-06-01 Thread James Coleman
Hi, See attached for a small patch fixing some typos and grammatical errors in a couple of comments. Side note: It's not clear to me what "Vars of higher levels don't matter here" means in this context (or how that claim is justified), but I haven't changed that part of the comment opting to simp

Re: meson and check-tests

2024-06-01 Thread Tristan Partin
On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: Hi Tristan, Using make I can run only selected tests under src/test/regress using TESTS=... make check-tests. I didn't find any way to do that with meson. meson test --suite regress runs all the regression tests. We talked this off-list

Re: pltcl crashes due to a syntax error

2024-06-01 Thread Tom Lane
"a.kozhemyakin" writes: > When executing the following query on master branch: > CREATE EXTENSION pltcl; > CREATE or replace PROCEDURE test_proc5(INOUT a text) >     LANGUAGE pltcl >     AS $$ >     set aa [concat $1 "+" $1] >     return [list $aa $aa]) >     $$; > CALL

Re: ResourceOwner refactoring

2024-06-01 Thread Alexander Lakhin
Hello Heikki, I've stumbled upon yet another anomaly introduced with b8bff07da. Please try the following script: SELECT 'init' FROM pg_create_logical_replication_slot('slot',   'test_decoding'); CREATE TABLE tbl(t text); BEGIN; TRUNCATE table tbl; SELECT data FROM pg_logical_slot_get_changes('s