At Fri, 2 Feb 2024 14:42:46 +0100, Thomas Munro wrote
in
> On Fri, Feb 2, 2024 at 12:56 PM Yugo NAGATA wrote:
> > On Fri, 2 Feb 2024 11:18:18 +0100
> > Thomas Munro wrote:
> > > One simple way to address that would be to make XLogFileInitInternal()
> > > wait for InstallXLogFileSegment() to fi
On Tue, 06 Feb 2024 09:39:09 +0900 (JST)
Kyotaro Horiguchi wrote:
> At Mon, 5 Feb 2024 17:22:56 +0900, Yugo NAGATA wrote in
> > On Mon, 05 Feb 2024 11:28:59 +0900
> > torikoshia wrote:
> >
> > > > Based on this, I've made a patch.
> > > > based on COPY Synopsis: ON_ERROR 'error_action'
> > >
On Tue, Feb 6, 2024 at 3:19 PM Amit Kapila wrote:
>
> On Mon, Feb 5, 2024 at 7:56 PM Masahiko Sawada wrote:
> >
> > ---
> > Since Two processes (e.g. the slotsync worker and
> > pg_sync_replication_slots()) concurrently fetch and update the slot
> > information, there is a race condition where sl
Hi,
On Tue, Feb 06, 2024 at 03:19:11AM +, Zhijie Hou (Fujitsu) wrote:
> On Friday, February 2, 2024 2:03 PM Bertrand Drouvot
> wrote:
> >
> > Hi,
> >
> > On Thu, Feb 01, 2024 at 05:29:15PM +0530, shveta malik wrote:
> > > Attached v75 patch-set. Changes are:
> > >
> > > 1) Re-arranged the
On Tue, Feb 6, 2024 at 8:30 AM Alexander Lakhin wrote:
>
> 05.02.2024 15:20, Amit Kapila wrote:
> > If this can be reproduced frequently then we can even try to test the
> > patch in that thread by Osumi-San [1] (I haven't tested that it
> > applies cleanly but shouldn't be difficult to make it wo
On Fri, Feb 2, 2024 at 3:11 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Euler,
>
> Thanks for updating the patch!
>
> >
> I'm still working on the data structures to group options. I don't like the
> way
> it was grouped in v13-0005. There is too many levels to reach database name.
> The setup_sub
Hi, I took another high-level look at all the funtion names of the
slotsync.c file.
==
src/backend/replication/logical/slotsync.c
+static bool
+local_slot_update(RemoteSlot * remote_slot, Oid remote_dbid)
+static List *
+get_local_synced_slots(void)
+static bool
+check_sync_slot_on_remote(R
On Fri, Dec 29, 2023 at 04:15:35PM +0300, Maxim Orlov wrote:
> Recently, one of our customers came to us with the question: why do reindex
> utility does not support multiple jobs for indices (-i opt)?
> And, of course, it is because we cannot control the concurrent processing
> of multiple indexes
On Mon, Feb 5, 2024 at 7:56 PM Masahiko Sawada wrote:
>
> ---
> Since Two processes (e.g. the slotsync worker and
> pg_sync_replication_slots()) concurrently fetch and update the slot
> information, there is a race condition where slot's
> confirmed_flush_lsn goes backward.
>
Right, this is possi
On Mon, Feb 05, 2024 at 09:46:42PM -0800, Andres Freund wrote:
> No - what I mean is that it doesn't make sense to have copy_attribute_out(),
> as e.g. CopyToTextOneRow() already knows that it's dealing with text, so it
> can directly call the right function. That does require splitting a bit more
On Fri, Feb 2, 2024 at 5:16 PM Masahiko Sawada wrote:
>
> On Fri, Feb 2, 2024 at 1:59 PM Shubham Khanna
> wrote:
> >
> > On Fri, Jan 26, 2024 at 2:07 PM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Dec 20, 2023 at 12:11 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Wed, Dec 20, 2023 at 6:4
On Mon, Oct 16, 2023 at 6:36 AM Alexander Korotkov wrote:
>
> > On Mon, Oct 16, 2023 at 02:47:03AM +0300, Alexander Korotkov wrote:
> > > The attached revision fixes test failures spotted by
> > > commitfest.cputube.org. Also, perl scripts passed perltidy.
>
> You are very fast and sharp eye!
> T
On Fri, Jan 19, 2024 at 11:04:50PM +0330, Majid Garoosi wrote:
> However, this value does not need to be larger than wal_segment_size,
> thus its checker function returns false if a larger value is set for
> this.
>
> This is my first patch. So, I hope I haven't done something wrong. :'D
You've d
Hi,
On 2024-02-06 11:41:06 +0900, Michael Paquier wrote:
> On Mon, Feb 05, 2024 at 05:41:25PM -0800, Andres Freund wrote:
> > On 2024-02-06 10:01:36 +0900, Michael Paquier wrote:
> >> If you have concerns about that, I'm OK to revert, I'm not wedded to
> >> this level of control. Note that I've a
Dear Sawada-san,
> Thank you for the review comments!
>
> >
> > A comment for 0001:
> >
> > 01.
> > ```
> > +static void
> > +bh_enlarge_node_array(binaryheap *heap)
> > +{
> > +if (heap->bh_size < heap->bh_space)
> > +return;
> > +
> > +heap->bh_space *= 2;
> > +heap->bh_node
Hi,
Previously ([1] #19 and #22) I had suggested that some conflict_reason
code could be split off and pushed first as a prerequisite/
preparatory/ independent patch.
At the time, my suggestion was premature because there was still a lot
of code under development.
But now the affected code is in
On Thu, Jan 25, 2024 at 10:39 PM jian he wrote:
>
> On Thu, Jan 25, 2024 at 7:54 PM Amit Langote wrote:
> >
> > >
> > > The problem with returning comp_domain_with_typmod from json_value()
> > > seems to be that it's using a text-to-record CoerceViaIO expression
> > > picked from JsonExpr.item_co
On Mon, Feb 05, 2024 at 06:05:04PM -0800, Andres Freund wrote:
> I don't really understand why we need to validate anything during COPY TO?
> Which is good, because it turns out that we don't actually validate anything,
> as pg_server_to_any() returns without doing anything if the encoding matches:
Hi,
Attached is a draft of the 2024-02-08 release announcement. Please
review for accuracy and notable omissions.
Please provide any feedback no later than 2024-02-08 12:00 UTC (and
preferably sooner).
Thanks,
Jonathan
The PostgreSQL Global Development Group has released an update to all s
On Mon, Feb 05, 2024 at 03:59:27PM +, Dagfinn Ilmari Mannsåker wrote:
> I just noticed that a couple of places in the docs spell I/O as IO or
> even io when not referring to literal table/view/column names or values
> therein. Here's a patch to fix them.
Makes sense to me to be consistent in
Here are some review comments for v78-0001
==
GENERAL
1.
Should the "Chapter 30 Logical Replication" at least have another
section that mentions the feature of slot synchronization so the
information about it is easier to find? It doesn't need to say much --
just give a reference to the other
On Tue Jan 30, 2024 at 3:58 PM CST, Andres Freund wrote:
Hi,
On 2024-01-30 09:59:25 -0600, Tristan Partin wrote:
> From 331cec1c9db6ff60dcc6d9ba62a9c8be4e5e95ed Mon Sep 17 00:00:00 2001
> From: Tristan Partin
> Date: Mon, 29 Jan 2024 18:03:39 -0600
> Subject: [PATCH v1 1/3] Refuse to register m
On Friday, February 2, 2024 2:03 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Thu, Feb 01, 2024 at 05:29:15PM +0530, shveta malik wrote:
> > Attached v75 patch-set. Changes are:
> >
> > 1) Re-arranged the patches:
> > 1.1) 'libpqrc' related changes (from v74-001 and v74-004) are
> > separated out
Hi.
this commit [0] changes immutability of jsonb_path_query,
jsonb_path_query_first?
If so, it may change other functions also.
demo:
begin;
SET LOCAL TIME ZONE 10.5;
with cte(s) as (select jsonb '"2023-08-15 12:34:56 +05:30"')
select jsonb_path_query(s,
'$.timestamp_tz()')::text,'+10.5'::text,
Hello Amit,
05.02.2024 15:20, Amit Kapila wrote:
If this can be reproduced frequently then we can even try to test the
patch in that thread by Osumi-San [1] (I haven't tested that it
applies cleanly but shouldn't be difficult to make it work) based on
the theory that walsender is starting up at
On Fri, Feb 2, 2024 at 8:47 PM John Naylor wrote:
>
> On Wed, Jan 31, 2024 at 12:50 PM Masahiko Sawada
> wrote:
> > I've attached the new patch set (v56). I've squashed previous updates
> > and addressed review comments on v55 in separate patches. Here are the
> > update summary:
> >
> > 0004: f
On Mon, Feb 05, 2024 at 05:41:25PM -0800, Andres Freund wrote:
> On 2024-02-06 10:01:36 +0900, Michael Paquier wrote:
>> If you have concerns about that, I'm OK to revert, I'm not wedded to
>> this level of control. Note that I've actually seen *better*
>> runtimes.
>
> I'm somewhat worried that
Hi,
Looking at the profiles in [1], and similar profiles locally, made me wonder
why a basic COPY TO shows pg_server_to_any() and the strlen() to compute the
length of the to-be-converted string so heavily in profiles. Example
profile, for [2]:
- 88.11%12.02% postgres postgres
Hi,
On 2024-02-06 10:01:36 +0900, Michael Paquier wrote:
> On Mon, Feb 05, 2024 at 10:21:18AM -0800, Andres Freund wrote:
> > Have you benchmarked the performance effects of 2889fd23be5 ? I'd not at all
> > be surprised if it lead to a measurable performance regression.
>
> Yes, I was looking at r
On Mon, Feb 05, 2024 at 10:21:18AM -0800, Andres Freund wrote:
> Have you benchmarked the performance effects of 2889fd23be5 ? I'd not at all
> be surprised if it lead to a measurable performance regression.
Yes, I was looking at runtimes and some profiles around CopyOneRowTo()
to see the effects
At Mon, 5 Feb 2024 17:22:56 +0900, Yugo NAGATA wrote in
> On Mon, 05 Feb 2024 11:28:59 +0900
> torikoshia wrote:
>
> > > Based on this, I've made a patch.
> > > based on COPY Synopsis: ON_ERROR 'error_action'
> > > on_error 'null', the keyword NULL should be single quoted.
> >
> > As you ment
Hello PostgreSQL Hackers,
This proposal suggests implementing OCSP Stapling in PostgreSQL as an
alternative and more efficient method for checking certificate
revocation, aligning with the trend shift from Certificate Revocation
Lists (CRL).
1. benefits
OCSP Stapling offers several advantag
On Mon, Feb 05, 2024 at 06:05:15PM +0900, Sutou Kouhei wrote:
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Mon, 5 Feb 2024 16:14:08 +0900,
> Michael Paquier wrote:
>> 2) I have backpedaled on the postpare callback, which did not bring
>> much in clari
Up to now, the explain " " (two space) format is not mixed with "=".
And, other places which show "Memory" do not use "=". David will
remember prior discussions.
https://www.postgresql.org/message-id/20200402054120.gc14...@telsasoft.com
https://www.postgresql.org/message-id/20200407042521.gh2...
Hi, Alexander!
On Mon, Feb 5, 2024 at 7:00 PM Alexander Lakhin wrote:
> 05.02.2024 02:51, Alexander Korotkov wrote:
>
> > Usage of heap_inplace_update() seems appropriate for me here. It
> > avoids trouble with both TOAST and row-level locks. Alexander, could
> > you please recheck this fixes t
According to the discussion in [1], it's not as safe as we supposed
to allow different threads to call bindtextdomain() concurrently.
Here is a patchset to prevent that by acquiring a mutex around
the libpq and ecpglib calls that are at risk.
In libpq, this would've required yet a third copy of th
On Sun, Feb 4, 2024 at 6:51 AM vignesh C wrote:
> We should do something about these kinds of entries, there were few
> suggestions like tagging under a new category or so, can we add a new
> status to park these entries something like "Waiting for direction".
> The threads which have no discussio
Hi,
Have you benchmarked the performance effects of 2889fd23be5 ? I'd not at all
be surprised if it lead to a measurable performance regression.
I think callbacks for individual attributes is the wrong approach - the
dispatch needs to happen at a higher level, otherwise there are too many
indirec
On 2024-Feb-05, Alvaro Herrera wrote:
> While playing with it I noticed this other behavior change from 16,
>
> create table pa (a int primary key) partition by list (a);
> create table pe (a int unique);
> alter table pa attach partition pe for values in (1, null);
>
> In 16, we get the error:
>> It seems something you want to keep for your personal use.
>> I think this filter is the kind of genious idea that it's OK if you
>> can do it at home
I don’t agree with your characterization.
The purpose of the filter is to bring existing Postgres comments into the
doxygen output. While I ha
Hello Alexander,
05.02.2024 02:51, Alexander Korotkov wrote:
Usage of heap_inplace_update() seems appropriate for me here. It
avoids trouble with both TOAST and row-level locks. Alexander, could
you please recheck this fixes the problem.
I've re-tested the last problematic scenario and can
On 05.02.24 02:29, Sutou Kouhei wrote:
catalog/syscache_ids.h is referred by utils/syscache.h but
it's not installed with Meson.
This has been fixed. (Somebody else reported it in a different thread
also.)
Hi hackers, I'm reaching out again regarding the patch with new extension 'pg_stat_advisor' aimed at enhancing query plan efficiency through the suggestion of creating statistics. I understand the community is busy, but I would greatly value any feedback or thoughts on this extension. Thank you for
Hi Hackers,
I just noticed that a couple of places in the docs spell I/O as IO or
even io when not referring to literal table/view/column names or values
therein. Here's a patch to fix them.
- ilmari
>From ed5f9ce738dd6356d5d68e4cfed95d8d98d2cde5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfin
On Feb 5, 2024, at 10:47 AM, Jim Jones wrote:
> The patch applies cleanly and it no longer crashes with NULL parameters.
> Docs render fine and regression tests pass. I have nothing more to add.
> Let's now wait for Pavel's review.
Much obliged!
D
Commit 344d62fb9a9 (2022) introduced unlogged sequences and made it so
that identity/serial sequences automatically get the persistence level
of their owning table. But this works only for CREATE TABLE and not for
ALTER TABLE / ADD COLUMN. This patch fixes that. (should be
backpatched to 15,
Peter Eisentraut writes:
> I always found the encoding of the pg_trigger.tgargs field quite weird
> and archaic. (It encodes the trigger argument list into a bytea
> column.)
It is that ...
> So I tried replacing this with a list of nodes in a
> pg_node_tree. This worked out quite nicely.
On 05.02.24 16:14, David E. Wheeler wrote:
> Right, done, and cleaned up the redundant comments.
>
> Best,
>
> David
Nice.
The patch applies cleanly and it no longer crashes with NULL parameters.
Docs render fine and regression tests pass. I have nothing more to add.
Let's now wait for Pavel's r
On 02.10.23 09:12, Peter Eisentraut wrote:
1) Remove useless entries from "unlike" lists. Runs that are not
listed in "like" don't need to be excluded in "unlike".
2) Ensure there is always a "like" list, even if it is empty. This
makes the test more self-documenting.
I also added c
On Feb 5, 2024, at 09:49, Jim Jones wrote:
> Yes, if the function was strict (which in the current design is not the
> case) there is no need to check for nulls.
Right, done, and cleaned up the redundant comments.
Best,
David
v3-0001-Add-parse_type-SQL-function.patch
Description: Binary dat
On Monday, February 5, 2024, Graham Leggett wrote:
>
> Also, how do you handle the race condition between the time a database db3
> is created, and the the time all readonly users have their access revoked
> to db3?
>
>
You alter the default privileges for the system so PUBLIC does not get
connec
On 2024-Feb-05, Alvaro Herrera wrote:
> So this regression test no longer fails:
>
> create table cnn2_parted(a int primary key) partition by list (a);
> create table cnn2_part1(a int);
> alter table cnn2_parted attach partition cnn2_part1 for values in (1);
> Here, in the existing code the ALTE
On 05.02.24 15:32, Dagfinn Ilmari Mannsåker wrote:
> Once the function is declared strict, I don't think either of these is
> necessary: function strictness is tested elsewhere, and it's the default
> behaviour. The only functions that explicitly say they return NULL on
> NULL inputs are quote_l
On 05.02.24 15:10, David E. Wheeler wrote:
> Excellent, thank you very much! Updated patch attached.
>
> Best,
>
> David
v2 no longer crashes with a null parameter.
docs and regress tests were updated accordingly.
patch no longer applies cleanly (tiny little indentation issue):
/home/jim/Downl
Jim Jones writes:
> 1) The function causes a crash when called with a NULL parameter:
>
> SELECT * FROM parse_type(NULL);
> server closed the connection unexpectedly
> This probably means the server terminated abnormally
> before or while processing the request.
> The connection t
On Mon, Feb 5, 2024 at 8:26 PM shveta malik wrote:
>
> On Mon, Feb 5, 2024 at 10:57 AM Ajin Cherian wrote:
> >
> > Just noticed that doc/src/sgml/config.sgml still refers to enable_synclot
> > instead of sync_replication_slots:
> >
> > The standbys corresponding to the physical replication slots
On Feb 5, 2024, at 08:02, Jim Jones wrote:
> There are a few issues though:
Excellent, thank you very much! Updated patch attached.
Best,
David
v2-0001-Add-parse_type-SQL-function.patch
Description: Binary data
On Feb 4, 2024, at 19:11, Erik Wienhold wrote:
> Here "extracted names" should be "extracted name" (singular).
> Otherwise, the text looks good.
Ah, thank you. Updated patch attached.
Best,
David
v2-0001-Update-to_regtype-docs-regarding-error-condition.patch
Description: Binary data
Hi David,
Thanks for the patch.
On 04.02.24 18:51, David E. Wheeler wrote:
> Hackers,
>
> Attached is a patch to add a new function, `parse_type()`. It parses a type
> string and returns a record with the typid and typmod for the type, or raises
> an error if the type is invalid. It’s effectivel
based on this query:
begin;
SET LOCAL TIME ZONE 10.5;
with cte(s) as (select jsonb '"2023-08-15 12:34:56 +05:30"')
select JSON_QUERY(s, '$.timestamp_tz()')::text,'+10.5'::text,
'timestamp_tz'::text from cte
union all
select JSON_QUERY(s, '$.time()')::text,'+10.5'::text, 'time'::text from cte
union
On Sat, Feb 3, 2024 at 12:30 PM Alexander Lakhin wrote:
>
> 03.02.2024 04:24, Tom Lane wrote:
> > I'm still wondering how come the failure seems to have suddenly gotten
> > way more common. The only changes that are in vaguely-related places
> > and fit the time frame are Amit's 732924043 and 776
On Sun, 4 Feb 2024 at 18:19, zwj wrote:
>
>I found an issue while using the latest version of PG15
> (8fa4a1ac61189efffb8b851ee77e1bc87360c445).
>
>This issue is related to Megre into and other concurrent statements being
> written.
>I obtained different results in Oracle and PG usin
On Mon, Feb 5, 2024 at 4:36 PM Amit Kapila wrote:
>
> I have pushed the first patch. Next, a few comments on 0002 are as follows:
Thanks for the feedback Amit. Some of these are addressed in v78. Rest
will be addressed in the next version.
> 1.
> +static bool
> +validate_parameters_and_get_dbnam
On Mon, Feb 5, 2024 at 7:59 AM Zhijie Hou (Fujitsu)
wrote:
>
I have pushed the first patch. Next, a few comments on 0002 are as follows:
1.
+static bool
+validate_parameters_and_get_dbname(char **dbname, int elevel)
For 0002, we don't need dbname as out parameter. Also, we can rename
the functio
On 2024-Feb-05, Michael Paquier wrote:
> On Mon, Feb 05, 2024 at 03:55:36PM +0900, Masahiko Sawada wrote:
> > Peter, could you check this fix as it seems the recent commits forgot
> > to update the meson.build file?
>
> The patched code is telling us that we're forgetting to install
> syscache_id
I always found the encoding of the pg_trigger.tgargs field quite weird
and archaic. (It encodes the trigger argument list into a bytea
column.) So I tried replacing this with a list of nodes in a
pg_node_tree. This worked out quite nicely. It makes the internal code
much simpler, and it wou
On Fri, 2 Feb 2024 at 11:30, Alexander Lakhin wrote:
>
> Hello Vignesh and Hou-san,
>
> 01.02.2024 07:59, vignesh C wrote:
> > Here is an updated patch which changes the boolean variable to a
> > tri-state enum and set stable state to valid only if no invalidations
> > have been occurred while the
On 2024-Feb-05, Alvaro Herrera wrote:
> Subject: [PATCH v1] Fix failure to merge NOT NULL constraints in inheritance
>
> set_attnotnull() was not careful to CommandCounterIncrement() in cases
> of multiple recursion. Omission in b0e96f311985.
Eh, this needs to read "multiple inheritance" rather
On 2024-Feb-05, Alvaro Herrera wrote:
> Hmm, let me have a look, I can probably get this one fixed today before
> embarking on a larger fix elsewhere in the same feature.
You know what -- this missing CCI has a much more visible impact, which
is that the attnotnull marker that a primary key impos
Hi,
On Thu, Jan 11, 2024 at 10:48:13AM +0530, Bharath Rupireddy wrote:
> Hi,
>
> Therefore, it is often easy for developers to do the following:
> a) set an XID age (age of slot's xmin or catalog_xmin) of say 1 or 1.5
> billion, after which the slots get invalidated.
> b) set a timeout of say 1 o
Hi,
In
"Re: Make COPY format extendable: Extract COPY TO format implementations" on
Mon, 5 Feb 2024 16:14:08 +0900,
Michael Paquier wrote:
> So, I've looked at all that today, and finished by applying two
> patches as of 2889fd23be56 and 95fb5b49024a to get some of the
> weirdness with the
On 05 Feb 2024, at 00:54, David G. Johnston wrote:
> I have a postgresql 15 instance with two databases in it, and I have a need
> to grant read-only access to one of those databases to a given user.
>>
>> To do this I created a dedicated role for readonly access to the database
>> db1:
>>
>>
On 2024-Feb-05, Michael Paquier wrote:
> On Fri, Feb 02, 2024 at 07:00:01PM +0300, Alexander Lakhin wrote:
> > results in:
> > NOTICE: merging definition of column "i" for child "b"
> > NOTICE: merging definition of column "i" for child "c"
> > ERROR: tuple already updated by self
> >
> > (Thi
On Mon, 05 Feb 2024 11:28:59 +0900
torikoshia wrote:
> > Based on this, I've made a patch.
> > based on COPY Synopsis: ON_ERROR 'error_action'
> > on_error 'null', the keyword NULL should be single quoted.
>
> As you mentioned, single quotation seems a little odd..
>
> I'm not sure what is the
On Mon, Feb 05, 2024 at 07:57:09AM +, Hayato Kuroda (Fujitsu) wrote:
> You are right. Based on the previous discussions, PageSetLSN() must be called
> after the MakeBufferDirty(). REGBUF_NO_CHANGE has been introduced for skipping
> these requirements. Definitevely, no_change buffers must not be
On Mon, Feb 05, 2024 at 03:55:36PM +0900, Masahiko Sawada wrote:
> I've confirmed this patch fixes the issue. But I don't have enough
> knowledge of meson to assess this fix.
>
> Peter, could you check this fix as it seems the recent commits forgot
> to update the meson.build file?
The patched co
76 matches
Mail list logo
