Re: https://git.postgresql.org/git/postgresql.git/ fails

On 28.08.23 08:09, Erik Rijkers wrote: I normally pull from   https://git.postgresql.org/git/postgresql.git/ but for a few hours now it's been failing (while other git repo's are still reachable). Is it me or is there a hiccup there? I see the same problem. Also, the buildfarm hasn't repo

Re: Convert encrypted SSL test keys to PKCS#8 format

On 22.08.23 21:02, Jacob Champion wrote: On Tue, Aug 22, 2023 at 1:07 AM Peter Eisentraut wrote: I have attached two patches, one to update the generation rules, and one where I have converted the existing test files. (I didn't generate them from scratch, so for example src/test/modules/ssl_pa

Re: Return value of pg_promote()

Hi Michael, On Thu, Aug 17, 2023 at 6:07 AM Michael Paquier wrote: > > On Wed, Aug 16, 2023 at 05:02:09PM +0900, Michael Paquier wrote: > > if (kill(PostmasterPid, SIGUSR1) != 0) > > { > > -ereport(WARNING, > > -(errmsg("failed to send signal to postmaster: %m"))

https://git.postgresql.org/git/postgresql.git/ fails

I normally pull from https://git.postgresql.org/git/postgresql.git/ but for a few hours now it's been failing (while other git repo's are still reachable). Is it me or is there a hiccup there? thanks, Erik Rijkers

Query execution in Perl TAP tests needs work

Hi, Every time we run a SQL query, we fork a new psql process and a new cold backend process. It's not free on Unix, and quite a lot worse on Windows, at around 70ms per query. Take amcheck/001_verify_heapam for example. It runs 272 subtests firing off a stream of queries, and completes in ~51s

Re: DecodeInterval fixes

On Sun, Aug 27, 2023 at 04:14:00PM -0400, Joseph Koshakow wrote: > On Tue, Aug 22, 2023 at 12:58 PM Jacob Champion > wrote: >> I wouldn't argue for backpatching, for sure, but I guess I saw this as >> falling into the same vein as 5b3c5953 and bcc704b52 which were >> already committed. > > I agre

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Dilip, Thank you for reading the thread! > I haven't read this thread in detail, but I have one high-level design > question. The upgrade of the replication slot is default or is it > under some GUC? I designed that logical slots were upgraded by default. > because if it is by default the

Re: [PoC] pg_upgrade: allow to upgrade publisher node

On Sat, Aug 26, 2023 at 9:54 AM Hayato Kuroda (Fujitsu) wrote: > > Dear Peter, > > Thank you for reviewing! PSA new version patch set. I haven't read this thread in detail, but I have one high-level design question. The upgrade of the replication slot is default or is it under some GUC? because

Re: pg_stat_get_backend_subxact() and backend IDs?

On Fri, Aug 25, 2023 at 10:56:14PM +, Imseih (AWS), Sami wrote: > > Here is a new version of the patch that avoids changing the names of the > > existing functions. I'm not thrilled about the name > > (pgstat_fetch_stat_local_beentry_by_backend_id), so I am open to > > suggestions. In any case,

Logger process and "LOG: could not close client or listen socket: Bad file descriptor"

Hi all, (Heikki in CC.) After b0bea38705b2, I have noticed that the syslogger is generating a lot of dummy LOG entries: 2023-08-28 09:40:52.565 JST [24554] LOG: could not close client or listen socket: Bad file descriptor The only reason why I have noticed this issue is because I enable the lo

Re: subscription/015_stream sometimes breaks

On Fri, Aug 25, 2023 at 8:15 PM Amit Kapila wrote: > > On Thu, Aug 24, 2023 at 3:48 PM Amit Kapila wrote: > > > > On Thu, Aug 24, 2023 at 1:20 PM Alvaro Herrera > > wrote: > > > > > > On 2023-Aug-24, Amit Kapila wrote: > > > > > > > On Wed, Aug 23, 2023 at 1:31 PM Alvaro Herrera > > > > wrote

Re: New WAL record to detect the checkpoint redo location

On Fri, Aug 25, 2023 at 11:08:25AM +0530, Dilip Kumar wrote: > Here is the updated version of the patch. The concept of the patch looks sound to me. I have a few comments. +* This special record, however, is not required when we doing a shutdown +* checkpoint, as there will be

Re: CI speed improvements for FreeBSD

And after adding this to the commitfest, here's the first cfbot run. The gain was due to "test_world" which shows a greater-than-2x speedup (~4:30 -> ~2:08) from 2x CPUs. That is nice for humans who want the answer as soon as possible, but note that the resource usage cost might go up because of t

CI speed improvements for FreeBSD

Hi, Here are a couple of changes that got FreeBSD down to 4:29 total, 2:40 in test_world in my last run (over 2x speedup), using a RAM disk backed by a swap partition, and more CPUs. It's still a regular UFS file system but FreeBSD is not as good at avoiding I/O around short lived files and direc

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 27/08/2023 16:41, Joe Conway wrote: On 8/15/23 10:40, Heikki Linnakangas wrote: If multiple interpreters are used, is the single perl_locale_obj variable still enough? Each interpreter can have their own locale I believe. So in other words plperl and plperlu both used in the same query? I d

Re: DecodeInterval fixes

On Tue, Aug 22, 2023 at 12:58 PM Jacob Champion wrote: > > On Mon, Aug 21, 2023 at 10:39 PM Michael Paquier wrote: > > 0002 and 0003 make this stuff fail, but isn't there a risk that this > > breaks applications that relied on these accidental behaviors? > > Assuming that this is OK makes me nerv

Re: list of acknowledgments for PG16

I'm not completely sure what should be in this list, but maybe also tuplesort extensibility [1]? [1] https://www.postgresql.org/message-id/flat/CALT9ZEHjgO_r2cFr35%3Du9xZa6Ji2e7oVfSEBRBj0Gc%2BtJjTxSg%40mail.gmail.com#201dc4202af38f224a1e3acc78795199

Re: list of acknowledgments for PG16

On 23.08.23 09:13, Denis Laxalde wrote: Peter Eisentraut a écrit : The list of acknowledgments for the PG16 release notes has been committed.  It should show up here sometime: .    As usual, please check for problems

Re: list of acknowledgments for PG16

On 22.08.23 15:48, Vik Fearing wrote: On 8/22/23 11:33, Peter Eisentraut wrote: The list of acknowledgments for the PG16 release notes has been committed.  It should show up here sometime: .  As usual, please check

Re: persist logical slots to disk during shutdown checkpoint

On Fri, 25 Aug 2023 at 17:40, vignesh C wrote: > > On Sat, 19 Aug 2023 at 11:53, Amit Kapila wrote: > > > > It's entirely possible for a logical slot to have a confirmed_flush > > LSN higher than the last value saved on disk while not being marked as > > dirty. It's currently not a problem to lo

Re: Incremental View Maintenance, take 2

On Sun, 2 Jul 2023 10:38:20 +0800 jian he wrote: > ok. Now I really found a small bug. > > this works as intended: > BEGIN; > CREATE INCREMENTAL MATERIALIZED VIEW test_ivm AS SELECT i, MIN(j) as > min_j FROM mv_base_a group by 1; > INSERT INTO mv_base_a select 1,-2 where false; > rollback; > >

Re: UTF8 national character data type support WIP patch and list of open issues.

Hi, Although this is a ten-year-old message, it was the one I found quickly when looking to see what the current state of play on this might be. On 2013-09-20 14:22, Robert Haas wrote: Hmm. So under that design, a database could support up to a total of two character sets, the one that you get

Re: Incremental View Maintenance, take 2

On Sun, 2 Jul 2023 08:25:12 +0800 jian he wrote: > This is probably not trivial. > In function apply_new_delta_with_count. > > appendStringInfo(&querybuf, > "WITH updt AS (" /* update a tuple if this exists in the view */ > "UPDATE %s AS mv SET %s = mv.%s OPERATOR(pg_catalog.+) diff.%s " > "%s

Re: Incremental View Maintenance, take 2

On Fri, 30 Jun 2023 08:00:00 +0800 jian he wrote: > Hi there. > in v28-0005-Add-Incremental-View-Maintenance-support-to-psql.patch > I don't know how to set psql to get the output > "Incremental view maintenance: yes" This information will appear when you use "d+" command for an incrementally m

Re: Incremental View Maintenance, take 2

On Thu, 29 Jun 2023 18:51:06 +0800 jian he wrote: > I cannot build the doc. > git clean -fdx > git am ~/Desktop/tmp/*.patch > > Applying: Add a syntax to create Incrementally Maintainable Materialized Views > Applying: Add relisivm column to pg_class system catalog > Applying: Allow to prolong

Re: Incremental View Maintenance, take 2

On Thu, 29 Jun 2023 18:20:32 +0800 jian he wrote: > On Thu, Jun 29, 2023 at 12:40 AM jian he wrote: > > > > On Wed, Jun 28, 2023 at 4:06 PM Yugo NAGATA wrote: > > > > > > On Wed, 28 Jun 2023 00:01:02 +0800 > > > jian he wrote: > > > > > > > On Thu, Jun 1, 2023 at 2:47 AM Yugo NAGATA wrote: >

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 8/15/23 10:40, Heikki Linnakangas wrote: On 01/08/2023 16:48, Joe Conway wrote: Any further comments on the posted patch[1]? I would like to apply/push this prior to the beta and minor releases next week. I'm not sure about the placement of the uselocale() calls. In plperl_spi_exec(), for e

Re: Incremental View Maintenance, take 2

On Thu, 29 Jun 2023 00:40:45 +0800 jian he wrote: > On Wed, Jun 28, 2023 at 4:06 PM Yugo NAGATA wrote: > > > > On Wed, 28 Jun 2023 00:01:02 +0800 > > jian he wrote: > > > > > On Thu, Jun 1, 2023 at 2:47 AM Yugo NAGATA wrote: > > > > > > > > On Thu, 1 Jun 2023 23:59:09 +0900 > > > > Yugo NAGATA

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Wed, Aug 16, 2023 at 8:04 PM John Naylor wrote: > > > On Tue, Aug 15, 2023 at 6:53 PM John Naylor > wrote: > > > > On Tue, Aug 15, 2023 at 9:34 AM Masahiko Sawada > > wrote: > > > > > BTW cfbot reported that some regression tests failed due to OOM. I've > > > attached the patch to fix it. >

RE: logical_replication_mode

On Friday, August 25, 2023 5:56 PM Amit Kapila wrote: > > On Fri, Aug 25, 2023 at 12:38 PM Peter Eisentraut > wrote: > > > > On 25.08.23 08:52, Zhijie Hou (Fujitsu) wrote: > > > On Friday, August 25, 2023 12:28 PM Amit Kapila > wrote: > > >> > > >> On Thu, Aug 24, 2023 at 12:45 PM Peter Eisent

[PoC] Implementation of distinct in Window Aggregates: take two

Hi, This is reopening of thread: https://www.postgresql.org/message-id/flat/2ef6b491-1946-b606-f064-d9ea79d91463%40gmail.com#14e0bdb6872c0b26023d532eeb943d3e This is a PoC patch which implements distinct operation in window aggregates (without order by and for single column aggregation, final ver

Re: Make all Perl warnings fatal

On 2023-08-25 Fr 16:49, Dagfinn Ilmari Mannsåker wrote: Alvaro Herrera writes: On 2023-Aug-10, Peter Eisentraut wrote: I wanted to figure put if we can catch these more reliably, in the style of -Werror. AFAICT, there is no way to automatically turn all warnings into fatal errors. But the

Re: Ignore 2PC transaction GIDs in query jumbling

On Sat, Aug 19, 2023 at 01:47:48PM +0900, Michael Paquier wrote: > On Fri, Aug 18, 2023 at 11:31:03AM +0100, Dagfinn Ilmari Mannsåker wrote: >> I don't have a particularly strong opinion on whether we should >> distinguish DEALLOCATE ALL from DEALLOCATE (call it +0.5), but > > The difference look