On Wed, Jul 05, 2023 at 08:49:26PM -0700, Nathan Bossart wrote:
> On Thu, Jul 06, 2023 at 08:21:18AM +0900, Michael Paquier wrote:
>> Removing the GUC from this table is kind of annoying. Cannot this be
>> handled like default_with_oids or ssl_renegotiation_limit to avoid any
>> kind of issues wit
At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh wrote in
> On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela wrote:
> >
> > Hi,
> >
> > This has already been discussed in [1].
> > But I thought it best to start a new thread.
> >
> > The commit 31966b1 introduced the infrastructure to extend
> > buff
On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi
wrote:
>
> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
> >
> > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> > > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
> > >> + appendStringInfoString(&errhin
On Monday, July 10, 2023 3:22 AM Zheng Li wrote:
>
> On Tue, Jun 27, 2023 at 6:16 AM vignesh C wrote:
>
> > While development, below are some of the challenges we faced:
>
> > 1. Almost all the members of the AlterTableType enum will have to be
> annotated.
> > 2. Complex functionalities which
On 7/10/23 7:20 AM, Michael Paquier wrote:
On Mon, Jul 10, 2023 at 07:05:30AM +0200, Drouvot, Bertrand wrote:
Yeah there is one in generate-wait_event_types.pl. I was wondering
to add one in wait_event_names.txt too (as this is the place where
no wait events would be added if any).
Hmm. So
On Mon, Jul 10, 2023 at 07:05:30AM +0200, Drouvot, Bertrand wrote:
> Yeah there is one in generate-wait_event_types.pl. I was wondering
> to add one in wait_event_names.txt too (as this is the place where
> no wait events would be added if any).
Hmm. Something like that could be done, for instanc
On Mon, Jul 10, 2023 at 02:07:09PM +0900, Kyotaro Horiguchi wrote:
> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
>> Sorry for the late reply! I'm not sure. How can I know whether it is
>> translatable?
Per the documentation:
https://www.postgresql.org/docs/devel/nls-programmer.html#
At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
>
> On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> > On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
> >> + appendStringInfoString(&errhint, "\"stderr\"");
> >> +#ifdef HAVE_SYSLOG
> >> + a
Hi,
On 7/9/23 9:36 AM, Michael Paquier wrote:
On Sun, Jul 09, 2023 at 09:15:34AM +0200, Drouvot, Bertrand wrote:
I also noticed that you now provide the culprit line in case of parsing
failure (thanks for that).
Yes, that's mentioned in the commit message I quickly wrote in 0002.
#
-# "
On Thu, Jul 06, 2023 at 10:29:10AM -0500, Tristan Partin wrote:
> On Thu Apr 27, 2023 at 12:54 AM CDT, Bharath Rupireddy wrote:
>> Why do we need both time_to_abort and ready_to_exit?
>
> I am trying to understand why we need both as well. Maybe I am missing
> something important :).
As StreamLog
On Mon, Jul 10, 2023 at 7:55 AM Peter Smith wrote:
>
> On Sat, Jul 8, 2023 at 1:49 PM Amit Kapila wrote:
> >
> > On Fri, Jul 7, 2023 at 1:36 PM Masahiko Sawada
> > wrote:
> > >
> > > I prefer the first suggestion. I've attached the updated patch.
> > >
> >
> > This looks mostly good to me but I
On Fri, Jul 07, 2023 at 06:12:48PM +, Akshat Jaimini wrote:
> I believe it is ready to be committed!
Okay, thanks. Please note that I have backpatched the bug and added
the checks for the callers of changeDependencyFor() on HEAD on top of
the bugfix.
--
Michael
signature.asc
Description: PG
On Sun, Jul 9, 2023 at 1:01 PM Bharath Rupireddy
wrote:
>
> On Fri, Jun 16, 2023 at 3:26 PM Amit Kapila wrote:
> >
> >
> > 1. Can you please try to explain the functionality of the overall
> > patch somewhere in the form of comments and or commit message?
>
> IIUC, there are 2 core ideas of the f
Dear Amit,
> > Yes, I agree, it is (and was before my patch as well) un-documented
> limitation of REPLICA IDENTITY FULL.
> > And, as far as I can see, my patch actually didn't have any impact on the
> limitation. The unsupported
> > cases are still unsupported, but now the same error is thrown in
Dear hackers,
This is a fork thread from [1]. While analyzing codes I noticed that UPDATE and
DELETE cannot be replicated when REPLICA IDENTITY is FULL and the table has
datatype
which does not have the operator class of Btree. I thnk this restriction is not
documented but should be. PSA the patc
On 7/7/2023 15:20, Alena Rybakina wrote:
because we will provide similar manipulation in this:
foreach(l, gentry->consts)
{
Node *rexpr = (Node *) lfirst(l);
rexpr = coerce_to_common_type(pstate, rexpr,
scalar_type,
On Sun, Jul 9, 2023 at 6:35 PM Thomas Munro wrote:
> On Sun, Jul 9, 2023 at 6:20 PM Peter Eisentraut wrote:
> > So I don't think this code is correct. AFAICT, there is nothing right
> > now that can possibly define HAVE_MBSTOWCS_L on Windows/MSVC. Was that
> > the intention?
>
> Yes, that was m
Dear hackers,
Hi, I did a performance testing for v16 patch set.
Results show that patches significantly improves the performance in most cases.
# Method
Following tests were done 10 times per condition, and compared by median.
do_one_test.sh was used for the testing.
1. Create tables on p
On Sat, Jul 8, 2023 at 1:49 PM Amit Kapila wrote:
>
> On Fri, Jul 7, 2023 at 1:36 PM Masahiko Sawada wrote:
> >
> > I prefer the first suggestion. I've attached the updated patch.
> >
>
> This looks mostly good to me but I think it would be better if we can
> also add the information that the lef
On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
>> +appendStringInfoString(&errhint, "\"stderr\"");
>> +#ifdef HAVE_SYSLOG
>> +appendStringInfoString(&errhint, ", \"syslog\"");
>> +#endif
>>
On Sun, Jul 9, 2023 at 1:03 PM Joseph Koshakow wrote:
>> * Only a superuser may set auth ID to something other than himself
> Is "auth ID" the right term here? Maybe something like "Only a
> superuser may set their session authorization/ID to something other
> than their authenticated ID."
>>
Thanks all for the reviews. I pushed the first two small patches.
Here is a new version of the main --disable-thread-safety removal
part, with these changes:
* fixed LDAP_LIBS_FE snafu reported by Peter E
* defined ENABLE_THREAD_SAFETY 1 in c.h, for the benefit of extensions
* defined ENABLE_THRE
On 7/9/23 20:05, Heikki Linnakangas wrote:
> On 09/07/2023 19:16, Tomas Vondra wrote:
>> On 7/8/23 23:57, Heikki Linnakangas wrote:
>>> The new preprocess support function feels a bit too inflexible to me.
>>> True, you can store whatever you want in the ScanKey that it returns,
>>> but since that'
On Tue, Jun 27, 2023 at 6:16 AM vignesh C wrote:
> While development, below are some of the challenges we faced:
> 1. Almost all the members of the AlterTableType enum will have to be
> annotated.
> 2. Complex functionalities which require access to catalog tables
> cannot be auto generated, cu
On Sat, 2023-07-08 at 13:18 -0400, Joseph Koshakow wrote:
> Jacob Champion writes:
> > Hi Joe, here's a partial review:
>
> Thanks so much for the review!
>
> > I'm new to this code, but I agree that the use of `type` and the
> > lookahead are not particularly obvious/intuitive. At the very
> >
On 7/7/23 01:38, Gurjeet Singh wrote:
On Thu, Jul 6, 2023 at 12:37 AM Masahiko Sawada wrote:
On Sat, Jul 1, 2023 at 8:57 AM Joe Conway wrote:
>
> The basic idea is to mirror how pg_stat_statements works, except the
> logged messages keyed by filename, lineno, and elevel are saved with a
> aggr
On Sun, Jul 9, 2023 at 9:57 AM Peter Eisentraut
wrote:
> committed
>
Thanks!
--
Best regards,
Anatoly Zaretsky
On 09/07/2023 19:16, Tomas Vondra wrote:
On 7/8/23 23:57, Heikki Linnakangas wrote:
The new preprocess support function feels a bit too inflexible to me.
True, you can store whatever you want in the ScanKey that it returns,
but since that's the case, why not just make it void * ? It seems that
t
On Sat, Jul 8, 2023 at 5:06 PM Gurjeet Singh wrote:
> I feel the staleness/deficiencies you mention above are not
> captured in the TODO wiki page. It'd be nice if these were documented,
> so that newcomers to the community can pick up work that they feel is
> an easy lift for them.
I think that
On Sun, Jul 9, 2023 at 12:47 AM Nathan Bossart
wrote:
> I think we should split this into two patches: one to move the permission
> check to check_session_authorization() and another for the behavior
change.
> I've attached an attempt at the first one (that borrows heavily from your
> latest patc
On 7/8/23 23:57, Heikki Linnakangas wrote:
> On 02/07/2023 19:09, Tomas Vondra wrote:
>> Here's an updated version of the patch series.
>>
>> I've polished and pushed the first three patches with cleanup, tests to
>> improve test coverage and so on. I chose not to backpatch those - I
>> planned to
On 08.07.2023 20:07, Tom Lane wrote:
1. I was thinking in terms of dropping the "Member of" column entirely
in \du and \dg. It doesn't tell you enough, and the output of those
commands is often too wide already.
I understood it that way that the dropping "Member of" column will be
done as par
On Sun, Jul 09, 2023 at 09:15:34AM +0200, Drouvot, Bertrand wrote:
> I also noticed that you now provide the culprit line in case of parsing
> failure (thanks for that).
Yes, that's mentioned in the commit message I quickly wrote in 0002.
> #
> -# "C symbol in enums" "format in the system view
On Fri, Jun 16, 2023 at 3:26 PM Amit Kapila wrote:
>
> On Mon, Apr 17, 2023 at 7:37 PM Drouvot, Bertrand
> wrote:
> >
> > Please find attached V5 (a rebase of V4 posted up-thread).
> >
> > In addition to the "rebasing" work, the TAP test adds a test about conflict
> > handling (logical slot inva
On 06.07.23 15:41, Tristan Partin wrote:
On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote:
On 05.07.23 23:06, Tristan Partin wrote:
Thanks for following up. My system is Fedora 38. I can confirm this is
still happening on master.
$ gcc --version
gcc (GCC) 13.1.1 20230614 (Red Hat 13.1
Hi,
On 7/9/23 6:32 AM, Michael Paquier wrote:
On Fri, Jul 07, 2023 at 01:49:24PM +0900, Michael Paquier wrote:
Hmm. If we go down this road I would make the choice of simplicity
and remove entirely a column, then, generating the snakecase from the
camelcase or vice-versa (say like a $string =~
36 matches
Mail list logo
